Skip to contentSkip to conversation

ARM: dts: at91: sama7g5ek: enable pull-up on flexcom3 console lines

PATCH In review Eugen Hristev 3 participants 3 messages Mar 7, 2022 – Apr 13, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: dts: at91: sama7g5ek: enable pull-up on flexcom3 console lines

Flexcom3 is used as board console serial. There are no pull-ups on these lines on the board. This means that if a cable is not connected (that has pull-ups included), stray characters could appear on the console as the floating pins voltage levels are interpreted as incoming characters. To avoid this problem, enable the internal pull-ups on these lines.

---
 arch/arm/boot/dts/at91-sama7g5ek.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/at91-sama7g5ek.dts +1 -1
index 08685a10eda1d..dd047a8523907 100644
@@ -495,7 +495,7 @@ pinctrl_flx0_default: flx0_default {
 	pinctrl_flx3_default: flx3_default {
 		pinmux = <PIN_PD16__FLEXCOM3_IO0>,
 			 <PIN_PD17__FLEXCOM3_IO1>;
-		bias-disable;
+		bias-pull-up;
 	};
 
 	pinctrl_flx4_default: flx4_default {
Signature · 1 line
2.25.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Eugen Hristev

Flexcom3 is used as board console serial. There are no pull-ups on these lines on the board. This means that if a cable is not connected (that has pull-ups included), stray characters could appear on the console as the floating pins voltage levels are interpreted as incoming characters. To avoid this problem, enable the internal pull-ups on these lines.

Quoted 17 lines
---
 arch/arm/boot/dts/at91-sama7g5ek.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/at91-sama7g5ek.dts +1 -1
index 08685a10eda1d..dd047a8523907 100644
@@ -495,7 +495,7 @@ pinctrl_flx0_default: flx0_default {
 	pinctrl_flx3_default: flx3_default {
 		pinmux = <PIN_PD16__FLEXCOM3_IO0>,
 			 <PIN_PD17__FLEXCOM3_IO1>;
-		bias-disable;
+		bias-pull-up;
 	};
 
 	pinctrl_flx4_default: flx4_default {
maintainer Acked-by
#2 lore raw
Quoted 10 lines · On 08/03/2022 at 09:21, Tudor Ambarus - M18064 wrote:
Quoted 7 lines · Eugen Hristev

Flexcom3 is used as board console serial. There are no pull-ups on these lines on the board. This means that if a cable is not connected (that has pull-ups included), stray characters could appear on the console as the floating pins voltage levels are interpreted as incoming characters. To avoid this problem, enable the internal pull-ups on these lines.

and queued for "fixes". Thanks!
Best regards,
Nicolas

Quoted 19 lines
Quoted 18 lines
---
  arch/arm/boot/dts/at91-sama7g5ek.dts | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/at91-sama7g5ek.dts +1 -1
index 08685a10eda1d..dd047a8523907 100644
@@ -495,7 +495,7 @@ pinctrl_flx0_default: flx0_default {
  	pinctrl_flx3_default: flx3_default {
  		pinmux = <PIN_PD16__FLEXCOM3_IO0>,
  			 <PIN_PD17__FLEXCOM3_IO1>;
-		bias-disable;
+		bias-pull-up;
  	};
 
  	pinctrl_flx4_default: flx4_default {
Signature · 1 line
Nicolas Ferre