ipaddress: remove 'label' compatibility with Linux-2.0 net aliases
Subsystems (2)
PATCH v2 1/1 ipaddress: remove 'label' compatibility with Linux-2.0 net aliases
Sorry, I am not familiar with the contribution through mail mecanism and the git send-email command.
I tried to resubmit my patch in reply to
https://patchwork.kernel.org/project/netdevbpf/patch/[email protected]/#24766590
but I don't see my message appearing in the mailing list archive… so I tried multiple git send-email argument combination. You might have receive this mail multiple times.
As Linux-2.0 is getting old and systemd allows non Linux-2.0 compatible aliases to be set, I think iproute2 should be able to manage such aliases.
Signed-off-by Maxime de Roucy <[email protected]>
--- ip/ipaddress.c | 16 ---------------- man/man8/ip-address.8.in | 3 --- 2 files changed, 19 deletions(-)
ip/ipaddress.c +0 -16
@@ -2349,16 +2349,6 @@ static bool ipaddr_is_multicast(inet_prefix *a)return false; } -static bool is_valid_label (const char *dev,const char *label) -{ -size_t len =strlen (dev); - -if (strncmp (label, dev, len) !=0 ) -return false; - -return label[len] =='\0' || label[len] ==':' ; -} -static int ipaddr_modify (int cmd,int flags,int argc,char **argv) {struct {
@@ -2501,12 +2491,6 @@ static int ipaddr_modify(int cmd, int flags, int argc, char **argv)fprintf (stderr,"Not enough information: \"dev\" argument is required.\n" );return -1 ; } -if (l && !is_valid_label (d, l)) { -fprintf (stderr, -"\"label\" (%s) must match \"dev\" (%s) or be prefixed by \"dev\" with a colon.\n" , - l, d); -return -1 ; - }if (peer_len ==0 && local_len) {if (cmd ==RTM_DELADDR && lcl.family ==AF_INET && !(lcl.flags &PREFIXLEN_SPECIFIED )) {
man/man8/ip-address.8.in +0 -3
@@ -195,9 +195,6 @@ is derived by setting/resetting the host bits of the interface prefix. .TP .BI label " LABEL" Each address may be tagged with a label string. -In order to preserve compatibility with Linux-2.0 net aliases, -this string must coincide with the name of the device or must be prefixed -with the device name followed by colon. The maximum allowed total length of label is 15 characters. .TP
Signature · 1 line
2.35.1