pinctrl/rockchip: Add missing of_node_put() in rockchip_pinctrl_probe
Subsystems (3)
PATCH 1/1 pinctrl/rockchip: Add missing of_node_put() in rockchip_pinctrl_probe
The device_node pointer is returned by of_parse_phandle() with refcount incremented. We should use of_node_put() on it when done.
Fixes 1e747e59cc4d ("pinctrl: rockchip: base regmap supplied by a syscon")
Fixes 14dee8677e19 ("pinctrl: rockchip: let pmu registers be supplied by a syscon")
Signed-off-by Miaoqian Lin <[email protected]>
--- drivers/pinctrl/pinctrl-rockchip.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/pinctrl/pinctrl-rockchip.c +2 -0
@@ -2693,6 +2693,7 @@ static int rockchip_pinctrl_probe(struct platform_device *pdev) node =of_parse_phandle (np,"rockchip,grf" ,0 );if (node) { info->regmap_base =syscon_node_to_regmap (node); +of_node_put (node);if (IS_ERR (info->regmap_base))return PTR_ERR (info->regmap_base); }else {
@@ -2725,6 +2726,7 @@ static int rockchip_pinctrl_probe(struct platform_device *pdev) node =of_parse_phandle (np,"rockchip,pmu" ,0 );if (node) { info->regmap_pmu =syscon_node_to_regmap (node); +of_node_put (node);if (IS_ERR (info->regmap_pmu))return PTR_ERR (info->regmap_pmu); }
Signature · 1 line
2.17.1
Quoted 6 lines · Miaoqian Lin
The
device_nodepointer is returned byof_parse_phandle()with refcount incremented. We should useof_node_put()on it when done.Fixes 1e747e59cc4d ("pinctrl: rockchip: base regmap supplied by a syscon")Fixes 14dee8677e19 ("pinctrl: rockchip: let pmu registers be supplied by a syscon")Signed-off-by Miaoqian Lin <[email protected]>
Patch applied.
Yours,
Linus Walleij