Skip to contentSkip to conversation

misc: rtsx: fix indenting in rts5228_extra_init_hw()

PATCH In review Dan Carpenter 2 participants 2 messages Mar 7, 2022 – Mar 18, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 misc: rtsx: fix indenting in rts5228_extra_init_hw()

This code should be indented one more tab.

---
Introduced in commit 86f4c65fd500 ("misc: rtsx: rts522a rts5228 rts5261 support Runtime PM"). No Fixes tag because it's not a bug.

 drivers/misc/cardreader/rts5228.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/misc/cardreader/rts5228.c +3 -3
index af581f4f74d1..ec97854e1f70 100644
@@ -491,9 +491,9 @@ static int rts5228_extra_init_hw(struct rtsx_pcr *pcr)
 
 	if (pcr->rtd3_en) {
 		rtsx_pci_write_register(pcr, pcr->reg_pm_ctrl3, 0x01, 0x01);
-	rtsx_pci_write_register(pcr, RTS5228_REG_PME_FORCE_CTL,
-				FORCE_PM_CONTROL | FORCE_PM_VALUE,
-				FORCE_PM_CONTROL | FORCE_PM_VALUE);
+		rtsx_pci_write_register(pcr, RTS5228_REG_PME_FORCE_CTL,
+					FORCE_PM_CONTROL | FORCE_PM_VALUE,
+					FORCE_PM_CONTROL | FORCE_PM_VALUE);
 	} else {
 		rtsx_pci_write_register(pcr, pcr->reg_pm_ctrl3, 0x01, 0x00);
 		rtsx_pci_write_register(pcr, RTS5228_REG_PME_FORCE_CTL,
Signature · 1 line
2.20.1
#1 lore raw
Quoted 30 lines · Dan Carpenter

This code should be indented one more tab.

---
Introduced in commit 86f4c65fd500 ("misc: rtsx: rts522a rts5228 rts5261 support Runtime PM"). No Fixes tag because it's not a bug.

 drivers/misc/cardreader/rts5228.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/misc/cardreader/rts5228.c +3 -3
index af581f4f74d1..ec97854e1f70 100644
@@ -491,9 +491,9 @@ static int rts5228_extra_init_hw(struct rtsx_pcr *pcr)
 
 	if (pcr->rtd3_en) {
 		rtsx_pci_write_register(pcr, pcr->reg_pm_ctrl3, 0x01, 0x01);
-	rtsx_pci_write_register(pcr, RTS5228_REG_PME_FORCE_CTL,
-				FORCE_PM_CONTROL | FORCE_PM_VALUE,
-				FORCE_PM_CONTROL | FORCE_PM_VALUE);
+		rtsx_pci_write_register(pcr, RTS5228_REG_PME_FORCE_CTL,
+					FORCE_PM_CONTROL | FORCE_PM_VALUE,
+					FORCE_PM_CONTROL | FORCE_PM_VALUE);
 	} else {
 		rtsx_pci_write_register(pcr, pcr->reg_pm_ctrl3, 0x01, 0x00);
 		rtsx_pci_write_register(pcr, RTS5228_REG_PME_FORCE_CTL,
Signature · 1 line
2.20.1

Someone beat you to it:

	https://lore.kernel.org/r/[email protected]