udf: remove redundant assignment of variable etype
Subsystems (2)
PATCH 1/1 udf: remove redundant assignment of variable etype
Variable etype is being assigned a value that is never read. The variable and assignment are redundant and can be removed.
Cleans up clang scan build warning:fs/udf/super.c:2485:10: warning: Although the value stored to 'etype' is used in the enclosing expression, the value is never actually read from 'etype' [deadcode.DeadStores]
--- fs/udf/super.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
fs/udf/super.c +1 -2
@@ -2474,7 +2474,6 @@ static unsigned int udf_count_free_table(struct super_block *sb,unsigned int accum =0 ;uint32_t elen;struct kernel_lb_addr eloc; -int8_t etype;struct extent_position epos;mutex_lock (&UDF_SB (sb)->s_alloc_mutex);
@@ -2482,7 +2481,7 @@ static unsigned int udf_count_free_table(struct super_block *sb, epos.offset =sizeof (struct unallocSpaceEntry ); epos.bh =NULL ; -while ((etype =udf_next_aext (table, &epos, &eloc, &elen,1 )) !=-1 ) +while (udf_next_aext (table, &epos, &eloc, &elen,1 ) !=-1 ) accum += (elen >> table->i_sb->s_blocksize_bits);brelse (epos.bh);
Signature · 1 line
2.35.1
Quoted 9 lines · Colin Ian King
Variable etype is being assigned a value that is never read. The variable and assignment are redundant and can be removed.
Cleans up clang scan build warning:
fs/udf/super.c:2485:10: warning: Although the value stored to 'etype' is used in the enclosing expression, the value is never actually read from 'etype' [deadcode.DeadStores]Signed-off-by Colin Ian King <[email protected]>
Thanks! I've added the patch to my tree.
Honza
Quoted 28 lines
--- fs/udf/super.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)fs/udf/super.c +1
-2@@ -2474,7 +2474,6 @@ static unsigned int udf_count_free_table(struct super_block *sb,unsigned int accum =0 ;uint32_t elen;struct kernel_lb_addr eloc; -int8_t etype;struct extent_position epos;mutex_lock (&UDF_SB (sb)->s_alloc_mutex);@@ -2482,7 +2481,7 @@ static unsigned int udf_count_free_table(struct super_block *sb, epos.offset =sizeof (struct unallocSpaceEntry ); epos.bh =NULL ; -while ((etype =udf_next_aext (table, &epos, &eloc, &elen,1 )) !=-1 ) +while (udf_next_aext (table, &epos, &eloc, &elen,1 ) !=-1 ) accum += (elen >> table->i_sb->s_blocksize_bits);brelse (epos.bh);Signature · 1 line
2.35.1
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR