drm/selftests: missing error code in igt_buddy_alloc_smoke()
Subsystems (3)
PATCH 1/1 drm/selftests: missing error code in igt_buddy_alloc_smoke()
Set the error code to -ENOMEM if drm_random_order() fails.
--- drivers/gpu/drm/selftests/test-drm_buddy.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
drivers/gpu/drm/selftests/test-drm_buddy.c +3 -1
@@ -488,8 +488,10 @@ static int igt_buddy_alloc_smoke(void *arg) } order =drm_random_order (mm.max_order +1 , &prng); -if (!order) +if (!order) { + err = -ENOMEM ; goto out_fini; + }for (i =0 ; i <= mm.max_order; ++i) {struct drm_buddy_block *block;
Signature · 1 line
2.20.1
Quoted 25 lines · Dan Carpenter
Set the error code to
-ENOMEMifdrm_random_order()fails.Fixes e6ff5ef81170 ("drm/selftests: add drm buddy smoke testcase")Signed-off-by Dan Carpenter <[email protected]>--- drivers/gpu/drm/selftests/test-drm_buddy.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/gpu/drm/selftests/test-drm_buddy.c +3
-1@@ -488,8 +488,10 @@ static int igt_buddy_alloc_smoke(void *arg) } order =drm_random_order (mm.max_order +1 , &prng); -if (!order) +if (!order) { + err = -ENOMEM ; goto out_fini; + }for (i =0 ; i <= mm.max_order; ++i) {struct drm_buddy_block *block;
Christian König
AppliedPushed to drm-misc-next. Just one nit below.
Am 07.03.22 um 15:54 schrieb Arunpravin:
Quoted 1 line
Reviewed-by Arunpravin <[email protected]>
Some people are picky about using the full name here.
And you I think we should volunteer you for maintaining that stuff :)
So you might want to get commit rights for drm-misc-next as well.
Christian.
Quoted 27 lines · Dan Carpenter
Quoted 25 lines
Set the error code to
-ENOMEMifdrm_random_order()fails.Fixes e6ff5ef81170 ("drm/selftests: add drm buddy smoke testcase")Signed-off-by Dan Carpenter <[email protected]>--- drivers/gpu/drm/selftests/test-drm_buddy.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)drivers/gpu/drm/selftests/test-drm_buddy.c +3
-1@@ -488,8 +488,10 @@ static int igt_buddy_alloc_smoke(void *arg) } order =drm_random_order (mm.max_order +1 , &prng); -if (!order) +if (!order) { + err = -ENOMEM ; goto out_fini; + }for (i =0 ; i <= mm.max_order; ++i) {struct drm_buddy_block *block;
Quoted 7 lines · Christian König
Pushed to drm-misc-next. Just one nit below.
Am 07.03.22 um 15:54 schrieb Arunpravin:
Quoted 1 line
Reviewed-by Arunpravin <[email protected]>Some people are picky about using the full name here.
Signed-off-by is like signing a legal document to say that you have not stolen anyone else's copyrighted works (SCO lawsuit). So it should be whatever name you use to sign legal documents.
regards,
dan carpenter