Skip to contentSkip to conversation

drm/i915/display/vrr: Reset VRR capable property on a long hpd

PATCH In review Manasi Navare 3 participants 7 messages Mar 3, 2022 – Mar 10, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v7 1/1 drm/i915/display/vrr: Reset VRR capable property on a long hpd

With some VRR panels, user can turn VRR ON/OFF on the fly from the panel settings. When VRR is turned OFF ,sends a long HPD to the driver clearing the Ignore MSA bit in the DPCD. Currently the driver parses that onevery HPD but fails to reset the corresponding VRR Capable Connector property.
Hence the userspace still sees this as VRR Capable panel which is incorrect.

Fix this by explicitly resetting the connector property.

v2: Reset vrr capable if status == connector_disconnected
v3: Use i915 and use bool vrr_capable (Jani Nikula)
v4: Move vrr_capable to after update modes call (Jani N) Remove the redundant comment (Jan N)
v5: Fixes the regression on older platforms by reseting the VRR only if HAS_VRR
v6: Remove the checks from driver, add in drm core before setting VRR prop (Ville)
v7: Move VRR set/reset to set/unset_edid (Ville)

Cc Jani Nikula <[email protected]>
Cc Ville Syrjälä <[email protected]>
Fixes 390a1f8beb87 ("Revert "drm/i915/display/vrr: Reset VRR capable property on a long hpd")
---
 drivers/gpu/drm/i915/display/intel_dp.c | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/display/intel_dp.c +11 -6
index d6ef33096bb6..1d0f8fc39005 100644
@@ -4385,13 +4385,20 @@ intel_dp_update_420(struct intel_dp *intel_dp)
 static void
 intel_dp_set_edid(struct intel_dp *intel_dp)
 {
+	struct drm_i915_private *i915 = dp_to_i915(intel_dp);
 	struct intel_connector *connector = intel_dp->attached_connector;
 	struct edid *edid;
+	bool vrr_capable;
 
 	intel_dp_unset_edid(intel_dp);
 	edid = intel_dp_get_edid(intel_dp);
 	connector->detect_edid = edid;
 
+	vrr_capable = intel_vrr_is_capable(&connector->base);
+	drm_dbg_kms(&i915->drm, "[CONNECTOR:%d:%s] VRR capable: %s\n",
+		    connector->base.base.id, connector->base.name, str_yes_no(vrr_capable));
+	drm_connector_set_vrr_capable_property(&connector->base, vrr_capable);
+
 	intel_dp_update_dfp(intel_dp, edid);
 	intel_dp_update_420(intel_dp);
 
@@ -4424,6 +4431,9 @@ intel_dp_unset_edid(struct intel_dp *intel_dp)
 
 	intel_dp->dfp.ycbcr_444_to_420 = false;
 	connector->base.ycbcr_420_allowed = false;
+
+	drm_connector_set_vrr_capable_property(&connector->base,
+					       false);
 }
 
 static int
@@ -4574,14 +4584,9 @@ static int intel_dp_get_modes(struct drm_connector *connector)
 	int num_modes = 0;
 
 	edid = intel_connector->detect_edid;
-	if (edid) {
+	if (edid)
 		num_modes = intel_connector_update_modes(connector, edid);
 
-		if (intel_vrr_is_capable(connector))
-			drm_connector_set_vrr_capable_property(connector,
-							       true);
-	}
-
 	/* Also add fixed mode, which may or may not be present in EDID */
 	if (intel_dp_is_edp(intel_attached_dp(intel_connector)) &&
 	    intel_connector->panel.fixed_mode) {
Signature · 1 line
2.19.1
#1 lore raw

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display/vrr: Reset VRR capable property on a long hpd (rev5)

== Series Details ==

== Series Details ==

Series: drm/i915/display/vrr: Reset VRR capable property on a long hpd (rev5)
URL : https://patchwork.freedesktop.org/series/98801/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
b7eb4985f027 drm/i915/display/vrr: Reset VRR capable property on a long hpd
-:10: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#10: 
With some VRR panels, user can turn VRR ON/OFF on the fly from the panel settings.

-:22: WARNING:TYPO_SPELLING: 'reseting' may be misspelled - perhaps 'resetting'? #22:
v5: Fixes the regression on older platforms by reseting the VRR

                                               ^^^^^^^^

total: 0 errors, 2 warnings, 0 checks, 44 lines checked

#2 lore raw

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display/vrr: Reset VRR capable property on a long hpd (rev5)

In reply to Manasi Navare
== Series Details ==

== Series Details ==

Series: drm/i915/display/vrr: Reset VRR capable property on a long hpd (rev5)
URL : https://patchwork.freedesktop.org/series/98801/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_11322 -> Patchwork_22484
====================================================

Summary
-------

**SUCCESS**

No regressions found.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/index.html

Participating hosts (45 -> 42)
------------------------------

Additional (1): fi-pnv-d510
Missing (4): fi-bsw-cyan bat-jsl-2 fi-icl-u2 fi-bdw-samus

Known issues
------------

Here are the changes found in Patchwork_22484 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@amdgpu/amd_basic@cs-gfx:
- fi-hsw-4770: NOTRUN -> [SKIP][1] ([fdo#109271] / [fdo#109315]) +17 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/fi-hsw-4770/igt@amdgpu/[email protected]

* igt@gem_exec_suspend@basic-s3@smem:
- fi-skl-6600u: [PASS][2] -> [INCOMPLETE][3] ([i915#4547])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/fi-skl-6600u/igt@gem_exec_suspend@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/fi-skl-6600u/igt@gem_exec_suspend@[email protected]

* igt@i915_selftest@live@execlists:
- fi-bsw-nick: [PASS][4] -> [INCOMPLETE][5] ([i915#2940])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/fi-bsw-nick/igt@i915_selftest@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/fi-bsw-nick/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@gt_engines:
- bat-dg1-5: [PASS][6] -> [INCOMPLETE][7] ([i915#4418])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/bat-dg1-5/igt@i915_selftest@live@gt_engines.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/bat-dg1-5/igt@i915_selftest@live@gt_engines.html

* igt@i915_selftest@live@hangcheck:
- fi-bdw-5557u: NOTRUN -> [INCOMPLETE][8] ([i915#3921])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/fi-bdw-5557u/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@requests:
- fi-blb-e6850: [PASS][9] -> [DMESG-FAIL][10] ([i915#5026])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/fi-blb-e6850/igt@i915_selftest@[email protected]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/fi-blb-e6850/igt@i915_selftest@[email protected]

* igt@kms_chamelium@dp-crc-fast:
- fi-bdw-5557u: NOTRUN -> [SKIP][11] ([fdo#109271] / [fdo#111827]) +8 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/fi-bdw-5557u/igt@[email protected]

* igt@kms_psr@cursor_plane_move:
- fi-bdw-5557u: NOTRUN -> [SKIP][12] ([fdo#109271]) +13 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/fi-bdw-5557u/igt@kms_psr@cursor_plane_move.html

* igt@prime_vgem@basic-userptr:
- fi-pnv-d510: NOTRUN -> [SKIP][13] ([fdo#109271]) +57 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/fi-pnv-d510/igt@[email protected]

* igt@runner@aborted:
- fi-skl-6600u: NOTRUN -> [FAIL][14] ([i915#4312])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/fi-skl-6600u/igt@[email protected]
- bat-dg1-5: NOTRUN -> [FAIL][15] ([i915#4312])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/bat-dg1-5/igt@[email protected]
- fi-bsw-nick: NOTRUN -> [FAIL][16] ([fdo#109271] / [i915#1436] / [i915#3428] / [i915#4312])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/fi-bsw-nick/igt@[email protected]
- fi-blb-e6850: NOTRUN -> [FAIL][17] ([fdo#109271] / [i915#2403] / [i915#2426] / [i915#4312])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/fi-blb-e6850/igt@[email protected]

#### Possible fixes ####

* igt@i915_selftest@live@hangcheck:
- fi-hsw-4770: [INCOMPLETE][18] ([i915#3303]) -> [PASS][19]
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/fi-hsw-4770/igt@i915_selftest@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/fi-hsw-4770/igt@i915_selftest@[email protected]
- bat-dg1-6: [DMESG-FAIL][20] ([i915#4494] / [i915#4957]) -> [PASS][21]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/bat-dg1-6/igt@i915_selftest@[email protected]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/bat-dg1-6/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@hugepages:
- {bat-rpls-2}: [DMESG-WARN][22] -> [PASS][23]
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/bat-rpls-2/igt@i915_selftest@[email protected]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/bat-rpls-2/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@perf:
- {fi-tgl-dsi}: [DMESG-WARN][24] ([i915#2867]) -> [PASS][25]
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/fi-tgl-dsi/igt@i915_selftest@[email protected]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/fi-tgl-dsi/igt@i915_selftest@[email protected]

* igt@i915_selftest@live@reset:
- {bat-rpls-2}: [DMESG-WARN][26] ([i915#4391]) -> [PASS][27] +1 similar issue
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/bat-rpls-2/igt@i915_selftest@[email protected]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/bat-rpls-2/igt@i915_selftest@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1436]: https://gitlab.freedesktop.org/drm/intel/issues/1436
[i915#2403]: https://gitlab.freedesktop.org/drm/intel/issues/2403
[i915#2426]: https://gitlab.freedesktop.org/drm/intel/issues/2426
[i915#2867]: https://gitlab.freedesktop.org/drm/intel/issues/2867
[i915#2940]: https://gitlab.freedesktop.org/drm/intel/issues/2940
[i915#3303]: https://gitlab.freedesktop.org/drm/intel/issues/3303
[i915#3428]: https://gitlab.freedesktop.org/drm/intel/issues/3428
[i915#3576]: https://gitlab.freedesktop.org/drm/intel/issues/3576
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4391]: https://gitlab.freedesktop.org/drm/intel/issues/4391
[i915#4418]: https://gitlab.freedesktop.org/drm/intel/issues/4418
[i915#4494]: https://gitlab.freedesktop.org/drm/intel/issues/4494
[i915#4547]: https://gitlab.freedesktop.org/drm/intel/issues/4547
[i915#4957]: https://gitlab.freedesktop.org/drm/intel/issues/4957
[i915#5026]: https://gitlab.freedesktop.org/drm/intel/issues/5026

Build changes
-------------

* Linux: CI_DRM_11322 -> Patchwork_22484

CI-20190529: 20190529
CI_DRM_11322: 7328c1d5b59036c9eee129e43b07b417e6c127e1 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6362: 698695136f8ade2391f2d8f45300eae2df02e947 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_22484: b7eb4985f0279b7e65ebcef490403caf08707f8d @ git://anongit.freedesktop.org/gfx-ci/linux

== Linux commits ==

b7eb4985f027 drm/i915/display/vrr: Reset VRR capable property on a long hpd

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/index.html

#3 lore raw

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/display/vrr: Reset VRR capable property on a long hpd (rev5)

In reply to Manasi Navare
== Series Details ==

== Series Details ==

Series: drm/i915/display/vrr: Reset VRR capable property on a long hpd (rev5)
URL : https://patchwork.freedesktop.org/series/98801/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_11322_full -> Patchwork_22484_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with Patchwork_22484_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes introduced in Patchwork_22484_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.

Participating hosts (13 -> 13)
------------------------------

No changes in participating hosts

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in Patchwork_22484_full:

### IGT changes ###

#### Possible regressions ####

* igt@gem_exec_suspend@basic-s3@smem:
- shard-snb: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-snb5/igt@gem_exec_suspend@[email protected]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-snb6/igt@gem_exec_suspend@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling:
- shard-tglb: [PASS][3] -> [INCOMPLETE][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-tglb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-tglb6/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-upscaling.html

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@gem_exec_schedule@deep@vcs0:
- {shard-rkl}: NOTRUN -> [INCOMPLETE][5]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-rkl-5/igt@gem_exec_schedule@[email protected]

* igt@prime_mmap_coherency@ioctl-errors:
- {shard-dg1}: NOTRUN -> [SKIP][6] +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-dg1-12/igt@[email protected]

Known issues
------------

Here are the changes found in Patchwork_22484_full that come from known issues:

### CI changes ###

#### Possible fixes ####

* boot:
- shard-apl: ([PASS][7], [FAIL][8], [PASS][9], [PASS][10], [PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [PASS][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31]) ([i915#4386]) -> ([PASS][32], [PASS][33], [PASS][34], [PASS][35], [PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53], [PASS][54], [PASS][55], [PASS][56])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl1/boot.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl1/boot.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl1/boot.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl1/boot.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl2/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl2/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl2/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl2/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl2/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl3/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl3/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl3/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl4/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl4/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl4/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl6/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl6/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl6/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl6/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl7/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl7/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl7/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl8/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl8/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl8/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl1/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl8/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl8/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl7/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl7/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl7/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl7/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl6/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl6/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl6/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl6/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl4/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl4/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl4/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl3/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl3/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl3/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl2/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl2/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl2/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl2/boot.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl1/boot.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl1/boot.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl1/boot.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl8/boot.html

### IGT changes ###

#### Issues hit ####

* igt@gem_create@create-massive:
- shard-apl: NOTRUN -> [DMESG-WARN][57] ([i915#4991])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl1/igt@[email protected]

* igt@gem_exec_balancer@parallel:
- shard-iclb: NOTRUN -> [SKIP][58] ([i915#4525])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-iclb5/igt@[email protected]
- shard-tglb: NOTRUN -> [DMESG-WARN][59] ([i915#5076])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-tglb7/igt@[email protected]

* igt@gem_exec_fair@basic-none@vcs0:
- shard-kbl: [PASS][60] -> [FAIL][61] ([i915#2842]) +2 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-kbl4/igt@gem_exec_fair@[email protected]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-kbl1/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][62] -> [FAIL][63] ([i915#2842])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-tglb7/igt@gem_exec_fair@[email protected]
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-tglb8/igt@gem_exec_fair@[email protected]

* igt@gem_render_copy@linear-to-vebox-y-tiled:
- shard-apl: NOTRUN -> [SKIP][64] ([fdo#109271]) +77 similar issues
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl6/igt@[email protected]

* igt@i915_pm_dc@dc6-dpms:
- shard-iclb: [PASS][65] -> [FAIL][66] ([i915#454])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-iclb6/igt@[email protected]
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-iclb3/igt@[email protected]

* igt@kms_big_fb@linear-64bpp-rotate-270:
- shard-iclb: NOTRUN -> [SKIP][67] ([fdo#110725] / [fdo#111614])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-iclb5/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][68] ([fdo#111614])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-tglb7/igt@[email protected]

* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
- shard-apl: NOTRUN -> [SKIP][69] ([fdo#109271] / [i915#3777])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl1/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html

* igt@kms_big_fb@y-tiled-16bpp-rotate-0:
- shard-glk: [PASS][70] -> [DMESG-WARN][71] ([i915#118]) +2 similar issues
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-glk4/igt@[email protected]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-glk4/igt@[email protected]

* igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][72] ([fdo#109271] / [i915#3886]) +7 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl1/igt@kms_ccs@pipe-b-crc-sprite-planes-basic-y_tiled_gen12_rc_ccs_cc.html

* igt@kms_ccs@pipe-d-bad-aux-stride-y_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][73] ([i915#3689]) +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-tglb1/igt@kms_ccs@pipe-d-bad-aux-stride-y_tiled_ccs.html

* igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_ccs:
- shard-iclb: NOTRUN -> [SKIP][74] ([fdo#109278]) +1 similar issue
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-iclb5/igt@kms_ccs@pipe-d-crc-primary-basic-y_tiled_ccs.html

* igt@kms_chamelium@dp-crc-fast:
- shard-iclb: NOTRUN -> [SKIP][75] ([fdo#109284] / [fdo#111827])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-iclb5/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][76] ([fdo#109284] / [fdo#111827])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-tglb7/igt@[email protected]

* igt@kms_chamelium@vga-hpd-enable-disable-mode:
- shard-apl: NOTRUN -> [SKIP][77] ([fdo#109271] / [fdo#111827]) +6 similar issues
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl1/igt@[email protected]

* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
- shard-glk: [PASS][78] -> [FAIL][79] ([i915#72])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-glk1/igt@[email protected]
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-glk3/igt@[email protected]

* igt@kms_fbcon_fbt@fbc-suspend:
- shard-apl: [PASS][80] -> [INCOMPLETE][81] ([i915#180])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl2/igt@[email protected]
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl7/igt@[email protected]

* igt@kms_flip@flip-vs-suspend@a-dp1:
- shard-apl: [PASS][82] -> [DMESG-WARN][83] ([i915#180]) +4 similar issues
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl2/igt@kms_flip@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl6/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling:
- shard-iclb: [PASS][84] -> [SKIP][85] ([i915#3701])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-iclb5/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling.html
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling.html

* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling:
- shard-glk: [PASS][86] -> [FAIL][87] ([i915#4911])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-glk9/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling.html
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-glk8/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-upscaling.html

* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move:
- shard-glk: [PASS][88] -> [FAIL][89] ([i915#2546])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-glk4/igt@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-glk4/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-cpu:
- shard-iclb: NOTRUN -> [SKIP][90] ([fdo#109280])
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-cpu.html

* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-move:
- shard-tglb: NOTRUN -> [SKIP][91] ([fdo#109280] / [fdo#111825]) +1 similar issue
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-tglb1/igt@[email protected]

* igt@kms_pipe_b_c_ivb@from-pipe-c-to-b-with-3-lanes:
- shard-tglb: NOTRUN -> [SKIP][92] ([fdo#109289])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-tglb5/igt@[email protected]

* igt@kms_pipe_crc_basic@read-crc-pipe-d-frame-sequence:
- shard-apl: NOTRUN -> [SKIP][93] ([fdo#109271] / [i915#533])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl6/igt@[email protected]

* igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-b-edp-1-scaler-with-clipping-clamping:
- shard-iclb: [PASS][94] -> [SKIP][95] ([i915#5176]) +1 similar issue
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-iclb6/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-b-edp-1-scaler-with-clipping-clamping.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-iclb3/igt@kms_plane_scaling@scaler-with-clipping-clamping@pipe-b-edp-1-scaler-with-clipping-clamping.html

* igt@kms_psr2_su@page_flip-p010:
- shard-apl: NOTRUN -> [SKIP][96] ([fdo#109271] / [i915#658])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl6/igt@kms_psr2_su@page_flip-p010.html

* igt@kms_setmode@basic:
- shard-glk: [PASS][97] -> [FAIL][98] ([i915#31])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-glk6/igt@[email protected]
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-glk4/igt@[email protected]

* igt@nouveau_crc@pipe-c-source-outp-complete:
- shard-tglb: NOTRUN -> [SKIP][99] ([i915#2530])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-tglb5/igt@[email protected]

* igt@sysfs_clients@sema-50:
- shard-apl: NOTRUN -> [SKIP][100] ([fdo#109271] / [i915#2994]) +1 similar issue
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl7/igt@[email protected]

#### Possible fixes ####

* igt@gem_ctx_isolation@preservation-s3@bcs0:
- shard-apl: [DMESG-WARN][101] ([i915#180]) -> [PASS][102] +1 similar issue
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl8/igt@gem_ctx_isolation@[email protected]
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl7/igt@gem_ctx_isolation@[email protected]

* igt@gem_eio@unwedge-stress:
- shard-iclb: [TIMEOUT][103] ([i915#2481] / [i915#3070]) -> [PASS][104]
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-iclb4/igt@[email protected]
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-iclb8/igt@[email protected]
- {shard-rkl}: [TIMEOUT][105] ([i915#3063]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-rkl-1/igt@[email protected]
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-rkl-5/igt@[email protected]

* igt@gem_exec_fair@basic-pace-share@rcs0:
- {shard-tglu}: [FAIL][107] ([i915#2842]) -> [PASS][108]
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-tglu-1/igt@gem_exec_fair@[email protected]
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-tglu-5/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [FAIL][109] ([i915#2842]) -> [PASS][110]
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl7/igt@gem_exec_fair@[email protected]
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl4/igt@gem_exec_fair@[email protected]

* igt@gem_exec_fair@basic-pace@vecs0:
- shard-kbl: [FAIL][111] ([i915#2842]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-kbl4/igt@gem_exec_fair@[email protected]
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-kbl4/igt@gem_exec_fair@[email protected]
- shard-tglb: [FAIL][113] ([i915#2842]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-tglb2/igt@gem_exec_fair@[email protected]
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-tglb6/igt@gem_exec_fair@[email protected]

* igt@gem_exec_whisper@basic-normal:
- shard-glk: [DMESG-WARN][115] ([i915#118]) -> [PASS][116]
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-glk4/igt@[email protected]
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-glk5/igt@[email protected]

* igt@gem_lmem_swapping@smem-oom@lmem0:
- {shard-dg1}: [DMESG-WARN][117] ([i915#4936]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-dg1-15/igt@gem_lmem_swapping@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-dg1-19/igt@gem_lmem_swapping@[email protected]

* igt@gem_workarounds@suspend-resume-fd:
- shard-snb: [TIMEOUT][119] -> [PASS][120]
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-snb6/igt@[email protected]
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-snb7/igt@[email protected]

* igt@i915_pm_dc@dc6-psr:
- shard-iclb: [FAIL][121] ([i915#454]) -> [PASS][122]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-iclb4/igt@[email protected]
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-iclb5/igt@[email protected]

* igt@kms_3d:
- {shard-dg1}: [SKIP][123] -> [PASS][124] +18 similar issues
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-dg1-18/igt@kms_3d.html
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-dg1-13/igt@kms_3d.html

* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-0:
- {shard-dg1}: [FAIL][125] -> [PASS][126] +2 similar issues
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-dg1-18/igt@[email protected]
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-dg1-13/igt@[email protected]

* igt@kms_flip@2x-plain-flip-fb-recreate@bc-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][127] ([i915#2122]) -> [PASS][128]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-glk6/igt@kms_flip@[email protected]
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-glk3/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend-interruptible@b-vga1:
- shard-snb: [DMESG-WARN][129] -> [PASS][130]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-snb4/igt@kms_flip@[email protected]
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-snb4/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-suspend@d-edp1:
- shard-tglb: [DMESG-WARN][131] ([i915#2411] / [i915#2867]) -> [PASS][132]
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-tglb2/igt@kms_flip@[email protected]
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-tglb1/igt@kms_flip@[email protected]

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling:
- shard-iclb: [SKIP][133] ([i915#3701]) -> [PASS][134]
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-iclb2/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling.html
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-iclb8/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytile-downscaling.html

* {igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-5@pipe-c-edp-1-downscale-with-pixel-format}:
- shard-iclb: [SKIP][135] ([i915#5176]) -> [PASS][136] +2 similar issues
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-iclb2/igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-5@pipe-c-edp-1-downscale-with-pixel-format.html
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-iclb6/igt@kms_plane_scaling@downscale-with-pixel-format-factor-0-5@pipe-c-edp-1-downscale-with-pixel-format.html

* {igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a-edp-1-planes-upscale-downscale}:
- shard-iclb: [SKIP][137] -> [PASS][138] +2 similar issues
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-iclb2/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a-edp-1-planes-upscale-downscale.html
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-iclb6/igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-5@pipe-a-edp-1-planes-upscale-downscale.html

* igt@kms_psr@psr2_sprite_render:
- shard-iclb: [SKIP][139] ([fdo#109441]) -> [PASS][140] +1 similar issue
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-iclb8/igt@kms_psr@psr2_sprite_render.html
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-iclb2/igt@kms_psr@psr2_sprite_render.html

* igt@perf@polling-parameterized:
- {shard-rkl}: [FAIL][141] ([i915#1542]) -> [PASS][142]
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-rkl-1/igt@[email protected]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-rkl-2/igt@[email protected]

#### Warnings ####

* igt@gem_eio@unwedge-stress:
- shard-tglb: [TIMEOUT][143] ([i915#3063] / [i915#3648]) -> [FAIL][144] ([i915#232])
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-tglb7/igt@[email protected]
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-tglb2/igt@[email protected]

* igt@gem_exec_balancer@parallel-contexts:
- shard-tglb: [DMESG-WARN][145] ([i915#5076]) -> [INCOMPLETE][146] ([i915#5076])
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-tglb3/igt@[email protected]
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-tglb6/igt@[email protected]

* igt@gem_exec_balancer@parallel-out-fence:
- shard-iclb: [SKIP][147] ([i915#4525]) -> [DMESG-WARN][148] ([i915#5076]) +3 similar issues
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-iclb3/igt@[email protected]
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-iclb4/igt@[email protected]

* igt@kms_psr2_sf@overlay-plane-update-sf-dmg-area:
- shard-iclb: [SKIP][149] ([fdo#111068] / [i915#658]) -> [SKIP][150] ([i915#2920])
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-iclb5/igt@[email protected]
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-iclb2/igt@[email protected]

* igt@kms_psr2_su@page_flip-nv12:
- shard-iclb: [FAIL][151] ([i915#4148]) -> [SKIP][152] ([fdo#109642] / [fdo#111068] / [i915#658])
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-iclb2/igt@kms_psr2_su@page_flip-nv12.html
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-iclb8/igt@kms_psr2_su@page_flip-nv12.html

* igt@runner@aborted:
- shard-apl: ([FAIL][153], [FAIL][154], [FAIL][155], [FAIL][156], [FAIL][157], [FAIL][158], [FAIL][159]) ([i915#180] / [i915#1814] / [i915#3002] / [i915#4312]) -> ([FAIL][160], [FAIL][161], [FAIL][162], [FAIL][163], [FAIL][164], [FAIL][165], [FAIL][166], [FAIL][167], [FAIL][168], [FAIL][169]) ([fdo#109271] / [i915#180] / [i915#1814] / [i915#3002] / [i915#4312])
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl7/igt@[email protected]
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl2/igt@[email protected]
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl8/igt@[email protected]
[156]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl2/igt@[email protected]
[157]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl6/igt@[email protected]
[158]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl8/igt@[email protected]
[159]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11322/shard-apl6/igt@[email protected]
[160]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl1/igt@[email protected]
[161]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl2/igt@[email protected]
[162]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl2/igt@[email protected]
[163]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl1/igt@[email protected]
[164]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl7/igt@[email protected]
[165]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl6/igt@[email protected]
[166]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl2/igt@[email protected]
[167]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl1/igt@[email protected]
[168]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl7/igt@[email protected]
[169]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/shard-apl4/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109291]: https://bugs.freedesktop.org/show_bug.cgi?id=109291
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109308]: https://bugs.freedesktop.org/show_bug.cgi?id=109308
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#110725]: https://bugs.freedesktop.org/show_bug.cgi?id=110725
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111314]: https://bugs.freedesktop.org/show_bug.cgi?id=111314
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22484/index.html

#4 lore raw
In reply to Manasi Navare

Hi Ville,

Here the VRR set/reset moved to set/unset edid like you suggested. Anything else needed here?

Manasi

Quoted 80 lines · Manasi Navare

With some VRR panels, user can turn VRR ON/OFF on the fly from the panel settings. When VRR is turned OFF ,sends a long HPD to the driver clearing the Ignore MSA bit in the DPCD. Currently the driver parses that onevery HPD but fails to reset the corresponding VRR Capable Connector property.
Hence the userspace still sees this as VRR Capable panel which is incorrect.

Fix this by explicitly resetting the connector property.

v2: Reset vrr capable if status == connector_disconnected
v3: Use i915 and use bool vrr_capable (Jani Nikula)
v4: Move vrr_capable to after update modes call (Jani N) Remove the redundant comment (Jan N)
v5: Fixes the regression on older platforms by reseting the VRR only if HAS_VRR
v6: Remove the checks from driver, add in drm core before setting VRR prop (Ville)
v7: Move VRR set/reset to set/unset_edid (Ville)

Cc Jani Nikula <[email protected]>
Cc Ville Syrjälä <[email protected]>
Fixes 390a1f8beb87 ("Revert "drm/i915/display/vrr: Reset VRR capable property on a long hpd")
---
 drivers/gpu/drm/i915/display/intel_dp.c | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/display/intel_dp.c +11 -6
index d6ef33096bb6..1d0f8fc39005 100644
@@ -4385,13 +4385,20 @@ intel_dp_update_420(struct intel_dp *intel_dp)
 static void
 intel_dp_set_edid(struct intel_dp *intel_dp)
 {
+	struct drm_i915_private *i915 = dp_to_i915(intel_dp);
 	struct intel_connector *connector = intel_dp->attached_connector;
 	struct edid *edid;
+	bool vrr_capable;
 
 	intel_dp_unset_edid(intel_dp);
 	edid = intel_dp_get_edid(intel_dp);
 	connector->detect_edid = edid;
 
+	vrr_capable = intel_vrr_is_capable(&connector->base);
+	drm_dbg_kms(&i915->drm, "[CONNECTOR:%d:%s] VRR capable: %s\n",
+		    connector->base.base.id, connector->base.name, str_yes_no(vrr_capable));
+	drm_connector_set_vrr_capable_property(&connector->base, vrr_capable);
+
 	intel_dp_update_dfp(intel_dp, edid);
 	intel_dp_update_420(intel_dp);
 
@@ -4424,6 +4431,9 @@ intel_dp_unset_edid(struct intel_dp *intel_dp)
 
 	intel_dp->dfp.ycbcr_444_to_420 = false;
 	connector->base.ycbcr_420_allowed = false;
+
+	drm_connector_set_vrr_capable_property(&connector->base,
+					       false);
 }
 
 static int
@@ -4574,14 +4584,9 @@ static int intel_dp_get_modes(struct drm_connector *connector)
 	int num_modes = 0;
 
 	edid = intel_connector->detect_edid;
-	if (edid) {
+	if (edid)
 		num_modes = intel_connector_update_modes(connector, edid);
 
-		if (intel_vrr_is_capable(connector))
-			drm_connector_set_vrr_capable_property(connector,
-							       true);
-	}
-
 	/* Also add fixed mode, which may or may not be present in EDID */
 	if (intel_dp_is_edp(intel_attached_dp(intel_connector)) &&
 	    intel_connector->panel.fixed_mode) {
Signature · 1 line
2.19.1
Reviewed-by on v7 1/1
#5 lore raw
In reply to Manasi Navare
Quoted 18 lines · Manasi Navare

With some VRR panels, user can turn VRR ON/OFF on the fly from the panel settings. When VRR is turned OFF ,sends a long HPD to the driver clearing the Ignore MSA bit in the DPCD. Currently the driver parses that onevery HPD but fails to reset the corresponding VRR Capable Connector property.
Hence the userspace still sees this as VRR Capable panel which is incorrect.

Fix this by explicitly resetting the connector property.

v2: Reset vrr capable if status == connector_disconnected
v3: Use i915 and use bool vrr_capable (Jani Nikula)
v4: Move vrr_capable to after update modes call (Jani N) Remove the redundant comment (Jan N)
v5: Fixes the regression on older platforms by reseting the VRR only if HAS_VRR
v6: Remove the checks from driver, add in drm core before setting VRR prop (Ville)
v7: Move VRR set/reset to set/unset_edid (Ville)

Quoted 4 lines
Cc Jani Nikula <[email protected]>
Cc Ville Syrjälä <[email protected]>
Fixes 390a1f8beb87 ("Revert "drm/i915/display/vrr: Reset VRR capable property on a long hpd")

Looks reasoanble enough to me.

But be careful when pushing this since I don't think the drm_connector_set_vrr_capable_property() change has percolated into drm-intel-next yet.

Quoted 57 lines
---
 drivers/gpu/drm/i915/display/intel_dp.c | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/display/intel_dp.c +11 -6
index d6ef33096bb6..1d0f8fc39005 100644
@@ -4385,13 +4385,20 @@ intel_dp_update_420(struct intel_dp *intel_dp)
 static void
 intel_dp_set_edid(struct intel_dp *intel_dp)
 {
+	struct drm_i915_private *i915 = dp_to_i915(intel_dp);
 	struct intel_connector *connector = intel_dp->attached_connector;
 	struct edid *edid;
+	bool vrr_capable;
 
 	intel_dp_unset_edid(intel_dp);
 	edid = intel_dp_get_edid(intel_dp);
 	connector->detect_edid = edid;
 
+	vrr_capable = intel_vrr_is_capable(&connector->base);
+	drm_dbg_kms(&i915->drm, "[CONNECTOR:%d:%s] VRR capable: %s\n",
+		    connector->base.base.id, connector->base.name, str_yes_no(vrr_capable));
+	drm_connector_set_vrr_capable_property(&connector->base, vrr_capable);
+
 	intel_dp_update_dfp(intel_dp, edid);
 	intel_dp_update_420(intel_dp);
 
@@ -4424,6 +4431,9 @@ intel_dp_unset_edid(struct intel_dp *intel_dp)
 
 	intel_dp->dfp.ycbcr_444_to_420 = false;
 	connector->base.ycbcr_420_allowed = false;
+
+	drm_connector_set_vrr_capable_property(&connector->base,
+					       false);
 }
 
 static int
@@ -4574,14 +4584,9 @@ static int intel_dp_get_modes(struct drm_connector *connector)
 	int num_modes = 0;
 
 	edid = intel_connector->detect_edid;
-	if (edid) {
+	if (edid)
 		num_modes = intel_connector_update_modes(connector, edid);
 
-		if (intel_vrr_is_capable(connector))
-			drm_connector_set_vrr_capable_property(connector,
-							       true);
-	}
-
 	/* Also add fixed mode, which may or may not be present in EDID */
 	if (intel_dp_is_edp(intel_attached_dp(intel_connector)) &&
 	    intel_connector->panel.fixed_mode) {
Signature · 1 line
2.19.1
Signature · 2 lines
Ville Syrjälä
Intel
#6 lore raw
Quoted 24 lines · Ville Syrjälä
Quoted 18 lines · Manasi Navare

With some VRR panels, user can turn VRR ON/OFF on the fly from the panel settings. When VRR is turned OFF ,sends a long HPD to the driver clearing the Ignore MSA bit in the DPCD. Currently the driver parses that onevery HPD but fails to reset the corresponding VRR Capable Connector property.
Hence the userspace still sees this as VRR Capable panel which is incorrect.

Fix this by explicitly resetting the connector property.

v2: Reset vrr capable if status == connector_disconnected
v3: Use i915 and use bool vrr_capable (Jani Nikula)
v4: Move vrr_capable to after update modes call (Jani N) Remove the redundant comment (Jan N)
v5: Fixes the regression on older platforms by reseting the VRR only if HAS_VRR
v6: Remove the checks from driver, add in drm core before setting VRR prop (Ville)
v7: Move VRR set/reset to set/unset_edid (Ville)

Quoted 4 lines
Cc Jani Nikula <[email protected]>
Cc Ville Syrjälä <[email protected]>
Fixes 390a1f8beb87 ("Revert "drm/i915/display/vrr: Reset VRR capable property on a long hpd")
Quoted 6 lines

Looks reasoanble enough to me.

But be careful when pushing this since I don't think the drm_connector_set_vrr_capable_property() change has percolated into drm-intel-next yet.

Okay I can wait then to push until that gets percolated from drm-misc

Manasi

Quoted 62 lines
Quoted 58 lines
---
 drivers/gpu/drm/i915/display/intel_dp.c | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/display/intel_dp.c +11 -6
index d6ef33096bb6..1d0f8fc39005 100644
@@ -4385,13 +4385,20 @@ intel_dp_update_420(struct intel_dp *intel_dp)
 static void
 intel_dp_set_edid(struct intel_dp *intel_dp)
 {
+	struct drm_i915_private *i915 = dp_to_i915(intel_dp);
 	struct intel_connector *connector = intel_dp->attached_connector;
 	struct edid *edid;
+	bool vrr_capable;
 
 	intel_dp_unset_edid(intel_dp);
 	edid = intel_dp_get_edid(intel_dp);
 	connector->detect_edid = edid;
 
+	vrr_capable = intel_vrr_is_capable(&connector->base);
+	drm_dbg_kms(&i915->drm, "[CONNECTOR:%d:%s] VRR capable: %s\n",
+		    connector->base.base.id, connector->base.name, str_yes_no(vrr_capable));
+	drm_connector_set_vrr_capable_property(&connector->base, vrr_capable);
+
 	intel_dp_update_dfp(intel_dp, edid);
 	intel_dp_update_420(intel_dp);
 
@@ -4424,6 +4431,9 @@ intel_dp_unset_edid(struct intel_dp *intel_dp)
 
 	intel_dp->dfp.ycbcr_444_to_420 = false;
 	connector->base.ycbcr_420_allowed = false;
+
+	drm_connector_set_vrr_capable_property(&connector->base,
+					       false);
 }
 
 static int
@@ -4574,14 +4584,9 @@ static int intel_dp_get_modes(struct drm_connector *connector)
 	int num_modes = 0;
 
 	edid = intel_connector->detect_edid;
-	if (edid) {
+	if (edid)
 		num_modes = intel_connector_update_modes(connector, edid);
 
-		if (intel_vrr_is_capable(connector))
-			drm_connector_set_vrr_capable_property(connector,
-							       true);
-	}
-
 	/* Also add fixed mode, which may or may not be present in EDID */
 	if (intel_dp_is_edp(intel_attached_dp(intel_connector)) &&
 	    intel_connector->panel.fixed_mode) {
Signature · 1 line
2.19.1
Signature · 2 lines
Ville Syrjälä
Intel