Skip to contentSkip to conversation

pinctrl: mediatek: Fix missing of_node_put() in mtk_pctrl_init

PATCH In review Miaoqian Lin 3 participants 3 messages Mar 8, 2022 – Mar 15, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: mediatek: Fix missing of_node_put() in mtk_pctrl_init

The device_node pointer is returned by of_parse_phandle() with refcount incremented. We should use of_node_put() on it when done.

Fixes a6df410d420a ("pinctrl: mediatek: Add Pinctrl/GPIO driver for mt8135.")
---
 drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 2 ++
 1 file changed, 2 insertions(+)
drivers/pinctrl/mediatek/pinctrl-mtk-common.c +2 -0
index 5f7c421ab6e7..334cb85855a9 100644
@@ -1038,6 +1038,7 @@ int mtk_pctrl_init(struct platform_device *pdev,
 	node = of_parse_phandle(np, "mediatek,pctl-regmap", 0);
 	if (node) {
 		pctl->regmap1 = syscon_node_to_regmap(node);
+		of_node_put(node);
 		if (IS_ERR(pctl->regmap1))
 			return PTR_ERR(pctl->regmap1);
 	} else if (regmap) {
@@ -1051,6 +1052,7 @@ int mtk_pctrl_init(struct platform_device *pdev,
 	node = of_parse_phandle(np, "mediatek,pctl-regmap", 1);
 	if (node) {
 		pctl->regmap2 = syscon_node_to_regmap(node);
+		of_node_put(node);
 		if (IS_ERR(pctl->regmap2))
 			return PTR_ERR(pctl->regmap2);
 	}
Signature · 1 line
2.17.1
maintainer Reviewed-by on v1 1/1
#1 lore raw

Il 08/03/22 08:11, Miaoqian Lin ha scritto:

Quoted 5 lines

The device_node pointer is returned by of_parse_phandle() with refcount incremented. We should use of_node_put() on it when done.

Fixes a6df410d420a ("pinctrl: mediatek: Add Pinctrl/GPIO driver for mt8135.")

Thanks!

Quoted 25 lines
---
  drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 2 ++
  1 file changed, 2 insertions(+)
drivers/pinctrl/mediatek/pinctrl-mtk-common.c +2 -0
index 5f7c421ab6e7..334cb85855a9 100644
@@ -1038,6 +1038,7 @@ int mtk_pctrl_init(struct platform_device *pdev,
  	node = of_parse_phandle(np, "mediatek,pctl-regmap", 0);
  	if (node) {
  		pctl->regmap1 = syscon_node_to_regmap(node);
+		of_node_put(node);
  		if (IS_ERR(pctl->regmap1))
  			return PTR_ERR(pctl->regmap1);
  	} else if (regmap) {
@@ -1051,6 +1052,7 @@ int mtk_pctrl_init(struct platform_device *pdev,
  	node = of_parse_phandle(np, "mediatek,pctl-regmap", 1);
  	if (node) {
  		pctl->regmap2 = syscon_node_to_regmap(node);
+		of_node_put(node);
  		if (IS_ERR(pctl->regmap2))
  			return PTR_ERR(pctl->regmap2);
  	}