Skip to contentSkip to conversation

mmc: mtk-msdc: change a log level

PATCH In review Alexandre Bailon 2 participants 2 messages Mar 8, 2022 – Mar 9, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mmc: mtk-msdc: change a log level

We write data to RPMB, we get many time the following log:
mtk-msdc 11230000.mmc: phase: [map:ffffffff] [maxlen:32] [final:10]

dev_info is used to print that log but it seems that log is only useful for debbuging. Use dev_dbg instead of dev_info.

---
 drivers/mmc/host/mtk-sd.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/mmc/host/mtk-sd.c +2 -2
index d5a9c269d492..05c8b4de46f3 100644
@@ -1914,8 +1914,8 @@ static struct msdc_delay_phase get_best_delay(struct msdc_host *host, u32 delay)
 		final_phase = (start_final + len_final / 3) % PAD_DELAY_MAX;
 	else
 		final_phase = (start_final + len_final / 2) % PAD_DELAY_MAX;
-	dev_info(host->dev, "phase: [map:%x] [maxlen:%d] [final:%d]\n",
-		 delay, len_final, final_phase);
+	dev_dbg(host->dev, "phase: [map:%x] [maxlen:%d] [final:%d]\n",
+		delay, len_final, final_phase);
 
 	delay_phase.maxlen = len_final;
 	delay_phase.start = start_final;
Signature · 1 line
2.34.1
maintainer Reviewed-by on v1 1/1
#1 lore raw

Il 08/03/22 10:49, Alexandre Bailon ha scritto:

Quoted 7 lines

We write data to RPMB, we get many time the following log:
mtk-msdc 11230000.mmc: phase: [map:ffffffff] [maxlen:32] [final:10]

dev_info is used to print that log but it seems that log is only useful for debbuging. Use dev_dbg instead of dev_info.

Hello Alexandre,

I definitely agree with this change, but the commit title is not clear enough; can you please change it to something like

mmc: mtk-sd: Silence delay phase calculation debug log

After the change,

Quoted 20 lines
---
  drivers/mmc/host/mtk-sd.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/mmc/host/mtk-sd.c +2 -2
index d5a9c269d492..05c8b4de46f3 100644
@@ -1914,8 +1914,8 @@ static struct msdc_delay_phase get_best_delay(struct msdc_host *host, u32 delay)
  		final_phase = (start_final + len_final / 3) % PAD_DELAY_MAX;
  	else
  		final_phase = (start_final + len_final / 2) % PAD_DELAY_MAX;
-	dev_info(host->dev, "phase: [map:%x] [maxlen:%d] [final:%d]\n",
-		 delay, len_final, final_phase);
+	dev_dbg(host->dev, "phase: [map:%x] [maxlen:%d] [final:%d]\n",
+		delay, len_final, final_phase);
 
  	delay_phase.maxlen = len_final;
  	delay_phase.start = start_final;