Skip to contentSkip to conversation

video: fbdev: kyro: make read-only array ODValues static const

PATCH Applied Colin Ian King 2 participants 2 messages Mar 8, 2022 – Mar 11, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 video: fbdev: kyro: make read-only array ODValues static const

Don't populate the read-only array ODValues on the stack but instead make it static const. Also makes the object code a little smaller.

---
 drivers/video/fbdev/kyro/STG4000InitDevice.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/fbdev/kyro/STG4000InitDevice.c +1 -1
index 21875d3c2dc2..ffeb355c8b50 100644
@@ -124,7 +124,7 @@ u32 ProgramClock(u32 refClock,
 	u32 ulScore, ulPhaseScore, ulVcoScore;
 	u32 ulTmp = 0, ulVCO;
 	u32 ulScaleClockReq, ulMinClock, ulMaxClock;
-	u32 ODValues[] = { 1, 2, 0 };
+	static const u32 ODValues[] = { 1, 2, 0 };
 
 	/* Translate clock in Hz */
 	coreClock *= 100;	/* in Hz */
Signature · 1 line
2.35.1
maintainer Applied
#1 lore raw
Quoted 15 lines · Colin Ian King

Don't populate the read-only array ODValues on the stack but instead make it static const. Also makes the object code a little smaller.

---
 drivers/video/fbdev/kyro/STG4000InitDevice.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/video/fbdev/kyro/STG4000InitDevice.c +0 -0
index 21875d3c2dc2..ffeb355c8b50 100644

drivers/video/fbdev/kyro/STG4000InitDevice.c u32 ProgramClock(u32 refClock, · line 127

Quoted 5 lines
drivers/video/fbdev/kyro/STG4000InitDevice.c +1 -1
@@ -124,7 +124,7 @@ u32 ProgramClock(u32 refClock,
 	u32 ulScore, ulPhaseScore, ulVcoScore;
 	u32 ulTmp = 0, ulVCO;
 	u32 ulScaleClockReq, ulMinClock, ulMaxClock;
-	u32 ODValues[] = { 1, 2, 0 };
+	static const u32 ODValues[] = { 1, 2, 0 };

applied, but I made this:
static const unsigned char

Thanks!
Helge

Quoted 3 lines
drivers/video/fbdev/kyro/STG4000InitDevice.c +0 -0
 	/* Translate clock in Hz */
 	coreClock *= 100;	/* in Hz */