vfio/mlx5: Fix to not use 0 as NULL pointer
Subsystems (4)
Yishai Hadas
maintainerPATCH 1/1 vfio/mlx5: Fix to not use 0 as NULL pointer
Fix sparse warning to not use plain integer (i.e. 0) as NULL pointer.
Reported-by kernel test robot <[email protected]>
Fixes 6fadb021266d ("vfio/mlx5: Implement vfio_pci driver for mlx5 devices")
Signed-off-by Yishai Hadas <[email protected]>
--- drivers/vfio/pci/mlx5/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/vfio/pci/mlx5/main.c +2 -2
@@ -409,7 +409,7 @@ mlx5vf_pci_step_device_state_locked(struct mlx5vf_pci_core_device *mvdev,if ((cur ==VFIO_DEVICE_STATE_STOP_COPY && new ==VFIO_DEVICE_STATE_STOP )) {mlx5vf_disable_fds (mvdev); -return 0 ; +return NULL ; }if (cur ==VFIO_DEVICE_STATE_STOP && new ==VFIO_DEVICE_STATE_RESUMING ) {
@@ -430,7 +430,7 @@ mlx5vf_pci_step_device_state_locked(struct mlx5vf_pci_core_device *mvdev,if (ret)return ERR_PTR (ret);mlx5vf_disable_fds (mvdev); -return 0 ; +return NULL ; }/*
Signature · 1 line
2.18.1
Alex Williamson
AppliedQuoted 23 lines · On Wed, 9 Mar 2022 10:02:17 +0200 Yishai Hadas <[email protected]> wrote:
Fix sparse warning to not use plain integer (i.e. 0) as NULL pointer.
Reported-by kernel test robot <[email protected]>Fixes 6fadb021266d ("vfio/mlx5: Implement vfio_pci driver for mlx5 devices")Signed-off-by Yishai Hadas <[email protected]>--- drivers/vfio/pci/mlx5/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)drivers/vfio/pci/mlx5/main.c +1
-1@@ -409,7 +409,7 @@ mlx5vf_pci_step_device_state_locked(struct mlx5vf_pci_core_device *mvdev,if ((cur ==VFIO_DEVICE_STATE_STOP_COPY && new ==VFIO_DEVICE_STATE_STOP )) {mlx5vf_disable_fds (mvdev); -return 0 ; +return NULL ; }if (cur ==VFIO_DEVICE_STATE_STOP && new ==VFIO_DEVICE_STATE_RESUMING ) {
drivers/vfio/pci/mlx5/main.c mlx5vf_pci_step_device_state_locked(struct mlx5vf_pci_core_device *mvdev, · line 436
Quoted 8 lines
drivers/vfio/pci/mlx5/main.c +1
-1@@ -430,7 +430,7 @@ mlx5vf_pci_step_device_state_locked(struct mlx5vf_pci_core_device *mvdev,if (ret)return ERR_PTR (ret);mlx5vf_disable_fds (mvdev); -return 0 ; +return NULL ; }/*
Applied to vfio next branch for v5.18. Thanks,
Alex