Skip to contentSkip to conversation

Constify comedi_lrange struct pointer

PATCH In review Hatim Muhammed 2 participants 2 messages Mar 9, 2022 Comedi drivers

lore
Share & tools
lore
#0 lore raw

PATCH 8/8 Constify comedi_lrange struct pointer

From: Hatim Muhammed <[email protected]>

---
 drivers/comedi/drivers/das16.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/comedi/drivers/das16.c +2 -2
index 937a69ce0977..d1eeb5896f2d 100644
@@ -956,7 +956,7 @@ static const struct comedi_lrange *das16_ai_range(struct comedi_device *dev,
 
 	/* get any user-defined input range */
 	if (pg_type == das16_pg_none && (min || max)) {
-		struct comedi_lrange *lrange;
+		const struct comedi_lrange *lrange;
 		struct comedi_krange *krange;
 
 		/* allocate single-range range table */
@@ -990,7 +990,7 @@ static const struct comedi_lrange *das16_ao_range(struct comedi_device *dev,
 
 	/* get any user-defined output range */
 	if (min || max) {
-		struct comedi_lrange *lrange;
+		const struct comedi_lrange *lrange;
 		struct comedi_krange *krange;
 
 		/* allocate single-range range table */
Signature · 1 line
2.35.1
maintainer
#1 lore raw
Quoted 21 lines · Hatim Muhammed

From: Hatim Muhammed <[email protected]>

---
  drivers/comedi/drivers/das16.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/comedi/drivers/das16.c +1 -1
index 937a69ce0977..d1eeb5896f2d 100644
@@ -956,7 +956,7 @@ static const struct comedi_lrange *das16_ai_range(struct comedi_device *dev,
 
  	/* get any user-defined input range */
  	if (pg_type == das16_pg_none && (min || max)) {
-		struct comedi_lrange *lrange;
+		const struct comedi_lrange *lrange;
  		struct comedi_krange *krange;
 
  		/* allocate single-range range table */

drivers/comedi/drivers/das16.c static const struct comedi_lrange *das16_ao_range(struct comedi_device *dev, · line 996

Quoted 8 lines
drivers/comedi/drivers/das16.c +1 -1
@@ -990,7 +990,7 @@ static const struct comedi_lrange *das16_ao_range(struct comedi_device *dev,
 
  	/* get any user-defined output range */
  	if (min || max) {
-		struct comedi_lrange *lrange;
+		const struct comedi_lrange *lrange;
  		struct comedi_krange *krange;
 
  		/* allocate single-range range table */

NAK. I'm pretty sure this will result in new compiler warnings because *lrange really isn't const.

Signature · 4 lines
-=( Ian Abbott <[email protected]> || MEV Ltd. is a company  )=-
-=( registered in England & Wales.  Regd. number: 02862268.  )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-