Skip to contentSkip to conversation

Constify comedi_lrange struct pointers

PATCH In review Hatim Muhammed 2 participants 2 messages Mar 9, 2022 Comedi drivers

lore
Share & tools
lore
#0 lore raw

PATCH 10/10 Constify comedi_lrange struct pointers

From: Hatim Muhammed <[email protected]>

---
 drivers/comedi/drivers/jr3_pci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/comedi/drivers/jr3_pci.c +2 -2
index 951c23fa0369..f2a750a9112c 100644
@@ -90,8 +90,8 @@ struct jr3_pci_dev_private {
 };
 
 union jr3_pci_single_range {
-	struct comedi_lrange l;
-	char _reserved[offsetof(struct comedi_lrange, range[1])];
+	const struct comedi_lrange l;
+	char _reserved[offsetof(const struct comedi_lrange, range[1])];
 };
 
 enum jr3_pci_poll_state {
Signature · 1 line
2.35.1
maintainer
#1 lore raw
Quoted 12 lines · Hatim Muhammed

From: Hatim Muhammed <[email protected]>

---
  drivers/comedi/drivers/jr3_pci.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)
drivers/comedi/drivers/jr3_pci.c +0 -0
index 951c23fa0369..f2a750a9112c 100644

drivers/comedi/drivers/jr3_pci.c struct jr3_pci_dev_private { · line 97

Quoted 10 lines
drivers/comedi/drivers/jr3_pci.c +2 -2
@@ -90,8 +90,8 @@ struct jr3_pci_dev_private {
  };
 
  union jr3_pci_single_range {
-	struct comedi_lrange l;
-	char _reserved[offsetof(struct comedi_lrange, range[1])];
+	const struct comedi_lrange l;
+	char _reserved[offsetof(const struct comedi_lrange, range[1])];
  };
 
  enum jr3_pci_poll_state {

NAK. That really should not be const.

Signature · 4 lines
-=( Ian Abbott <[email protected]> || MEV Ltd. is a company  )=-
-=( registered in England & Wales.  Regd. number: 02862268.  )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-