aarch64: Add stolen time support
v10 cover aarch64: Add stolen time support
This series adds support for stolen time functionality.
Patch #1 moves the vCPU structure initialisation before the target->init() call to allow early access to the kvm structure from the vCPU during target->init().
Patch #2 modifies the memory layout in arm-common/kvm-arch.h and adds a new MMIO device PVTIME after the RTC region. A new flag is added in kvm-config.h that will be used to control [enable/disable] the pvtime functionality. Stolen time is enabled by default when the host supports KVM_CAP_STEAL_TIME.
Patch #3 adds a new command line argument to disable the stolen time functionality(by default is enabled).
Changelog since v9:
- use the attr field for the 'struct kvm_device_attr' initialisation with KVM_ARM_VCPU_PVTIME_IPA instead of the addr field
Changelog since v8:
- fix an error caused by kvm_cpu__teardown_pvtime() not beeing defined for aarch32
- cleanup the pvtime setup by removing the flag 'is_failed_cfg' and drop the 'pvtime_data_priv' definition
- add missing Review-by tag
The patch has been tested on qemu-system-aarch64.
Sebastian Ene (3):
aarch64: Populate the vCPU struct before target->init()
aarch64: Add stolen time support
Add --no-pvtime command line argument
Makefile | 1 + arm/aarch32/include/kvm/kvm-cpu-arch.h | 5 ++ arm/aarch64/arm-cpu.c | 2 +- arm/aarch64/include/kvm/kvm-cpu-arch.h | 2 + arm/aarch64/pvtime.c | 96 ++++++++++++++++++++++++++ arm/include/arm-common/kvm-arch.h | 6 +- arm/kvm-cpu.c | 15 ++-- builtin-run.c | 2 + include/kvm/kvm-config.h | 1 + 9 files changed, 121 insertions(+), 9 deletions(-) create mode 100644 arm/aarch64/pvtime.c
Signature · 1 line
2.35.1.616.g0bdcbb4464-goog
PATCH v10 1/3 aarch64: Populate the vCPU struct before target->init()
Move the vCPU structure initialisation before the target->init() call to
keep a reference to the kvm structure during init().
This is required by the pvtime peripheral to reserve a memory region while the vCPU is beeing initialised.
--- arm/kvm-cpu.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)
arm/kvm-cpu.c +7 -7
@@ -116,6 +116,13 @@ struct kvm_cpu *kvm_cpu__arch_init(struct kvm *kvm, unsigned long cpu_id)die ("Unable to find matching target" ); } +/* Populate the vcpu structure. */ + vcpu->kvm = kvm; + vcpu->cpu_id = cpu_id; + vcpu->cpu_type = vcpu_init.target; + vcpu->cpu_compatible = target->compatible; + vcpu->is_running = true; +if (err || target->init (vcpu))die ("Unable to initialise vcpu" );
@@ -125,13 +132,6 @@ struct kvm_cpu *kvm_cpu__arch_init(struct kvm *kvm, unsigned long cpu_id) vcpu->ring = (void *)vcpu->kvm_run + (coalesced_offset *PAGE_SIZE ); -/* Populate the vcpu structure. */ - vcpu->kvm = kvm; - vcpu->cpu_id = cpu_id; - vcpu->cpu_type = vcpu_init.target; - vcpu->cpu_compatible = target->compatible; - vcpu->is_running = true; -if (kvm_cpu__configure_features (vcpu))die ("Unable to configure requested vcpu features" );
Signature · 6 lines
2.35.1.616.g0bdcbb4464-goog _______________________________________________ kvmarm mailing list [email protected] https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
PATCH v10 2/3 aarch64: Add stolen time support
In reply to Sebastian EneThis patch adds support for stolen time by sharing a memory region with the guest which will be used by the hypervisor to store the stolen time information. Reserve a 64kb MMIO memory region after the RTC peripheral to be used by pvtime. The exact format of the structure stored by the hypervisor is described in the ARM DEN0057A document.
--- Makefile | 1 + arm/aarch32/include/kvm/kvm-cpu-arch.h | 5 ++ arm/aarch64/arm-cpu.c | 2 +- arm/aarch64/include/kvm/kvm-cpu-arch.h | 2 + arm/aarch64/pvtime.c | 96 ++++++++++++++++++++++++++ arm/include/arm-common/kvm-arch.h | 6 +- arm/kvm-cpu.c | 1 + include/kvm/kvm-config.h | 1 + 8 files changed, 112 insertions(+), 2 deletions(-) create mode 100644 arm/aarch64/pvtime.c
Makefile +1 -0
@@ -182,6 +182,7 @@ ifeq ($(ARCH), arm64) OBJS += arm/aarch64/arm-cpu.o OBJS += arm/aarch64/kvm-cpu.o OBJS += arm/aarch64/kvm.o + OBJS += arm/aarch64/pvtime.o ARCH_INCLUDE := $(HDRS_ARM_COMMON) ARCH_INCLUDE += -Iarm/aarch64/include
arm/aarch32/include/kvm/kvm-cpu-arch.h +5 -0
@@ -20,4 +20,9 @@ static inline int kvm_cpu__configure_features(struct kvm_cpu *vcpu) return 0; } +static inline int kvm_cpu__teardown_pvtime (struct kvm *kvm) +{ +return 0 ; +} +#endif /* KVM__KVM_CPU_ARCH_H */
arm/aarch64/arm-cpu.c +1 -1
@@ -22,7 +22,7 @@ static void generate_fdt_nodes(void *fdt, struct kvm *kvm)static int arm_cpu__vcpu_init (struct kvm_cpu *vcpu) { vcpu->generate_fdt_nodes = generate_fdt_nodes; -return 0 ; +return kvm_cpu__setup_pvtime (vcpu); }static struct kvm_arm_target target_generic_v8 = {
arm/aarch64/include/kvm/kvm-cpu-arch.h +2 -0
@@ -19,5 +19,7 @@void kvm_cpu__select_features (struct kvm *kvm,struct kvm_vcpu_init *init);int kvm_cpu__configure_features (struct kvm_cpu *vcpu); +int kvm_cpu__setup_pvtime (struct kvm_cpu *vcpu); +int kvm_cpu__teardown_pvtime (struct kvm *kvm);#endif /* KVM__KVM_CPU_ARCH_H */
arm/aarch64/pvtime.c new file +96 -0
96 lines not on this page · raw message
arm/include/arm-common/kvm-arch.h +5 -1
@@ -15,7 +15,8 @@* | PCI |////| plat | | | | | * | I/O |////| MMIO: | Flash | virtio | GIC | PCI | DRAM * | space |////| UART, | | MMIO | | (AXI) | -* | |////| RTC | | | | | +* | |////| RTC, | | | | | +* | |////| PVTIME| | | | | * +-------+----+-------+-------+--------+-----+---------+---...... */
@@ -34,6 +35,9 @@#define ARM_RTC_MMIO_BASE (ARM_UART_MMIO_BASE + ARM_UART_MMIO_SIZE)#define ARM_RTC_MMIO_SIZE 0x10000 +#define ARM_PVTIME_BASE (ARM_RTC_MMIO_BASE + ARM_RTC_MMIO_SIZE) +#define ARM_PVTIME_SIZE SZ_64K +#define KVM_FLASH_MMIO_BASE (ARM_MMIO_AREA + 0x1000000)#define KVM_FLASH_MAX_SIZE 0x1000000
arm/kvm-cpu.c +1 -0
@@ -144,6 +144,7 @@ void kvm_cpu__arch_nmi(struct kvm_cpu *cpu)void kvm_cpu__delete (struct kvm_cpu *vcpu) { +kvm_cpu__teardown_pvtime (vcpu->kvm);free (vcpu); }
include/kvm/kvm-config.h +1 -0
@@ -62,6 +62,7 @@ struct kvm_config {bool no_dhcp;bool ioport_debug;bool mmio_debug; + bool no_pvtime; };#endif
Signature · 6 lines
2.35.1.616.g0bdcbb4464-goog _______________________________________________ kvmarm mailing list [email protected] https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
Hi,
Quoted 137 lines · Sebastian Ene
This patch adds support for stolen time by sharing a memory region with the guest which will be used by the hypervisor to store the stolen time information. Reserve a 64kb MMIO memory region after the RTC peripheral to be used by pvtime. The exact format of the structure stored by the hypervisor is described in the ARM DEN0057A document.
Signed-off-by Sebastian Ene <[email protected]>--- Makefile | 1 + arm/aarch32/include/kvm/kvm-cpu-arch.h | 5 ++ arm/aarch64/arm-cpu.c | 2 +- arm/aarch64/include/kvm/kvm-cpu-arch.h | 2 + arm/aarch64/pvtime.c | 96 ++++++++++++++++++++++++++ arm/include/arm-common/kvm-arch.h | 6 +- arm/kvm-cpu.c | 1 + include/kvm/kvm-config.h | 1 + 8 files changed, 112 insertions(+), 2 deletions(-) create mode 100644 arm/aarch64/pvtime.cMakefile +1
-0@@ -182,6 +182,7 @@ ifeq ($(ARCH), arm64) OBJS += arm/aarch64/arm-cpu.o OBJS += arm/aarch64/kvm-cpu.o OBJS += arm/aarch64/kvm.o + OBJS += arm/aarch64/pvtime.o ARCH_INCLUDE := $(HDRS_ARM_COMMON) ARCH_INCLUDE += -Iarm/aarch64/includearm/aarch32/include/kvm/kvm-cpu-arch.h +5
-0@@ -20,4 +20,9 @@ static inline int kvm_cpu__configure_features(struct kvm_cpu *vcpu) return 0; } +static inline int kvm_cpu__teardown_pvtime (struct kvm *kvm) +{ +return 0 ; +} +#endif /* KVM__KVM_CPU_ARCH_H */ arm/aarch64/arm-cpu.c +1
-1@@ -22,7 +22,7 @@ static void generate_fdt_nodes(void *fdt, struct kvm *kvm)static int arm_cpu__vcpu_init (struct kvm_cpu *vcpu) { vcpu->generate_fdt_nodes = generate_fdt_nodes; -return 0 ; +return kvm_cpu__setup_pvtime (vcpu); }static struct kvm_arm_target target_generic_v8 = {arm/aarch64/include/kvm/kvm-cpu-arch.h +2
-0@@ -19,5 +19,7 @@void kvm_cpu__select_features (struct kvm *kvm,struct kvm_vcpu_init *init);int kvm_cpu__configure_features (struct kvm_cpu *vcpu); +int kvm_cpu__setup_pvtime (struct kvm_cpu *vcpu); +int kvm_cpu__teardown_pvtime (struct kvm *kvm);#endif /* KVM__KVM_CPU_ARCH_H */ arm/aarch64/pvtime.c new file +61
-0@@ -0,0 +1,96 @@ +#include "kvm/kvm.h" +#include "kvm/kvm-cpu.h" +#include "kvm/util.h" + +#include <linux/byteorder.h> +#include <linux/types.h> + +#define ARM_PVTIME_STRUCT_SIZE (64) + +static void *usr_mem; + +static int pvtime__alloc_region (struct kvm *kvm) +{ +char *mem; +int ret =0 ; + + mem =mmap (NULL ,ARM_PVTIME_BASE ,PROT_RW , +MAP_ANON_NORESERVE ,-1 ,0 ); +if (mem ==MAP_FAILED ) +return -errno; + + ret =kvm__register_ram (kvm,ARM_PVTIME_BASE , +ARM_PVTIME_BASE , mem); +if (ret) { +munmap (mem,ARM_PVTIME_BASE ); +return ret; + } + + usr_mem = mem; +return ret; +} + +static int pvtime__teardown_region (struct kvm *kvm) +{ +if (usr_mem ==NULL ) +return 0 ; + +kvm__destroy_mem (kvm,ARM_PVTIME_BASE , +ARM_PVTIME_BASE , usr_mem); +munmap (usr_mem,ARM_PVTIME_BASE ); + usr_mem =NULL ; +return 0 ; +} + +int kvm_cpu__setup_pvtime (struct kvm_cpu *vcpu) +{ +int ret; +bool has_stolen_time; +u64 pvtime_guest_addr =ARM_PVTIME_BASE + vcpu->cpu_id * +ARM_PVTIME_STRUCT_SIZE ; +struct kvm_config *kvm_cfg =NULL ; +struct kvm_device_attr pvtime_attr = (struct kvm_device_attr ) { + .group =KVM_ARM_VCPU_PVTIME_CTRL , + .attr =KVM_ARM_VCPU_PVTIME_IPA + }; + + kvm_cfg = &vcpu->kvm->cfg; +if (kvm_cfg->no_pvtime) +return 0 ; + + has_stolen_time = kvm__supports_extension(vcpu->kvm,
arm/aarch64/pvtime.c line 71
Quoted 10 lines
arm/aarch64/pvtime.c new file +10
-0+ KVM_CAP_STEAL_TIME); +if (!has_stolen_time) { + kvm_cfg->no_pvtime = true; +return 0 ; + } + + ret =ioctl (vcpu->vcpu_fd,KVM_HAS_DEVICE_ATTR , &pvtime_attr); +if (ret) { +perror ("KVM_HAS_DEVICE_ATTR failed\n" ); + goto out_err;
Nitpick: here we return -1 (ioctl() return value when it fails) instead of returning -errno. You can set ret = -errno before the perror() call (in case it also fails for some reason, thus changing the value of errno).
Not a big deal, but it changes the semantics of the return value for the
function: below, for pvtime__alloc_region() we return -errno, but here we return -1. Someone who is debugging an error might print this return value and think that the ioctl() failed with error code EPERM (EPERM is 1), which is not a valid error code for ioctl() according to man 2 ioctl. It will also look rather strange for the perror to print the error message associated with a different error code than the error code that is returned from this function.
Quoted 4 lines
arm/aarch64/pvtime.c new file +4
-0+ } + +if (!usr_mem) { + ret =pvtime__alloc_region (vcpu->kvm);
arm/aarch64/pvtime.c line 85
Quoted 10 lines
arm/aarch64/pvtime.c new file +10
-0+if (ret) { +perror ("Failed allocating pvtime region\n" ); + goto out_err; + } + } + + pvtime_attr.addr = (u64)&pvtime_guest_addr; + ret =ioctl (vcpu->vcpu_fd,KVM_SET_DEVICE_ATTR , &pvtime_attr); +if (!ret) +return 0 ;
Nitpick: same here, ret must be set to -errno before returning.
Quoted 53 lines
arm/aarch64/pvtime.c new file +11
-0+ +perror ("KVM_SET_DEVICE_ATTR failed\n" ); +pvtime__teardown_region (vcpu->kvm); +out_err: +return ret; +} + +int kvm_cpu__teardown_pvtime (struct kvm *kvm) +{ +return pvtime__teardown_region (kvm); +}arm/include/arm-common/kvm-arch.h +5
-1@@ -15,7 +15,8 @@* | PCI |////| plat | | | | | * | I/O |////| MMIO: | Flash | virtio | GIC | PCI | DRAM * | space |////| UART, | | MMIO | | (AXI) | -* | |////| RTC | | | | | +* | |////| RTC, | | | | | +* | |////| PVTIME| | | | | * +-------+----+-------+-------+--------+-----+---------+---...... */ @@ -34,6 +35,9 @@#define ARM_RTC_MMIO_BASE (ARM_UART_MMIO_BASE + ARM_UART_MMIO_SIZE)#define ARM_RTC_MMIO_SIZE 0x10000 +#define ARM_PVTIME_BASE (ARM_RTC_MMIO_BASE + ARM_RTC_MMIO_SIZE) +#define ARM_PVTIME_SIZE SZ_64K +#define KVM_FLASH_MMIO_BASE (ARM_MMIO_AREA + 0x1000000)#define KVM_FLASH_MAX_SIZE 0x1000000arm/kvm-cpu.c +1
-0@@ -144,6 +144,7 @@ void kvm_cpu__arch_nmi(struct kvm_cpu *cpu)void kvm_cpu__delete (struct kvm_cpu *vcpu) { +kvm_cpu__teardown_pvtime (vcpu->kvm);free (vcpu); }include/kvm/kvm-config.h +0
-0
include/kvm/kvm-config.h struct kvm_config { · line 68
Quoted 7 lines
include/kvm/kvm-config.h +1
-0@@ -62,6 +62,7 @@ struct kvm_config {bool no_dhcp;bool ioport_debug;bool mmio_debug; + bool no_pvtime; };#endif
Tested the series, a guest is able to detect pvtime:
[ 0.008661] arm-pv: using stolen time PV
With the two nitpicks above fixed, the patch looks correct to me:
Thanks,
Alex
Quoted 2 lines · Alexandru Elisei
Hi,
Hi,
Quoted 153 lines · Sebastian Ene
Quoted 137 lines
This patch adds support for stolen time by sharing a memory region with the guest which will be used by the hypervisor to store the stolen time information. Reserve a 64kb MMIO memory region after the RTC peripheral to be used by pvtime. The exact format of the structure stored by the hypervisor is described in the ARM DEN0057A document.
Signed-off-by Sebastian Ene <[email protected]>--- Makefile | 1 + arm/aarch32/include/kvm/kvm-cpu-arch.h | 5 ++ arm/aarch64/arm-cpu.c | 2 +- arm/aarch64/include/kvm/kvm-cpu-arch.h | 2 + arm/aarch64/pvtime.c | 96 ++++++++++++++++++++++++++ arm/include/arm-common/kvm-arch.h | 6 +- arm/kvm-cpu.c | 1 + include/kvm/kvm-config.h | 1 + 8 files changed, 112 insertions(+), 2 deletions(-) create mode 100644 arm/aarch64/pvtime.cMakefile +1
-0@@ -182,6 +182,7 @@ ifeq ($(ARCH), arm64) OBJS += arm/aarch64/arm-cpu.o OBJS += arm/aarch64/kvm-cpu.o OBJS += arm/aarch64/kvm.o + OBJS += arm/aarch64/pvtime.o ARCH_INCLUDE := $(HDRS_ARM_COMMON) ARCH_INCLUDE += -Iarm/aarch64/includearm/aarch32/include/kvm/kvm-cpu-arch.h +5
-0@@ -20,4 +20,9 @@ static inline int kvm_cpu__configure_features(struct kvm_cpu *vcpu) return 0; } +static inline int kvm_cpu__teardown_pvtime (struct kvm *kvm) +{ +return 0 ; +} +#endif /* KVM__KVM_CPU_ARCH_H */ arm/aarch64/arm-cpu.c +1
-1@@ -22,7 +22,7 @@ static void generate_fdt_nodes(void *fdt, struct kvm *kvm)static int arm_cpu__vcpu_init (struct kvm_cpu *vcpu) { vcpu->generate_fdt_nodes = generate_fdt_nodes; -return 0 ; +return kvm_cpu__setup_pvtime (vcpu); }static struct kvm_arm_target target_generic_v8 = {arm/aarch64/include/kvm/kvm-cpu-arch.h +2
-0@@ -19,5 +19,7 @@void kvm_cpu__select_features (struct kvm *kvm,struct kvm_vcpu_init *init);int kvm_cpu__configure_features (struct kvm_cpu *vcpu); +int kvm_cpu__setup_pvtime (struct kvm_cpu *vcpu); +int kvm_cpu__teardown_pvtime (struct kvm *kvm);#endif /* KVM__KVM_CPU_ARCH_H */ arm/aarch64/pvtime.c new file +61
-0@@ -0,0 +1,96 @@ +#include "kvm/kvm.h" +#include "kvm/kvm-cpu.h" +#include "kvm/util.h" + +#include <linux/byteorder.h> +#include <linux/types.h> + +#define ARM_PVTIME_STRUCT_SIZE (64) + +static void *usr_mem; + +static int pvtime__alloc_region (struct kvm *kvm) +{ +char *mem; +int ret =0 ; + + mem =mmap (NULL ,ARM_PVTIME_BASE ,PROT_RW , +MAP_ANON_NORESERVE ,-1 ,0 ); +if (mem ==MAP_FAILED ) +return -errno; + + ret =kvm__register_ram (kvm,ARM_PVTIME_BASE , +ARM_PVTIME_BASE , mem); +if (ret) { +munmap (mem,ARM_PVTIME_BASE ); +return ret; + } + + usr_mem = mem; +return ret; +} + +static int pvtime__teardown_region (struct kvm *kvm) +{ +if (usr_mem ==NULL ) +return 0 ; + +kvm__destroy_mem (kvm,ARM_PVTIME_BASE , +ARM_PVTIME_BASE , usr_mem); +munmap (usr_mem,ARM_PVTIME_BASE ); + usr_mem =NULL ; +return 0 ; +} + +int kvm_cpu__setup_pvtime (struct kvm_cpu *vcpu) +{ +int ret; +bool has_stolen_time; +u64 pvtime_guest_addr =ARM_PVTIME_BASE + vcpu->cpu_id * +ARM_PVTIME_STRUCT_SIZE ; +struct kvm_config *kvm_cfg =NULL ; +struct kvm_device_attr pvtime_attr = (struct kvm_device_attr ) { + .group =KVM_ARM_VCPU_PVTIME_CTRL , + .attr =KVM_ARM_VCPU_PVTIME_IPA + }; + + kvm_cfg = &vcpu->kvm->cfg; +if (kvm_cfg->no_pvtime) +return 0 ; + + has_stolen_time = kvm__supports_extension(vcpu->kvm,arm/aarch64/pvtime.c line 71
Quoted 10 lines
arm/aarch64/pvtime.c new file +10
-0+ KVM_CAP_STEAL_TIME); +if (!has_stolen_time) { + kvm_cfg->no_pvtime = true; +return 0 ; + } + + ret =ioctl (vcpu->vcpu_fd,KVM_HAS_DEVICE_ATTR , &pvtime_attr); +if (ret) { +perror ("KVM_HAS_DEVICE_ATTR failed\n" ); + goto out_err;Nitpick: here we return -1 (
ioctl()return value when it fails) instead of returning -errno. You can set ret = -errno before theperror()call (in case it also fails for some reason, thus changing the value of errno).
Quoted 9 lines
Not a big deal, but it changes the semantics of the return value for the
function: below, forpvtime__alloc_region()we return -errno, but here we return -1. Someone who is debugging an error might print this return value and think that theioctl()failed with error code EPERM (EPERM is 1), which is not a valid error code forioctl()according to man 2 ioctl. It will also look rather strange for the perror to print the error message associated with a different error code than the error code that is returned from this function.
I will update the return code, thanks for the suggestion.
Quoted 8 lines
Quoted 8 lines
arm/aarch64/pvtime.c new file +8
-0+ } + +if (!usr_mem) { + ret =pvtime__alloc_region (vcpu->kvm); +if (ret) { +perror ("Failed allocating pvtime region\n" ); + goto out_err; + }
Quoted 9 lines
arm/aarch64/pvtime.c line 85
Quoted 6 lines
arm/aarch64/pvtime.c new file +6
-0+ } + + pvtime_attr.addr = (u64)&pvtime_guest_addr; + ret =ioctl (vcpu->vcpu_fd,KVM_SET_DEVICE_ATTR , &pvtime_attr); +if (!ret) +return 0 ;Nitpick: same here, ret must be set to -errno before returning.
Right, I will set it to errno on 'ret != 0'.
Quoted 58 lines
Quoted 58 lines
arm/aarch64/pvtime.c new file +11
-0+ +perror ("KVM_SET_DEVICE_ATTR failed\n" ); +pvtime__teardown_region (vcpu->kvm); +out_err: +return ret; +} + +int kvm_cpu__teardown_pvtime (struct kvm *kvm) +{ +return pvtime__teardown_region (kvm); +}arm/include/arm-common/kvm-arch.h +5
-1@@ -15,7 +15,8 @@* | PCI |////| plat | | | | | * | I/O |////| MMIO: | Flash | virtio | GIC | PCI | DRAM * | space |////| UART, | | MMIO | | (AXI) | -* | |////| RTC | | | | | +* | |////| RTC, | | | | | +* | |////| PVTIME| | | | | * +-------+----+-------+-------+--------+-----+---------+---...... */ @@ -34,6 +35,9 @@#define ARM_RTC_MMIO_BASE (ARM_UART_MMIO_BASE + ARM_UART_MMIO_SIZE)#define ARM_RTC_MMIO_SIZE 0x10000 +#define ARM_PVTIME_BASE (ARM_RTC_MMIO_BASE + ARM_RTC_MMIO_SIZE) +#define ARM_PVTIME_SIZE SZ_64K +#define KVM_FLASH_MMIO_BASE (ARM_MMIO_AREA + 0x1000000)#define KVM_FLASH_MAX_SIZE 0x1000000arm/kvm-cpu.c +1
-0@@ -144,6 +144,7 @@ void kvm_cpu__arch_nmi(struct kvm_cpu *cpu)void kvm_cpu__delete (struct kvm_cpu *vcpu) { +kvm_cpu__teardown_pvtime (vcpu->kvm);free (vcpu); }include/kvm/kvm-config.h +1
-0@@ -62,6 +62,7 @@ struct kvm_config {bool no_dhcp;bool ioport_debug;bool mmio_debug; +bool no_pvtime; };
Quoted 7 lines
include/kvm/kvm-config.h struct kvm_config { · line 68
Quoted 2 lines
include/kvm/kvm-config.h +0
-0#endif Tested the series, a guest is able to detect pvtime:
[ 0.008661] arm-pv: using stolen time PV
Thanks for the review and for testing this,
Quoted 8 lines
Tested-by Alexandru Elisei <[email protected]>With the two nitpicks above fixed, the patch looks correct to me:
Reviewed-by Alexandru Elisei <[email protected]>Thanks,
Alex
Cheers,
Sebastian
PATCH v10 3/3 Add --no-pvtime command line argument
In reply to Sebastian EneThe command line argument disables the stolen time functionality when is specified.
--- builtin-run.c | 2 ++ 1 file changed, 2 insertions(+)
builtin-run.c +2 -0
@@ -128,6 +128,8 @@ void kvm_run_set_wrapper_sandbox(void) " rootfs"), \OPT_STRING ('\0' ,"hugetlbfs" , &(cfg)->hugetlbfs_path,"path" , \"Hugetlbfs path" ), \ +OPT_BOOLEAN ('\0' ,"no-pvtime" , &(cfg)->no_pvtime,"Disable" \ +" stolen time" ), \ \OPT_GROUP ("Kernel options:" ), \ OPT_STRING('k', "kernel", &(cfg)->kernel_filename, "kernel", \
Signature · 6 lines
2.35.1.616.g0bdcbb4464-goog _______________________________________________ kvmarm mailing list [email protected] https://lists.cs.columbia.edu/mailman/listinfo/kvmarm