Skip to contentSkip to conversation

tcp: fix build problem in tcp_inbound_md5_hash()

PATCH In review Jakub Kicinski 2 participants 2 messages Mar 9, 2022

Subsystems (3)
lore
Share & tools
lore

Jakub Kicinski

author maintainer
#0 lore raw

PATCH 1/1 tcp: fix build problem in tcp_inbound_md5_hash()

Semicolon snuck in, this breaks the build with CONFIG_TCP_MD5SIG=n.

Fixes 4be98688274d ("skb: make drop reason booleanable")
---
 include/net/tcp.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/net/tcp.h +1 -1
index ee8237b58e1d..70ca4a5e330a 100644
@@ -1693,7 +1693,7 @@ tcp_md5_do_lookup(const struct sock *sk, int l3index,
 static inline enum skb_drop_reason
 tcp_inbound_md5_hash(const struct sock *sk, const struct sk_buff *skb,
 		     const void *saddr, const void *daddr,
-		     int family, int dif, int sdif);
+		     int family, int dif, int sdif)
 {
 	return SKB_NOT_DROPPED_YET;
 }
Signature · 1 line
2.34.1
#1 lore raw
Quoted 7 lines · Jakub Kicinski

Semicolon snuck in, this breaks the build with CONFIG_TCP_MD5SIG=n.

Fixes 4be98688274d ("skb: make drop reason booleanable")

---

Vladimir Oltean sent the fix earlier this morning.

Thanks.