drm/i915: SAGV block time fixes
v2 cover drm/i915: SAGV block time fixes
From: Ville Syrjälä <[email protected]>
Try to fix SAGV block time handling:
- zero means no SAGV
- avoid integer overflows
- slightly better debug logs
- assorted cleanups
v2: reorder to allow stable backport of the zero->no SAGV patch
Fix/clean some PSF GV stuff as well that caught my eye
Ville Syrjälä (8):
drm/i915: Treat SAGV block time 0 as SAGV disabled drm/i915: Rework SAGV block time probing drm/i915: Probe whether SAGV works on pre-icl drm/i915: Reject excessive SAGV block time drm/i915: Rename pre-icl SAGV enable/disable functions drm/i915: Fix PSF GV point mask when SAGV is not possible drm/i915: Unconfuses QGV vs. PSF point masks drm/i915: Rename QGV request/response bits
drivers/gpu/drm/i915/display/intel_bw.c | 39 ++++++----- drivers/gpu/drm/i915/i915_reg.h | 17 +++-- drivers/gpu/drm/i915/intel_pm.c | 92 ++++++++++++++++--------- 3 files changed, 90 insertions(+), 58 deletions(-)
Signature · 1 line
2.34.1
PATCH v2 1/8 drm/i915: Treat SAGV block time 0 as SAGV disabled
From: Ville Syrjälä <[email protected]>
For modern platforms the spec explicitly states that a SAGV block time of zero means that SAGV is not supported. Let's extend that to all platforms. Supposedly there should be no systems where this isn't true, and it'll allow us to:
- use the same code regardless of older vs. newer platform
- wm latencies already treat 0 as disabled, so this fits well with other related code
- make it a bit more clear when SAGV is used vs. not
- avoid overflows from adding U32_MAX with a u16 wm0 latency value which could cause us to miscalculate the SAGV watermarks on tgl+
--- drivers/gpu/drm/i915/intel_pm.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/intel_pm.c +6 -4
@@ -3696,8 +3696,7 @@ skl_setup_sagv_block_time(struct drm_i915_private *dev_priv)MISSING_CASE (DISPLAY_VER (dev_priv)); } -/* Default to an unusable block time */ - dev_priv->sagv_block_time_us =-1 ; + dev_priv->sagv_block_time_us =0 ; }/*
@@ -5644,7 +5643,7 @@ static void skl_compute_plane_wm(const struct intel_crtc_state *crtc_state, result->min_ddb_alloc =max (min_ddb_alloc, blocks) +1 ; result->enable = true; -if (DISPLAY_VER (dev_priv) <12 ) +if (DISPLAY_VER (dev_priv) <12 && dev_priv->sagv_block_time_us) result->can_sagv = latency >= dev_priv->sagv_block_time_us; }
@@ -5677,7 +5676,10 @@ static void tgl_compute_sagv_wm(const struct intel_crtc_state *crtc_state,struct drm_i915_private *dev_priv =to_i915 (crtc_state->uapi.crtc->dev);struct skl_wm_level *sagv_wm = &plane_wm->sagv.wm0;struct skl_wm_level *levels = plane_wm->wm; -unsigned int latency = dev_priv->wm.skl_latency[0 ] + dev_priv->sagv_block_time_us; +unsigned int latency =0 ; + +if (dev_priv->sagv_block_time_us) + latency = dev_priv->sagv_block_time_us + dev_priv->wm.skl_latency[0 ]; skl_compute_plane_wm(crtc_state, plane, 0, latency, wm_params, &levels[0],
Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH v2 1/8] drm/i915: Treat SAGV block time 0 as SAGV disabled
Quoted 43 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
For modern platforms the spec explicitly states that a SAGV block time of zero means that SAGV is not supported. Let's extend that to all platforms. Supposedly there should be no systems where this isn't true, and it'll allow us to:
- use the same code regardless of older vs. newer platform
- wm latencies already treat 0 as disabled, so this fits well with other related code
- make it a bit more clear when SAGV is used vs. not
- avoid overflows from addingU32_MAXwith a u16 wm0 latency value which could cause us to miscalculate the SAGV watermarks on tgl+Signed-off-by Ville Syrjälä <[email protected]>--- drivers/gpu/drm/i915/intel_pm.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/intel_pm.c +2
-3@@ -3696,8 +3696,7 @@ skl_setup_sagv_block_time(struct drm_i915_private *dev_priv)MISSING_CASE (DISPLAY_VER (dev_priv)); } -/* Default to an unusable block time */ - dev_priv->sagv_block_time_us =-1 ; + dev_priv->sagv_block_time_us =0 ; }/* @@ -5644,7 +5643,7 @@ static void skl_compute_plane_wm(const struct intel_crtc_state *crtc_state, result->min_ddb_alloc =max (min_ddb_alloc, blocks) +1 ; result->enable = true; -if (DISPLAY_VER (dev_priv) <12 ) +if (DISPLAY_VER (dev_priv) <12 && dev_priv->sagv_block_time_us) result->can_sagv = latency >= dev_priv->sagv_block_time_us; }
drivers/gpu/drm/i915/intel_pm.c static void tgl_compute_sagv_wm(const struct intel_crtc_state *crtc_state, · line 5682
Quoted 8 lines
drivers/gpu/drm/i915/intel_pm.c +4
-1@@ -5677,7 +5676,10 @@ static void tgl_compute_sagv_wm(const struct intel_crtc_state *crtc_state,struct drm_i915_private *dev_priv =to_i915 (crtc_state->uapi.crtc->dev);struct skl_wm_level *sagv_wm = &plane_wm->sagv.wm0;struct skl_wm_level *levels = plane_wm->wm; -unsigned int latency = dev_priv->wm.skl_latency[0 ] + dev_priv->sagv_block_time_us; +unsigned int latency =0 ; + +if (dev_priv->sagv_block_time_us) + latency = dev_priv->sagv_block_time_us + dev_priv->wm.skl_latency[0 ];
Should we may be add this to intel_has_sagv? I thought this was supposed to tell, if SAGV is supported or not. Should we just call it hear as well, may be.. Now we kinda making it less obvious.
Stan
Quoted 6 lines
drivers/gpu/drm/i915/intel_pm.c +0
-0skl_compute_plane_wm(crtc_state, plane, 0, latency, wm_params, &levels[0],Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH v2 1/8] drm/i915: Treat SAGV block time 0 as SAGV disabled
Quoted 43 lines · Stanislav
Quoted 42 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
For modern platforms the spec explicitly states that a SAGV block time of zero means that SAGV is not supported. Let's extend that to all platforms. Supposedly there should be no systems where this isn't true, and it'll allow us to:
- use the same code regardless of older vs. newer platform
- wm latencies already treat 0 as disabled, so this fits well with other related code
- make it a bit more clear when SAGV is used vs. not
- avoid overflows from addingU32_MAXwith a u16 wm0 latency value which could cause us to miscalculate the SAGV watermarks on tgl+Signed-off-by Ville Syrjälä <[email protected]>--- drivers/gpu/drm/i915/intel_pm.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/intel_pm.c +2
-3@@ -3696,8 +3696,7 @@ skl_setup_sagv_block_time(struct drm_i915_private *dev_priv)MISSING_CASE (DISPLAY_VER (dev_priv)); } -/* Default to an unusable block time */ - dev_priv->sagv_block_time_us =-1 ; + dev_priv->sagv_block_time_us =0 ; }/* @@ -5644,7 +5643,7 @@ static void skl_compute_plane_wm(const struct intel_crtc_state *crtc_state, result->min_ddb_alloc =max (min_ddb_alloc, blocks) +1 ; result->enable = true; -if (DISPLAY_VER (dev_priv) <12 ) +if (DISPLAY_VER (dev_priv) <12 && dev_priv->sagv_block_time_us) result->can_sagv = latency >= dev_priv->sagv_block_time_us; }
Quoted 13 lines
drivers/gpu/drm/i915/intel_pm.c static void tgl_compute_sagv_wm(const struct intel_crtc_state *crtc_state, · line 5682
Quoted 9 lines
drivers/gpu/drm/i915/intel_pm.c +4
-1@@ -5677,7 +5676,10 @@ static void tgl_compute_sagv_wm(const struct intel_crtc_state *crtc_state,struct drm_i915_private *dev_priv =to_i915 (crtc_state->uapi.crtc->dev);struct skl_wm_level *sagv_wm = &plane_wm->sagv.wm0;struct skl_wm_level *levels = plane_wm->wm; -unsigned int latency = dev_priv->wm.skl_latency[0 ] + dev_priv->sagv_block_time_us; +unsigned int latency =0 ; + +if (dev_priv->sagv_block_time_us) + latency = dev_priv->sagv_block_time_us + dev_priv->wm.skl_latency[0 ];Should we may be add this to
intel_has_sagv? I thought this was supposed to tell, if SAGV is supported or not. Should we just call it hear as well, may be.. Now we kinda making it less obvious.
We already use intel_has_sagv() to see if we should zero out the block time. I don't think I want to make it a full circle.
Quoted 9 lines
Stan
Quoted 6 lines
drivers/gpu/drm/i915/intel_pm.c +0
-0skl_compute_plane_wm(crtc_state, plane, 0, latency, wm_params, &levels[0],Signature · 1 line
2.34.1
Signature · 2 lines
Ville Syrjälä Intel
Re: [Intel-gfx] [PATCH v2 1/8] drm/i915: Treat SAGV block time 0 as SAGV disabled
In reply to Ville SyrjalaQuoted 13 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
For modern platforms the spec explicitly states that a SAGV block time of zero means that SAGV is not supported. Let's extend that to all platforms. Supposedly there should be no systems where this isn't true, and it'll allow us to:
- use the same code regardless of older vs. newer platform
- wm latencies already treat 0 as disabled, so this fits well with other related code
- make it a bit more clear when SAGV is used vs. not
- avoid overflows from addingU32_MAXwith a u16 wm0 latency value which could cause us to miscalculate the SAGV watermarks on tgl+
Quoted 2 lines
Signed-off-by Ville Syrjälä <[email protected]>
Quoted 42 lines
--- drivers/gpu/drm/i915/intel_pm.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)drivers/gpu/drm/i915/intel_pm.c +6
-4@@ -3696,8 +3696,7 @@ skl_setup_sagv_block_time(struct drm_i915_private *dev_priv)MISSING_CASE (DISPLAY_VER (dev_priv)); } -/* Default to an unusable block time */ - dev_priv->sagv_block_time_us =-1 ; + dev_priv->sagv_block_time_us =0 ; }/* @@ -5644,7 +5643,7 @@ static void skl_compute_plane_wm(const struct intel_crtc_state *crtc_state, result->min_ddb_alloc =max (min_ddb_alloc, blocks) +1 ; result->enable = true; -if (DISPLAY_VER (dev_priv) <12 ) +if (DISPLAY_VER (dev_priv) <12 && dev_priv->sagv_block_time_us) result->can_sagv = latency >= dev_priv->sagv_block_time_us; }@@ -5677,7 +5676,10 @@ static void tgl_compute_sagv_wm(const struct intel_crtc_state *crtc_state,struct drm_i915_private *dev_priv =to_i915 (crtc_state->uapi.crtc->dev);struct skl_wm_level *sagv_wm = &plane_wm->sagv.wm0;struct skl_wm_level *levels = plane_wm->wm; -unsigned int latency = dev_priv->wm.skl_latency[0 ] + dev_priv->sagv_block_time_us; +unsigned int latency =0 ; + +if (dev_priv->sagv_block_time_us) + latency = dev_priv->sagv_block_time_us + dev_priv->wm.skl_latency[0 ]; skl_compute_plane_wm(crtc_state, plane, 0, latency, wm_params, &levels[0],Signature · 1 line
2.34.1
PATCH v2 2/8 drm/i915: Rework SAGV block time probing
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
I'd like to see the SAGV block time we got from the mailbox in the logs regardless of whether other factors prevent the use of SAGV.
So let's adjust the code to always query the SAGV block time, log it, and then reset it if SAGV is not actually supported.
--- drivers/gpu/drm/i915/intel_pm.c | 36 +++++++++++++++++++-------------- 1 file changed, 21 insertions(+), 15 deletions(-)
drivers/gpu/drm/i915/intel_pm.c +21 -15
@@ -3670,8 +3670,8 @@ intel_has_sagv(struct drm_i915_private *dev_priv) dev_priv->sagv_status !=I915_SAGV_NOT_CONTROLLED ; } -static void -skl_setup_sagv_block_time (struct drm_i915_private *dev_priv) +static u32 +intel_sagv_block_time (struct drm_i915_private *dev_priv) {if (DISPLAY_VER (dev_priv) >=12 ) {u32 val =0 ;
@@ -3680,23 +3680,30 @@ skl_setup_sagv_block_time(struct drm_i915_private *dev_priv) ret =snb_pcode_read (dev_priv,GEN12_PCODE_READ_SAGV_BLOCK_TIME_US , &val,NULL ); -if (!ret) { - dev_priv->sagv_block_time_us = val; -return ; +if (ret) { +drm_dbg_kms (&dev_priv->drm,"Couldn't read SAGV block time!\n" ); +return 0 ; } -drm_dbg (&dev_priv->drm,"Couldn't read SAGV block time!\n" ); +return val; }else if (DISPLAY_VER (dev_priv) ==11 ) { - dev_priv->sagv_block_time_us =10 ; -return ; - }else if (DISPLAY_VER (dev_priv) ==9 ) { - dev_priv->sagv_block_time_us =30 ; -return ; +return 10 ; + }else if (DISPLAY_VER (dev_priv) ==9 && !IS_LP (dev_priv)) { +return 30 ; }else { -MISSING_CASE (DISPLAY_VER (dev_priv)); +return 0 ; } +} - dev_priv->sagv_block_time_us =0 ; +static void intel_sagv_init (struct drm_i915_private *i915) +{ + i915->sagv_block_time_us =intel_sagv_block_time (i915); + +drm_dbg_kms (&i915->drm,"SAGV supported: %s, original SAGV block time: %u us\n" , +str_yes_no (intel_has_sagv (i915)), i915->sagv_block_time_us); + +if (!intel_has_sagv (i915)) + i915->sagv_block_time_us =0 ; }/*
@@ -8175,8 +8182,7 @@ void intel_init_pm(struct drm_i915_private *dev_priv)else if (GRAPHICS_VER (dev_priv) ==5 )ilk_get_mem_freq (dev_priv); -if (intel_has_sagv (dev_priv)) -skl_setup_sagv_block_time (dev_priv); +intel_sagv_init (dev_priv);/* For FIFO watermark updates */ if (DISPLAY_VER (dev_priv) >=9 ) {
Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH v2 2/8] drm/i915: Rework SAGV block time probing
Quoted 10 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
I'd like to see the SAGV block time we got from the mailbox in the logs regardless of whether other factors prevent the use of SAGV.
So let's adjust the code to always query the SAGV block time, log it, and then reset it if SAGV is not actually supported.
Signed-off-by Ville Syrjälä <[email protected]>
Quoted 74 lines
--- drivers/gpu/drm/i915/intel_pm.c | 36 +++++++++++++++++++-------------- 1 file changed, 21 insertions(+), 15 deletions(-)drivers/gpu/drm/i915/intel_pm.c +21
-15@@ -3670,8 +3670,8 @@ intel_has_sagv(struct drm_i915_private *dev_priv) dev_priv->sagv_status !=I915_SAGV_NOT_CONTROLLED ; } -static void -skl_setup_sagv_block_time (struct drm_i915_private *dev_priv) +static u32 +intel_sagv_block_time (struct drm_i915_private *dev_priv) {if (DISPLAY_VER (dev_priv) >=12 ) {u32 val =0 ;@@ -3680,23 +3680,30 @@ skl_setup_sagv_block_time(struct drm_i915_private *dev_priv) ret =snb_pcode_read (dev_priv,GEN12_PCODE_READ_SAGV_BLOCK_TIME_US , &val,NULL ); -if (!ret) { - dev_priv->sagv_block_time_us = val; -return ; +if (ret) { +drm_dbg_kms (&dev_priv->drm,"Couldn't read SAGV block time!\n" ); +return 0 ; } -drm_dbg (&dev_priv->drm,"Couldn't read SAGV block time!\n" ); +return val; }else if (DISPLAY_VER (dev_priv) ==11 ) { - dev_priv->sagv_block_time_us =10 ; -return ; - }else if (DISPLAY_VER (dev_priv) ==9 ) { - dev_priv->sagv_block_time_us =30 ; -return ; +return 10 ; + }else if (DISPLAY_VER (dev_priv) ==9 && !IS_LP (dev_priv)) { +return 30 ; }else { -MISSING_CASE (DISPLAY_VER (dev_priv)); +return 0 ; } +} - dev_priv->sagv_block_time_us =0 ; +static void intel_sagv_init (struct drm_i915_private *i915) +{ + i915->sagv_block_time_us =intel_sagv_block_time (i915); + +drm_dbg_kms (&i915->drm,"SAGV supported: %s, original SAGV block time: %u us\n" , +str_yes_no (intel_has_sagv (i915)), i915->sagv_block_time_us); + +if (!intel_has_sagv (i915)) + i915->sagv_block_time_us =0 ; }/* @@ -8175,8 +8182,7 @@ void intel_init_pm(struct drm_i915_private *dev_priv)else if (GRAPHICS_VER (dev_priv) ==5 )ilk_get_mem_freq (dev_priv); -if (intel_has_sagv (dev_priv)) -skl_setup_sagv_block_time (dev_priv); +intel_sagv_init (dev_priv);/* For FIFO watermark updates */ if (DISPLAY_VER (dev_priv) >=9 ) {Signature · 1 line
2.34.1
PATCH v2 3/8 drm/i915: Probe whether SAGV works on pre-icl
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
Instead of leaving the SAGV enable/disable to the first commit let's try to disable it first thing to see if we can do it or not (disabling SAGV is a safe thing to at any time). This avoids running the code in this funny intermediate state where we don't know if SAGV is available or not.
--- drivers/gpu/drm/i915/intel_pm.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)
drivers/gpu/drm/i915/intel_pm.c +14 -0
@@ -57,6 +57,8 @@#include "vlv_sideband.h" #include "../../../platform/x86/intel_ips.h" +static int intel_disable_sagv (struct drm_i915_private *dev_priv); +struct drm_i915_clock_gating_funcs {void (*init_clock_gating)(struct drm_i915_private *i915); };
@@ -3697,6 +3699,18 @@ intel_sagv_block_time(struct drm_i915_private *dev_priv)static void intel_sagv_init (struct drm_i915_private *i915) { +if (!intel_has_sagv (i915)) + i915->sagv_status =I915_SAGV_NOT_CONTROLLED ; + +/* +* Probe to see if we have working SAGV control. +* For icl+ this was already determined by intel_bw_init_hw(). +*/ +if (DISPLAY_VER (i915) <11 ) +intel_disable_sagv (i915); + +drm_WARN_ON (&i915->drm, i915->sagv_status ==I915_SAGV_UNKNOWN ); + i915->sagv_block_time_us =intel_sagv_block_time (i915); drm_dbg_kms(&i915->drm, "SAGV supported: %s, original SAGV block time: %u us\n",
Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH v2 3/8] drm/i915: Probe whether SAGV works on pre-icl
Quoted 9 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
Instead of leaving the SAGV enable/disable to the first commit let's try to disable it first thing to see if we can do it or not (disabling SAGV is a safe thing to at any time). This avoids running the code in this funny intermediate state where we don't know if SAGV is available or not.
Signed-off-by Ville Syrjälä <[email protected]>
Quoted 39 lines
--- drivers/gpu/drm/i915/intel_pm.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)drivers/gpu/drm/i915/intel_pm.c +14
-0@@ -57,6 +57,8 @@#include "vlv_sideband.h" #include "../../../platform/x86/intel_ips.h" +static int intel_disable_sagv (struct drm_i915_private *dev_priv); +struct drm_i915_clock_gating_funcs {void (*init_clock_gating)(struct drm_i915_private *i915); };@@ -3697,6 +3699,18 @@ intel_sagv_block_time(struct drm_i915_private *dev_priv)static void intel_sagv_init (struct drm_i915_private *i915) { +if (!intel_has_sagv (i915)) + i915->sagv_status =I915_SAGV_NOT_CONTROLLED ; + +/* +* Probe to see if we have working SAGV control. +* For icl+ this was already determined by intel_bw_init_hw(). +*/ +if (DISPLAY_VER (i915) <11 ) +intel_disable_sagv (i915); + +drm_WARN_ON (&i915->drm, i915->sagv_status ==I915_SAGV_UNKNOWN ); + i915->sagv_block_time_us =intel_sagv_block_time (i915); drm_dbg_kms(&i915->drm, "SAGV supported: %s, original SAGV block time: %u us\n",Signature · 1 line
2.34.1
PATCH v2 4/8 drm/i915: Reject excessive SAGV block time
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
If the mailbox returns an exceesively large SAGV block time let's just reject it. This avoids having to worry about overflows when we add the SAGV block time to the wm0 latency.
We shall put the limit arbitrarily at U16_MAX. >65msec latency doesn't really make sense to me in any case.
--- drivers/gpu/drm/i915/intel_pm.c | 6 ++++++ 1 file changed, 6 insertions(+)
drivers/gpu/drm/i915/intel_pm.c +6 -0
@@ -3716,6 +3716,12 @@ static void intel_sagv_init(struct drm_i915_private *i915)drm_dbg_kms (&i915->drm,"SAGV supported: %s, original SAGV block time: %u us\n" ,str_yes_no (intel_has_sagv (i915)), i915->sagv_block_time_us); +/* avoid overflow when adding with wm0 latency/etc. */ +if (drm_WARN (&i915->drm, i915->sagv_block_time_us >U16_MAX , +"Excessive SAGV block time %u, ignoring\n" , + i915->sagv_block_time_us)) + i915->sagv_block_time_us =0 ; +if (!intel_has_sagv (i915)) i915->sagv_block_time_us =0 ; }
Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH v2 4/8] drm/i915: Reject excessive SAGV block time
Quoted 10 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
If the mailbox returns an exceesively large SAGV block time let's just reject it. This avoids having to worry about overflows when we add the SAGV block time to the wm0 latency.
We shall put the limit arbitrarily at
U16_MAX. >65msec latency doesn't really make sense to me in any case.Signed-off-by Ville Syrjälä <[email protected]>
Quoted 24 lines
--- drivers/gpu/drm/i915/intel_pm.c | 6 ++++++ 1 file changed, 6 insertions(+)drivers/gpu/drm/i915/intel_pm.c +6
-0@@ -3716,6 +3716,12 @@ static void intel_sagv_init(struct drm_i915_private *i915)drm_dbg_kms (&i915->drm,"SAGV supported: %s, original SAGV block time: %u us\n" ,str_yes_no (intel_has_sagv (i915)), i915->sagv_block_time_us); +/* avoid overflow when adding with wm0 latency/etc. */ +if (drm_WARN (&i915->drm, i915->sagv_block_time_us >U16_MAX , +"Excessive SAGV block time %u, ignoring\n" , + i915->sagv_block_time_us)) + i915->sagv_block_time_us =0 ; +if (!intel_has_sagv (i915)) i915->sagv_block_time_us =0 ; }Signature · 1 line
2.34.1
PATCH v2 5/8 drm/i915: Rename pre-icl SAGV enable/disable functions
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
Give the pre-icl SAGV control functions a skl_ prefix instead of the intel_ prefix to make it a bit more clear that they are not some kind of universal things that can be called on any platform. Also make the functions void since we never use the return value anyway.
--- drivers/gpu/drm/i915/intel_pm.c | 32 ++++++++++++++------------------ 1 file changed, 14 insertions(+), 18 deletions(-)
drivers/gpu/drm/i915/intel_pm.c +14 -18
@@ -57,7 +57,7 @@#include "vlv_sideband.h" #include "../../../platform/x86/intel_ips.h" -static int intel_disable_sagv (struct drm_i915_private *dev_priv); +static void skl_sagv_disable (struct drm_i915_private *dev_priv);struct drm_i915_clock_gating_funcs {void (*init_clock_gating)(struct drm_i915_private *i915);
@@ -3707,7 +3707,7 @@ static void intel_sagv_init(struct drm_i915_private *i915)* For icl+ this was already determined by intel_bw_init_hw(). */ if (DISPLAY_VER (i915) <11 ) -intel_disable_sagv (i915); +skl_sagv_disable (i915);drm_WARN_ON (&i915->drm, i915->sagv_status ==I915_SAGV_UNKNOWN );
@@ -3737,16 +3737,15 @@ static void intel_sagv_init(struct drm_i915_private *i915)* - All planes can enable watermarks for latencies >= SAGV engine block time * - We're not using an interlaced display configuration */ -static int -intel_enable_sagv (struct drm_i915_private *dev_priv) +static void skl_sagv_enable (struct drm_i915_private *dev_priv) {int ret;if (!intel_has_sagv (dev_priv)) -return 0 ; +return ;if (dev_priv->sagv_status ==I915_SAGV_ENABLED ) -return 0 ; +return ;drm_dbg_kms (&dev_priv->drm,"Enabling SAGV\n" ); ret = snb_pcode_write(dev_priv, GEN9_PCODE_SAGV_CONTROL,
@@ -3761,26 +3760,24 @@ intel_enable_sagv(struct drm_i915_private *dev_priv)if (IS_SKYLAKE (dev_priv) && ret == -ENXIO ) {drm_dbg (&dev_priv->drm,"No SAGV found on system, ignoring\n" ); dev_priv->sagv_status =I915_SAGV_NOT_CONTROLLED ; -return 0 ; +return ; }else if (ret <0 ) {drm_err (&dev_priv->drm,"Failed to enable SAGV\n" ); -return ret; +return ; } dev_priv->sagv_status =I915_SAGV_ENABLED ; -return 0 ; } -static int -intel_disable_sagv (struct drm_i915_private *dev_priv) +static void skl_sagv_disable (struct drm_i915_private *dev_priv) {int ret;if (!intel_has_sagv (dev_priv)) -return 0 ; +return ;if (dev_priv->sagv_status ==I915_SAGV_DISABLED ) -return 0 ; +return ;drm_dbg_kms (&dev_priv->drm,"Disabling SAGV\n" );/* bspec says to keep retrying for at least 1 ms */
@@ -3795,14 +3792,13 @@ intel_disable_sagv(struct drm_i915_private *dev_priv)if (IS_SKYLAKE (dev_priv) && ret == -ENXIO ) {drm_dbg (&dev_priv->drm,"No SAGV found on system, ignoring\n" ); dev_priv->sagv_status =I915_SAGV_NOT_CONTROLLED ; -return 0 ; +return ; }else if (ret <0 ) {drm_err (&dev_priv->drm,"Failed to disable SAGV (%d)\n" , ret); -return ret; +return ; } dev_priv->sagv_status =I915_SAGV_DISABLED ; -return 0 ; }static void skl_sagv_pre_plane_update (struct intel_atomic_state *state)
@@ -3815,7 +3811,7 @@ static void skl_sagv_pre_plane_update(struct intel_atomic_state *state)return ;if (!intel_can_enable_sagv (i915, new_bw_state)) -intel_disable_sagv (i915); +skl_sagv_disable (i915); }static void skl_sagv_post_plane_update (struct intel_atomic_state *state)
@@ -3828,7 +3824,7 @@ static void skl_sagv_post_plane_update(struct intel_atomic_state *state)return ;if (intel_can_enable_sagv (i915, new_bw_state)) -intel_enable_sagv (i915); +skl_sagv_enable (i915); }static void icl_sagv_pre_plane_update (struct intel_atomic_state *state)
Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH v2 5/8] drm/i915: Rename pre-icl SAGV enable/disable functions
Quoted 9 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
Give the pre-icl SAGV control functions a
skl_prefix instead of theintel_prefix to make it a bit more clear that they are not some kind of universal things that can be called on any platform. Also make the functions void since we never use the return value anyway.Signed-off-by Ville Syrjälä <[email protected]>
Quoted 116 lines
--- drivers/gpu/drm/i915/intel_pm.c | 32 ++++++++++++++------------------ 1 file changed, 14 insertions(+), 18 deletions(-)drivers/gpu/drm/i915/intel_pm.c +14
-18@@ -57,7 +57,7 @@#include "vlv_sideband.h" #include "../../../platform/x86/intel_ips.h" -static int intel_disable_sagv (struct drm_i915_private *dev_priv); +static void skl_sagv_disable (struct drm_i915_private *dev_priv);struct drm_i915_clock_gating_funcs {void (*init_clock_gating)(struct drm_i915_private *i915);@@ -3707,7 +3707,7 @@ static void intel_sagv_init(struct drm_i915_private *i915)* For icl+ this was already determined by intel_bw_init_hw(). */ if (DISPLAY_VER (i915) <11 ) -intel_disable_sagv (i915); +skl_sagv_disable (i915);drm_WARN_ON (&i915->drm, i915->sagv_status ==I915_SAGV_UNKNOWN );@@ -3737,16 +3737,15 @@ static void intel_sagv_init(struct drm_i915_private *i915)* - All planes can enable watermarks for latencies >= SAGV engine block time * - We're not using an interlaced display configuration */ -static int -intel_enable_sagv (struct drm_i915_private *dev_priv) +static void skl_sagv_enable (struct drm_i915_private *dev_priv) {int ret;if (!intel_has_sagv (dev_priv)) -return 0 ; +return ;if (dev_priv->sagv_status ==I915_SAGV_ENABLED ) -return 0 ; +return ;drm_dbg_kms (&dev_priv->drm,"Enabling SAGV\n" ); ret = snb_pcode_write(dev_priv, GEN9_PCODE_SAGV_CONTROL,@@ -3761,26 +3760,24 @@ intel_enable_sagv(struct drm_i915_private *dev_priv)if (IS_SKYLAKE (dev_priv) && ret == -ENXIO ) {drm_dbg (&dev_priv->drm,"No SAGV found on system, ignoring\n" ); dev_priv->sagv_status =I915_SAGV_NOT_CONTROLLED ; -return 0 ; +return ; }else if (ret <0 ) {drm_err (&dev_priv->drm,"Failed to enable SAGV\n" ); -return ret; +return ; } dev_priv->sagv_status =I915_SAGV_ENABLED ; -return 0 ; } -static int -intel_disable_sagv (struct drm_i915_private *dev_priv) +static void skl_sagv_disable (struct drm_i915_private *dev_priv) {int ret;if (!intel_has_sagv (dev_priv)) -return 0 ; +return ;if (dev_priv->sagv_status ==I915_SAGV_DISABLED ) -return 0 ; +return ;drm_dbg_kms (&dev_priv->drm,"Disabling SAGV\n" );/* bspec says to keep retrying for at least 1 ms */ @@ -3795,14 +3792,13 @@ intel_disable_sagv(struct drm_i915_private *dev_priv)if (IS_SKYLAKE (dev_priv) && ret == -ENXIO ) {drm_dbg (&dev_priv->drm,"No SAGV found on system, ignoring\n" ); dev_priv->sagv_status =I915_SAGV_NOT_CONTROLLED ; -return 0 ; +return ; }else if (ret <0 ) {drm_err (&dev_priv->drm,"Failed to disable SAGV (%d)\n" , ret); -return ret; +return ; } dev_priv->sagv_status =I915_SAGV_DISABLED ; -return 0 ; }static void skl_sagv_pre_plane_update (struct intel_atomic_state *state)@@ -3815,7 +3811,7 @@ static void skl_sagv_pre_plane_update(struct intel_atomic_state *state)return ;if (!intel_can_enable_sagv (i915, new_bw_state)) -intel_disable_sagv (i915); +skl_sagv_disable (i915); }static void skl_sagv_post_plane_update (struct intel_atomic_state *state)@@ -3828,7 +3824,7 @@ static void skl_sagv_post_plane_update(struct intel_atomic_state *state)return ;if (intel_can_enable_sagv (i915, new_bw_state)) -intel_enable_sagv (i915); +skl_sagv_enable (i915); }static void icl_sagv_pre_plane_update (struct intel_atomic_state *state)Signature · 1 line
2.34.1
PATCH v2 6/8 drm/i915: Fix PSF GV point mask when SAGV is not possible
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
Don't just mask off all the PSF GV points when SAGV gets disabled. This should in fact cause the Pcode to reject the request since at least one PSF point must remain enabled at all times.
--- drivers/gpu/drm/i915/display/intel_bw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/display/intel_bw.c +2 -1
@@ -992,7 +992,8 @@ int intel_bw_atomic_check(struct intel_atomic_state *state)* cause. */ if (!intel_can_enable_sagv (dev_priv, new_bw_state)) { - allowed_points =BIT (max_bw_point); + allowed_points &=ADLS_PSF_PT_MASK ; + allowed_points |=BIT (max_bw_point);drm_dbg_kms (&dev_priv->drm,"No SAGV, using single QGV point %d\n" , max_bw_point); }
Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH v2 6/8] drm/i915: Fix PSF GV point mask when SAGV is not possible
Quoted 5 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
Don't just mask off all the PSF GV points when SAGV gets disabled. This should in fact cause the Pcode to reject the request since at least one PSF point must remain enabled at all times.
Good point, however I think this is not the full fix:
BSpec says:
"At least one GV point of each type must always remain unmasked."
and
"The GV point of each type providing the highest bandwidth
for display must always remain unmasked."
So I guess we should then also choose thr PSF GV point with the highest bandwidth as well.
Stan
Quoted 26 lines
Cc Stanislav Lisovskiy <[email protected]>Fixes 192fbfb76744 ("drm/i915: Implement PSF GV point support")Signed-off-by Ville Syrjälä <[email protected]>--- drivers/gpu/drm/i915/display/intel_bw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)drivers/gpu/drm/i915/display/intel_bw.c +2
-1@@ -992,7 +992,8 @@ int intel_bw_atomic_check(struct intel_atomic_state *state)* cause. */ if (!intel_can_enable_sagv (dev_priv, new_bw_state)) { - allowed_points =BIT (max_bw_point); + allowed_points &=ADLS_PSF_PT_MASK ; + allowed_points |=BIT (max_bw_point);drm_dbg_kms (&dev_priv->drm,"No SAGV, using single QGV point %d\n" , max_bw_point); }Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH v2 6/8] drm/i915: Fix PSF GV point mask when SAGV is not possible
Quoted 13 lines · Stanislav
Quoted 5 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
Don't just mask off all the PSF GV points when SAGV gets disabled. This should in fact cause the Pcode to reject the request since at least one PSF point must remain enabled at all times.
Good point, however I think this is not the full fix:
BSpec says:
"At least one GV point of each type must always remain unmasked."
Quoted 7 lines
and
"The GV point of each type providing the highest bandwidth
for display must always remain unmasked."So I guess we should then also choose thr PSF GV point with the highest bandwidth as well.
The spec says PSF GV is fast enough to now stall the display data fetch so we don't need to restrict the PSF points here.
Signature · 2 lines
Ville Syrjälä Intel
Re: [Intel-gfx] [PATCH v2 6/8] drm/i915: Fix PSF GV point mask when SAGV is not possible
Quoted 16 lines · Ville Syrjälä
Quoted 15 lines · Stanislav
Quoted 5 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
Don't just mask off all the PSF GV points when SAGV gets disabled. This should in fact cause the Pcode to reject the request since at least one PSF point must remain enabled at all times.
Good point, however I think this is not the full fix:
BSpec says:
"At least one GV point of each type must always remain unmasked."
and
Quoted 8 lines
Quoted 5 lines
"The GV point of each type providing the highest bandwidth
for display must always remain unmasked."So I guess we should then also choose thr PSF GV point with the highest bandwidth as well.
The spec says PSF GV is fast enough to now stall the display data fetch so we don't need to restrict the PSF points here.
But why it asks to ensure that we have the PSF GV of highest bandwidth to stay always unmasked then?
Stan
Quoted 4 lines
Signature · 3 lines
-- Ville Syrjälä Intel
Re: [Intel-gfx] [PATCH v2 6/8] drm/i915: Fix PSF GV point mask when SAGV is not possible
Quoted 20 lines · Stanislav
Quoted 19 lines · Ville Syrjälä
Quoted 18 lines · Stanislav
Quoted 5 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
Don't just mask off all the PSF GV points when SAGV gets disabled. This should in fact cause the Pcode to reject the request since at least one PSF point must remain enabled at all times.
Good point, however I think this is not the full fix:
BSpec says:
"At least one GV point of each type must always remain unmasked."
and
"The GV point of each type providing the highest bandwidth
for display must always remain unmasked."
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
So I guess we should then also choose thr PSF GV point with the highest bandwidth as well.
The spec says PSF GV is fast enough to now stall the display data fetch so we don't need to restrict the PSF points here.
But why it asks to ensure that we have the PSF GV of highest bandwidth to stay always unmasked then?
I presume so you don't lock the memory bandwdith to some lower performance point and hurt all the other things that need memory bandwidth. Either that or there is some internal implementation detail that simply doesn't work if you try to permanently run at a lower performance point.
Signature · 2 lines
Ville Syrjälä Intel
Lisovskiy, Stanislav
Reviewed-byRe: [Intel-gfx] [PATCH v2 6/8] drm/i915: Fix PSF GV point mask when SAGV is not possible
In reply to Lisovskiy, StanislavQuoted 23 lines · Stanislav
Quoted 22 lines · Ville Syrjälä
Quoted 20 lines · Stanislav
Quoted 5 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
Don't just mask off all the PSF GV points when SAGV gets disabled. This should in fact cause the Pcode to reject the request since at least one PSF point must remain enabled at all times.
Good point, however I think this is not the full fix:
BSpec says:
"At least one GV point of each type must always remain unmasked."
and
"The GV point of each type providing the highest bandwidth
for display must always remain unmasked."So I guess we should then also choose thr PSF GV point with the highest bandwidth as well.
Quoted 7 lines
Quoted 2 lines
The spec says PSF GV is fast enough to now stall the display data fetch so we don't need to restrict the PSF points here.
But why it asks to ensure that we have the PSF GV of highest bandwidth to stay always unmasked then?
Stan
Quoted 5 lines
Quoted 5 lines
Signature · 3 lines
-- Ville Syrjälä Intel
PATCH v2 7/8 drm/i915: Unconfuses QGV vs. PSF point masks
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
Use separate bitmasks for QGV vs. PSF GV points during the computation. Makes the whole thing a lot less confusing.
--- drivers/gpu/drm/i915/display/intel_bw.c | 35 ++++++++++++------------- drivers/gpu/drm/i915/i915_reg.h | 3 ++- 2 files changed, 19 insertions(+), 19 deletions(-)
drivers/gpu/drm/i915/display/intel_bw.c +17 -18
@@ -820,7 +820,7 @@ static u16 icl_qgv_points_mask(struct drm_i915_private *i915) {unsigned int num_psf_gv_points = i915->max_bw[0 ].num_psf_gv_points;unsigned int num_qgv_points = i915->max_bw[0 ].num_qgv_points; -u16 mask =0 ; +u16 qgv_points =0 , psf_points =0 ;/* * We can _not_ use the whole ADLS_QGV_PT_MASK here, as PCode rejects
@@ -828,12 +828,12 @@ static u16 icl_qgv_points_mask(struct drm_i915_private *i915)* So need to operate only with those returned from PCode. */ if (num_qgv_points >0 ) - mask |=REG_GENMASK (num_qgv_points -1 ,0 ); + qgv_points =GENMASK (num_qgv_points -1 ,0 );if (num_psf_gv_points >0 ) - mask |=REG_GENMASK (num_psf_gv_points -1 ,0 ) <<ADLS_PSF_PT_SHIFT ; + psf_points =GENMASK (num_psf_gv_points -1 ,0 ); -return mask; +return ADLS_QGV_PT (qgv_points) |ADLS_PSF_PT (psf_points); }static int intel_bw_check_data_rate (struct intel_atomic_state *state,bool *changed)
@@ -890,7 +890,7 @@ int intel_bw_atomic_check(struct intel_atomic_state *state)unsigned int data_rate;unsigned int num_active_planes;int i, ret; -u32 allowed_points =0 ; +u16 qgv_points =0 , psf_points =0 ;unsigned int max_bw_point =0 , max_bw =0 ;unsigned int num_qgv_points = dev_priv->max_bw[0 ].num_qgv_points;unsigned int num_psf_gv_points = dev_priv->max_bw[0 ].num_psf_gv_points;
@@ -948,7 +948,7 @@ int intel_bw_atomic_check(struct intel_atomic_state *state) max_bw = max_data_rate; }if (max_data_rate >= data_rate) - allowed_points |=REG_FIELD_PREP (ADLS_QGV_PT_MASK ,BIT (i)); + qgv_points |=BIT (i);drm_dbg_kms (&dev_priv->drm,"QGV point %d: max bw %d required %d\n" , i, max_data_rate, data_rate);
@@ -958,7 +958,7 @@ int intel_bw_atomic_check(struct intel_atomic_state *state)unsigned int max_data_rate =adl_psf_bw (dev_priv, i);if (max_data_rate >= data_rate) - allowed_points |=REG_FIELD_PREP (ADLS_PSF_PT_MASK ,BIT (i)); + psf_points |=BIT (i); drm_dbg_kms(&dev_priv->drm, "PSF GV point %d: max bw %d" " required %d\n",
@@ -970,20 +970,18 @@ int intel_bw_atomic_check(struct intel_atomic_state *state)* left, so if we couldn't - simply reject the configuration for obvious * reasons. */ -if ((allowed_points &ADLS_QGV_PT_MASK ) ==0 ) { +if (qgv_points ==0 ) {drm_dbg_kms (&dev_priv->drm,"No QGV points provide sufficient memory" " bandwidth %d for display configuration(%d active planes).\n" , data_rate, num_active_planes);return -EINVAL ; } -if (num_psf_gv_points >0 ) { -if ((allowed_points &ADLS_PSF_PT_MASK ) ==0 ) { -drm_dbg_kms (&dev_priv->drm,"No PSF GV points provide sufficient memory" -" bandwidth %d for display configuration(%d active planes).\n" , - data_rate, num_active_planes); -return -EINVAL ; - } +if (num_psf_gv_points >0 && psf_points ==0 ) { +drm_dbg_kms (&dev_priv->drm,"No PSF GV points provide sufficient memory" +" bandwidth %d for display configuration(%d active planes).\n" , + data_rate, num_active_planes); +return -EINVAL ; }/*
@@ -992,16 +990,17 @@ int intel_bw_atomic_check(struct intel_atomic_state *state)* cause. */ if (!intel_can_enable_sagv (dev_priv, new_bw_state)) { - allowed_points &=ADLS_PSF_PT_MASK ; - allowed_points |=BIT (max_bw_point); + qgv_points =BIT (max_bw_point);drm_dbg_kms (&dev_priv->drm,"No SAGV, using single QGV point %d\n" , max_bw_point); } +/* * We store the ones which need to be masked as that is what PCode * actually accepts as a parameter. */ - new_bw_state->qgv_points_mask = ~allowed_points & + new_bw_state->qgv_points_mask = + ~(ADLS_QGV_PT (qgv_points) |ADLS_PSF_PT (psf_points)) &icl_qgv_points_mask (dev_priv);/*
drivers/gpu/drm/i915/i915_reg.h +2 -1
@@ -6722,9 +6722,10 @@#define ICL_PCODE_SAGV_DE_MEM_SS_CONFIG 0xe#define ICL_PCODE_POINTS_RESTRICTED 0x0#define ICL_PCODE_POINTS_RESTRICTED_MASK 0xf -#define ADLS_PSF_PT_SHIFT 8#define ADLS_QGV_PT_MASK REG_GENMASK(7, 0) +#define ADLS_QGV_PT (x) REG_FIELD_PREP(ADLS_QGV_PT_MASK, (x))#define ADLS_PSF_PT_MASK REG_GENMASK(10, 8) +#define ADLS_PSF_PT (x) REG_FIELD_PREP(ADLS_PSF_PT_MASK, (x))#define GEN6_PCODE_READ_D_COMP 0x10#define GEN6_PCODE_WRITE_D_COMP 0x11#define ICL_PCODE_EXIT_TCCOLD 0x12
Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH v2 7/8] drm/i915: Unconfuses QGV vs. PSF point masks
Quoted 6 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
Use separate bitmasks for QGV vs. PSF GV points during the computation. Makes the whole thing a lot less confusing.
Signed-off-by Ville Syrjälä <[email protected]>
Quoted 128 lines
--- drivers/gpu/drm/i915/display/intel_bw.c | 35 ++++++++++++------------- drivers/gpu/drm/i915/i915_reg.h | 3 ++- 2 files changed, 19 insertions(+), 19 deletions(-)drivers/gpu/drm/i915/display/intel_bw.c +17
-18@@ -820,7 +820,7 @@ static u16 icl_qgv_points_mask(struct drm_i915_private *i915) {unsigned int num_psf_gv_points = i915->max_bw[0 ].num_psf_gv_points;unsigned int num_qgv_points = i915->max_bw[0 ].num_qgv_points; -u16 mask =0 ; +u16 qgv_points =0 , psf_points =0 ;/* * We can _not_ use the whole ADLS_QGV_PT_MASK here, as PCode rejects @@ -828,12 +828,12 @@ static u16 icl_qgv_points_mask(struct drm_i915_private *i915)* So need to operate only with those returned from PCode. */ if (num_qgv_points >0 ) - mask |=REG_GENMASK (num_qgv_points -1 ,0 ); + qgv_points =GENMASK (num_qgv_points -1 ,0 );if (num_psf_gv_points >0 ) - mask |=REG_GENMASK (num_psf_gv_points -1 ,0 ) <<ADLS_PSF_PT_SHIFT ; + psf_points =GENMASK (num_psf_gv_points -1 ,0 ); -return mask; +return ADLS_QGV_PT (qgv_points) |ADLS_PSF_PT (psf_points); }static int intel_bw_check_data_rate (struct intel_atomic_state *state,bool *changed)@@ -890,7 +890,7 @@ int intel_bw_atomic_check(struct intel_atomic_state *state)unsigned int data_rate;unsigned int num_active_planes;int i, ret; -u32 allowed_points =0 ; +u16 qgv_points =0 , psf_points =0 ;unsigned int max_bw_point =0 , max_bw =0 ;unsigned int num_qgv_points = dev_priv->max_bw[0 ].num_qgv_points;unsigned int num_psf_gv_points = dev_priv->max_bw[0 ].num_psf_gv_points;@@ -948,7 +948,7 @@ int intel_bw_atomic_check(struct intel_atomic_state *state) max_bw = max_data_rate; }if (max_data_rate >= data_rate) - allowed_points |=REG_FIELD_PREP (ADLS_QGV_PT_MASK ,BIT (i)); + qgv_points |=BIT (i);drm_dbg_kms (&dev_priv->drm,"QGV point %d: max bw %d required %d\n" , i, max_data_rate, data_rate);@@ -958,7 +958,7 @@ int intel_bw_atomic_check(struct intel_atomic_state *state)unsigned int max_data_rate =adl_psf_bw (dev_priv, i);if (max_data_rate >= data_rate) - allowed_points |=REG_FIELD_PREP (ADLS_PSF_PT_MASK ,BIT (i)); + psf_points |=BIT (i); drm_dbg_kms(&dev_priv->drm, "PSF GV point %d: max bw %d" " required %d\n",@@ -970,20 +970,18 @@ int intel_bw_atomic_check(struct intel_atomic_state *state)* left, so if we couldn't - simply reject the configuration for obvious * reasons. */ -if ((allowed_points &ADLS_QGV_PT_MASK ) ==0 ) { +if (qgv_points ==0 ) {drm_dbg_kms (&dev_priv->drm,"No QGV points provide sufficient memory" " bandwidth %d for display configuration(%d active planes).\n" , data_rate, num_active_planes);return -EINVAL ; } -if (num_psf_gv_points >0 ) { -if ((allowed_points &ADLS_PSF_PT_MASK ) ==0 ) { -drm_dbg_kms (&dev_priv->drm,"No PSF GV points provide sufficient memory" -" bandwidth %d for display configuration(%d active planes).\n" , - data_rate, num_active_planes); -return -EINVAL ; - } +if (num_psf_gv_points >0 && psf_points ==0 ) { +drm_dbg_kms (&dev_priv->drm,"No PSF GV points provide sufficient memory" +" bandwidth %d for display configuration(%d active planes).\n" , + data_rate, num_active_planes); +return -EINVAL ; }/* @@ -992,16 +990,17 @@ int intel_bw_atomic_check(struct intel_atomic_state *state)* cause. */ if (!intel_can_enable_sagv (dev_priv, new_bw_state)) { - allowed_points &=ADLS_PSF_PT_MASK ; - allowed_points |=BIT (max_bw_point); + qgv_points =BIT (max_bw_point);drm_dbg_kms (&dev_priv->drm,"No SAGV, using single QGV point %d\n" , max_bw_point); } +/* * We store the ones which need to be masked as that is what PCode * actually accepts as a parameter. */ - new_bw_state->qgv_points_mask = ~allowed_points & + new_bw_state->qgv_points_mask = + ~(ADLS_QGV_PT (qgv_points) |ADLS_PSF_PT (psf_points)) &icl_qgv_points_mask (dev_priv);/* drivers/gpu/drm/i915/i915_reg.h +2
-1@@ -6722,9 +6722,10 @@#define ICL_PCODE_SAGV_DE_MEM_SS_CONFIG 0xe#define ICL_PCODE_POINTS_RESTRICTED 0x0#define ICL_PCODE_POINTS_RESTRICTED_MASK 0xf -#define ADLS_PSF_PT_SHIFT 8#define ADLS_QGV_PT_MASK REG_GENMASK(7, 0) +#define ADLS_QGV_PT (x) REG_FIELD_PREP(ADLS_QGV_PT_MASK, (x))#define ADLS_PSF_PT_MASK REG_GENMASK(10, 8) +#define ADLS_PSF_PT (x) REG_FIELD_PREP(ADLS_PSF_PT_MASK, (x))#define GEN6_PCODE_READ_D_COMP 0x10#define GEN6_PCODE_WRITE_D_COMP 0x11#define ICL_PCODE_EXIT_TCCOLD 0x12Signature · 1 line
2.34.1
PATCH v2 8/8 drm/i915: Rename QGV request/response bits
In reply to Ville SyrjalaFrom: Ville Syrjälä <[email protected]>
Name all the ICL_PCODE_SAGV_DE_MEM_SS_CONFIG request/response bits in a manner that we can actually understand what they're doing.
--- drivers/gpu/drm/i915/display/intel_bw.c | 9 +++++---- drivers/gpu/drm/i915/i915_reg.h | 18 ++++++++++++------ 2 files changed, 17 insertions(+), 10 deletions(-)
drivers/gpu/drm/i915/display/intel_bw.c +5 -4
@@ -124,8 +124,8 @@ int icl_pcode_restrict_qgv_points(struct drm_i915_private *dev_priv,/* bspec says to keep retrying for at least 1 ms */ ret =skl_pcode_request (dev_priv,ICL_PCODE_SAGV_DE_MEM_SS_CONFIG , points_mask, -ICL_PCODE_POINTS_RESTRICTED_MASK , -ICL_PCODE_POINTS_RESTRICTED , +ICL_PCODE_REP_QGV_MASK |ADLS_PCODE_REP_PSF_MASK , +ICL_PCODE_REP_QGV_SAFE |ADLS_PCODE_REP_PSF_SAFE ,1 );if (ret <0 ) {
@@ -833,7 +833,7 @@ static u16 icl_qgv_points_mask(struct drm_i915_private *i915)if (num_psf_gv_points >0 ) psf_points =GENMASK (num_psf_gv_points -1 ,0 ); -return ADLS_QGV_PT (qgv_points) |ADLS_PSF_PT (psf_points); +return ICL_PCODE_REQ_QGV_PT (qgv_points) |ADLS_PCODE_REQ_PSF_PT (psf_points); }static int intel_bw_check_data_rate (struct intel_atomic_state *state,bool *changed)
@@ -1000,7 +1000,8 @@ int intel_bw_atomic_check(struct intel_atomic_state *state)* actually accepts as a parameter. */ new_bw_state->qgv_points_mask = - ~(ADLS_QGV_PT (qgv_points) |ADLS_PSF_PT (psf_points)) & + ~(ICL_PCODE_REQ_QGV_PT (qgv_points) | +ADLS_PCODE_REQ_PSF_PT (psf_points)) &icl_qgv_points_mask (dev_priv);/*
drivers/gpu/drm/i915/i915_reg.h +12 -6
@@ -6720,12 +6720,18 @@#define ICL_PCODE_MEM_SS_READ_QGV_POINT_INFO (point) (((point) << 16) | (0x1 << 8))#define ADL_PCODE_MEM_SS_READ_PSF_GV_INFO ((0) | (0x2 << 8))#define ICL_PCODE_SAGV_DE_MEM_SS_CONFIG 0xe -#define ICL_PCODE_POINTS_RESTRICTED 0x0 -#define ICL_PCODE_POINTS_RESTRICTED_MASK 0xf -#define ADLS_QGV_PT_MASK REG_GENMASK(7, 0) -#define ADLS_QGV_PT (x) REG_FIELD_PREP(ADLS_QGV_PT_MASK, (x)) -#define ADLS_PSF_PT_MASK REG_GENMASK(10, 8) -#define ADLS_PSF_PT (x) REG_FIELD_PREP(ADLS_PSF_PT_MASK, (x)) +#define ICL_PCODE_REP_QGV_MASK REG_GENMASK(1, 0) +#define ICL_PCODE_REP_QGV_SAFE REG_FIELD_PREP(ICL_PCODE_REP_QGV_MASK, 0) +#define ICL_PCODE_REP_QGV_POLL REG_FIELD_PREP(ICL_PCODE_REP_QGV_MASK, 1) +#define ICL_PCODE_REP_QGV_REJECTED REG_FIELD_PREP(ICL_PCODE_REP_QGV_MASK, 2) +#define ADLS_PCODE_REP_PSF_MASK REG_GENMASK(3, 2) +#define ADLS_PCODE_REP_PSF_SAFE REG_FIELD_PREP(ADLS_PCODE_REP_PSF_MASK, 0) +#define ADLS_PCODE_REP_PSF_POLL REG_FIELD_PREP(ADLS_PCODE_REP_PSF_MASK, 1) +#define ADLS_PCODE_REP_PSF_REJECTED REG_FIELD_PREP(ADLS_PCODE_REP_PSF_MASK, 2) +#define ICL_PCODE_REQ_QGV_PT_MASK REG_GENMASK(7, 0) +#define ICL_PCODE_REQ_QGV_PT (x) REG_FIELD_PREP(ICL_PCODE_REQ_QGV_PT_MASK, (x)) +#define ADLS_PCODE_REQ_PSF_PT_MASK REG_GENMASK(10, 8) +#define ADLS_PCODE_REQ_PSF_PT (x) REG_FIELD_PREP(ADLS_PCODE_REQ_PSF_PT_MASK, (x))#define GEN6_PCODE_READ_D_COMP 0x10#define GEN6_PCODE_WRITE_D_COMP 0x11#define ICL_PCODE_EXIT_TCCOLD 0x12
Signature · 1 line
2.34.1
Re: [Intel-gfx] [PATCH v2 8/8] drm/i915: Rename QGV request/response bits
Quoted 7 lines · Ville Syrjala
From: Ville Syrjälä <[email protected]>
Name all the
ICL_PCODE_SAGV_DE_MEM_SS_CONFIGrequest/response bits in a manner that we can actually understand what they're doing.Signed-off-by Ville Syrjälä <[email protected]>
Quoted 71 lines
--- drivers/gpu/drm/i915/display/intel_bw.c | 9 +++++---- drivers/gpu/drm/i915/i915_reg.h | 18 ++++++++++++------ 2 files changed, 17 insertions(+), 10 deletions(-)drivers/gpu/drm/i915/display/intel_bw.c +5
-4@@ -124,8 +124,8 @@ int icl_pcode_restrict_qgv_points(struct drm_i915_private *dev_priv,/* bspec says to keep retrying for at least 1 ms */ ret =skl_pcode_request (dev_priv,ICL_PCODE_SAGV_DE_MEM_SS_CONFIG , points_mask, -ICL_PCODE_POINTS_RESTRICTED_MASK , -ICL_PCODE_POINTS_RESTRICTED , +ICL_PCODE_REP_QGV_MASK |ADLS_PCODE_REP_PSF_MASK , +ICL_PCODE_REP_QGV_SAFE |ADLS_PCODE_REP_PSF_SAFE ,1 );if (ret <0 ) {@@ -833,7 +833,7 @@ static u16 icl_qgv_points_mask(struct drm_i915_private *i915)if (num_psf_gv_points >0 ) psf_points =GENMASK (num_psf_gv_points -1 ,0 ); -return ADLS_QGV_PT (qgv_points) |ADLS_PSF_PT (psf_points); +return ICL_PCODE_REQ_QGV_PT (qgv_points) |ADLS_PCODE_REQ_PSF_PT (psf_points); }static int intel_bw_check_data_rate (struct intel_atomic_state *state,bool *changed)@@ -1000,7 +1000,8 @@ int intel_bw_atomic_check(struct intel_atomic_state *state)* actually accepts as a parameter. */ new_bw_state->qgv_points_mask = - ~(ADLS_QGV_PT (qgv_points) |ADLS_PSF_PT (psf_points)) & + ~(ICL_PCODE_REQ_QGV_PT (qgv_points) | +ADLS_PCODE_REQ_PSF_PT (psf_points)) &icl_qgv_points_mask (dev_priv);/* drivers/gpu/drm/i915/i915_reg.h +12
-6@@ -6720,12 +6720,18 @@#define ICL_PCODE_MEM_SS_READ_QGV_POINT_INFO (point) (((point) << 16) | (0x1 << 8))#define ADL_PCODE_MEM_SS_READ_PSF_GV_INFO ((0) | (0x2 << 8))#define ICL_PCODE_SAGV_DE_MEM_SS_CONFIG 0xe -#define ICL_PCODE_POINTS_RESTRICTED 0x0 -#define ICL_PCODE_POINTS_RESTRICTED_MASK 0xf -#define ADLS_QGV_PT_MASK REG_GENMASK(7, 0) -#define ADLS_QGV_PT (x) REG_FIELD_PREP(ADLS_QGV_PT_MASK, (x)) -#define ADLS_PSF_PT_MASK REG_GENMASK(10, 8) -#define ADLS_PSF_PT (x) REG_FIELD_PREP(ADLS_PSF_PT_MASK, (x)) +#define ICL_PCODE_REP_QGV_MASK REG_GENMASK(1, 0) +#define ICL_PCODE_REP_QGV_SAFE REG_FIELD_PREP(ICL_PCODE_REP_QGV_MASK, 0) +#define ICL_PCODE_REP_QGV_POLL REG_FIELD_PREP(ICL_PCODE_REP_QGV_MASK, 1) +#define ICL_PCODE_REP_QGV_REJECTED REG_FIELD_PREP(ICL_PCODE_REP_QGV_MASK, 2) +#define ADLS_PCODE_REP_PSF_MASK REG_GENMASK(3, 2) +#define ADLS_PCODE_REP_PSF_SAFE REG_FIELD_PREP(ADLS_PCODE_REP_PSF_MASK, 0) +#define ADLS_PCODE_REP_PSF_POLL REG_FIELD_PREP(ADLS_PCODE_REP_PSF_MASK, 1) +#define ADLS_PCODE_REP_PSF_REJECTED REG_FIELD_PREP(ADLS_PCODE_REP_PSF_MASK, 2) +#define ICL_PCODE_REQ_QGV_PT_MASK REG_GENMASK(7, 0) +#define ICL_PCODE_REQ_QGV_PT (x) REG_FIELD_PREP(ICL_PCODE_REQ_QGV_PT_MASK, (x)) +#define ADLS_PCODE_REQ_PSF_PT_MASK REG_GENMASK(10, 8) +#define ADLS_PCODE_REQ_PSF_PT (x) REG_FIELD_PREP(ADLS_PCODE_REQ_PSF_PT_MASK, (x))#define GEN6_PCODE_READ_D_COMP 0x10#define GEN6_PCODE_WRITE_D_COMP 0x11#define ICL_PCODE_EXIT_TCCOLD 0x12Signature · 1 line
2.34.1
Patchwork
CI[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: SAGV block time fixes (rev2)
In reply to Ville Syrjala== Series Details ==
== Series Details ==
Series: drm/i915: SAGV block time fixes (rev2)
URL : https://patchwork.freedesktop.org/series/101171/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.
Patchwork
CI[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: SAGV block time fixes (rev2)
In reply to Ville Syrjala== Series Details ==
== Series Details ==
Series: drm/i915: SAGV block time fixes (rev2)
URL : https://patchwork.freedesktop.org/series/101171/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11346 -> Patchwork_22524
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/index.html
Participating hosts (43 -> 35)
------------------------------
Additional (1): fi-pnv-d510
Missing (9): bat-dg1-6 bat-dg1-5 bat-dg2-9 fi-bsw-cyan bat-adlp-6 bat-adlp-4 fi-ctg-p8600 bat-jsl-2 bat-jsl-1
Known issues
------------
Here are the changes found in Patchwork_22524 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@prime_vgem@basic-userptr:
- fi-pnv-d510: NOTRUN -> [SKIP][1] ([fdo#109271]) +58 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/fi-pnv-d510/igt@[email protected]
#### Possible fixes ####
* igt@core_hotunplug@unbind-rebind:
- fi-blb-e6850: [FAIL][2] ([i915#3194]) -> [PASS][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/fi-blb-e6850/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/fi-blb-e6850/igt@[email protected]
* igt@gem_exec_suspend@basic-s3@smem:
- {fi-rkl-11600}: [INCOMPLETE][4] ([i915#5127]) -> [PASS][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/fi-rkl-11600/igt@gem_exec_suspend@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/fi-rkl-11600/igt@gem_exec_suspend@[email protected]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3194]: https://gitlab.freedesktop.org/drm/intel/issues/3194
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5127]: https://gitlab.freedesktop.org/drm/intel/issues/5127
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
Build changes
-------------
* Linux: CI_DRM_11346 -> Patchwork_22524
CI-20190529: 20190529
CI_DRM_11346: ab6456d23719e60c20e8cef05a5f322eea134b88 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6373: 82306f1903c0fee8371f43a156d8b63163ca61c1 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_22524: 947f302e9d2d4716c0cb2bed715c2b7085535fa9 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
947f302e9d2d drm/i915: Rename QGV request/response bits c745332be423 drm/i915: Unconfuses QGV vs. PSF point masks a21de1e7d3fd drm/i915: Fix PSF GV point mask when SAGV is not possible 244e37910608 drm/i915: Rename pre-icl SAGV enable/disable functions 5eaafe273039 drm/i915: Reject excessive SAGV block time e8e1719bfc7d drm/i915: Probe whether SAGV works on pre-icl bc3dfeda81e4 drm/i915: Rework SAGV block time probing 060166c820c6 drm/i915: Treat SAGV block time 0 as SAGV disabled
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/index.html
Patchwork
CI[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: SAGV block time fixes (rev2)
In reply to Ville Syrjala== Series Details ==
== Series Details ==
Series: drm/i915: SAGV block time fixes (rev2)
URL : https://patchwork.freedesktop.org/series/101171/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11346_full -> Patchwork_22524_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_22524_full absolutely need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_22524_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
Participating hosts (13 -> 13)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_22524_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_draw_crc@draw-method-xrgb8888-render-4tiled:
- shard-iclb: NOTRUN -> [SKIP][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-iclb5/igt@[email protected]
* igt@kms_frontbuffer_tracking@fbc-indfb-scaledprimary:
- shard-tglb: [PASS][2] -> [INCOMPLETE][3]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-tglb6/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-tglb6/igt@[email protected]
* igt@kms_hdr@bpc-switch-suspend@bpc-switch-suspend-dp-1-pipe-a:
- shard-kbl: [PASS][4] -> [INCOMPLETE][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-kbl1/igt@kms_hdr@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-kbl4/igt@kms_hdr@[email protected]
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.
* igt@kms_big_fb@4-tiled-64bpp-rotate-90:
- {shard-rkl}: [SKIP][6] ([i915#5286]) -> [SKIP][7]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-rkl-6/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-rkl-2/igt@[email protected]
* igt@kms_big_fb@4-tiled-addfb-size-overflow:
- {shard-rkl}: NOTRUN -> [SKIP][8] +6 similar issues
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-rkl-2/igt@[email protected]
* igt@kms_draw_crc@draw-method-xrgb8888-blt-4tiled:
- {shard-dg1}: NOTRUN -> [SKIP][9] +2 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-dg1-18/igt@[email protected]
* igt@kms_mmap_write_crc@main:
- {shard-dg1}: NOTRUN -> [FAIL][10]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-dg1-16/igt@[email protected]
Known issues
------------
Here are the changes found in Patchwork_22524_full that come from known issues:
### CI changes ###
#### Possible fixes ####
* boot:
- shard-glk: ([PASS][11], [PASS][12], [PASS][13], [PASS][14], [PASS][15], [PASS][16], [PASS][17], [PASS][18], [PASS][19], [PASS][20], [PASS][21], [PASS][22], [PASS][23], [PASS][24], [PASS][25], [FAIL][26], [PASS][27], [PASS][28], [PASS][29], [PASS][30], [PASS][31], [PASS][32], [PASS][33], [PASS][34], [PASS][35]) ([i915#4392]) -> ([PASS][36], [PASS][37], [PASS][38], [PASS][39], [PASS][40], [PASS][41], [PASS][42], [PASS][43], [PASS][44], [PASS][45], [PASS][46], [PASS][47], [PASS][48], [PASS][49], [PASS][50], [PASS][51], [PASS][52], [PASS][53], [PASS][54], [PASS][55], [PASS][56], [PASS][57], [PASS][58], [PASS][59], [PASS][60])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-glk9/boot.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-glk9/boot.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-glk9/boot.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-glk8/boot.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-glk8/boot.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-glk8/boot.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-glk7/boot.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-glk7/boot.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-glk6/boot.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-glk6/boot.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-glk6/boot.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-glk5/boot.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-glk5/boot.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-glk4/boot.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-glk4/boot.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-glk4/boot.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-glk3/boot.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-glk3/boot.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-glk3/boot.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-glk2/boot.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-glk2/boot.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-glk2/boot.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-glk1/boot.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-glk1/boot.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-glk1/boot.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk3/boot.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk3/boot.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk4/boot.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk4/boot.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk4/boot.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk5/boot.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk5/boot.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk5/boot.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk6/boot.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk6/boot.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk6/boot.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk7/boot.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk7/boot.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk7/boot.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk8/boot.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk8/boot.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk8/boot.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk9/boot.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk9/boot.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk1/boot.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk1/boot.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk2/boot.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk2/boot.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk2/boot.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk3/boot.html
### IGT changes ###
#### Issues hit ####
* igt@feature_discovery@psr2:
- shard-iclb: [PASS][61] -> [SKIP][62] ([i915#658])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-iclb2/igt@[email protected]
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-iclb3/igt@[email protected]
* igt@gem_create@create-massive:
- shard-kbl: NOTRUN -> [DMESG-WARN][63] ([i915#4991])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-kbl6/igt@[email protected]
* igt@gem_exec_balancer@parallel:
- shard-tglb: NOTRUN -> [DMESG-WARN][64] ([i915#5076])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-tglb3/igt@[email protected]
* igt@gem_exec_balancer@parallel-ordering:
- shard-tglb: NOTRUN -> [DMESG-FAIL][65] ([i915#5076])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-tglb7/igt@[email protected]
* igt@gem_exec_fair@basic-deadline:
- shard-kbl: [PASS][66] -> [FAIL][67] ([i915#2846])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-kbl7/igt@[email protected]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-kbl1/igt@[email protected]
* igt@gem_exec_fair@basic-flow@rcs0:
- shard-skl: NOTRUN -> [SKIP][68] ([fdo#109271]) +189 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-skl1/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-none-vip@rcs0:
- shard-kbl: [PASS][69] -> [FAIL][70] ([i915#2842])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-kbl4/igt@gem_exec_fair@[email protected]
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-kbl7/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-tglb: [PASS][71] -> [FAIL][72] ([i915#2842])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-tglb7/igt@gem_exec_fair@[email protected]
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-tglb2/igt@gem_exec_fair@[email protected]
* igt@gem_exec_fair@basic-pace@vecs0:
- shard-glk: [PASS][73] -> [FAIL][74] ([i915#2842]) +1 similar issue
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-glk6/igt@gem_exec_fair@[email protected]
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk2/igt@gem_exec_fair@[email protected]
* igt@gem_lmem_swapping@parallel-random:
- shard-skl: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#4613]) +2 similar issues
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-skl1/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][76] ([i915#4613])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-iclb5/igt@[email protected]
* igt@gem_lmem_swapping@random:
- shard-glk: NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#4613])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk4/igt@[email protected]
* igt@gem_lmem_swapping@verify:
- shard-apl: NOTRUN -> [SKIP][78] ([fdo#109271] / [i915#4613])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-apl1/igt@[email protected]
* igt@gem_pwrite@basic-exhaustion:
- shard-skl: NOTRUN -> [WARN][79] ([i915#2658])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-skl8/igt@[email protected]
* igt@gem_pxp@create-regular-context-1:
- shard-tglb: NOTRUN -> [SKIP][80] ([i915#4270])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-tglb7/igt@[email protected]
* igt@gem_render_copy@yf-tiled-mc-ccs-to-vebox-yf-tiled:
- shard-iclb: NOTRUN -> [SKIP][81] ([i915#768]) +2 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-iclb3/igt@[email protected]
* igt@gem_softpin@noreloc-s3:
- shard-apl: [PASS][82] -> [DMESG-WARN][83] ([i915#180]) +1 similar issue
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-apl7/igt@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-apl6/igt@[email protected]
* igt@gem_userptr_blits@create-destroy-unsync:
- shard-tglb: NOTRUN -> [SKIP][84] ([i915#3297])
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-tglb3/igt@[email protected]
- shard-iclb: NOTRUN -> [SKIP][85] ([i915#3297])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-iclb3/igt@[email protected]
* igt@gem_userptr_blits@vma-merge:
- shard-skl: NOTRUN -> [FAIL][86] ([i915#3318])
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-skl6/igt@[email protected]
* igt@gen3_render_tiledy_blits:
- shard-tglb: NOTRUN -> [SKIP][87] ([fdo#109289]) +2 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-tglb3/igt@gen3_render_tiledy_blits.html
- shard-iclb: NOTRUN -> [SKIP][88] ([fdo#109289])
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-iclb3/igt@gen3_render_tiledy_blits.html
* igt@gen9_exec_parse@allowed-single:
- shard-skl: [PASS][89] -> [DMESG-WARN][90] ([i915#1436] / [i915#716])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-skl7/igt@[email protected]
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-skl7/igt@[email protected]
* igt@gen9_exec_parse@secure-batches:
- shard-iclb: NOTRUN -> [SKIP][91] ([i915#2856])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-iclb3/igt@[email protected]
- shard-tglb: NOTRUN -> [SKIP][92] ([i915#2527] / [i915#2856])
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-tglb3/igt@[email protected]
* igt@i915_pm_dc@dc6-dpms:
- shard-skl: NOTRUN -> [FAIL][93] ([i915#454])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-skl6/igt@[email protected]
* igt@i915_pm_rpm@modeset-pc8-residency-stress:
- shard-apl: NOTRUN -> [SKIP][94] ([fdo#109271]) +78 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-apl2/igt@[email protected]
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-tglb: NOTRUN -> [SKIP][95] ([i915#5286])
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-tglb3/igt@[email protected]
* igt@kms_big_fb@x-tiled-8bpp-rotate-90:
- shard-iclb: NOTRUN -> [SKIP][96] ([fdo#110725] / [fdo#111614])
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-iclb5/igt@[email protected]
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip:
- shard-skl: NOTRUN -> [FAIL][97] ([i915#3743])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-skl6/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-180-async-flip.html
* igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip:
- shard-glk: NOTRUN -> [SKIP][98] ([fdo#109271] / [i915#3777])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk4/igt@kms_big_fb@x-tiled-max-hw-stride-64bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip:
- shard-skl: NOTRUN -> [SKIP][99] ([fdo#109271] / [i915#3777]) +2 similar issues
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-skl6/igt@kms_big_fb@y-tiled-max-hw-stride-32bpp-rotate-180-hflip-async-flip.html
* igt@kms_big_fb@yf-tiled-addfb:
- shard-tglb: NOTRUN -> [SKIP][100] ([fdo#111615])
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-tglb3/igt@[email protected]
* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-iclb: NOTRUN -> [SKIP][101] ([fdo#110723])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-iclb3/igt@[email protected]
* igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs_cc:
- shard-glk: NOTRUN -> [SKIP][102] ([fdo#109271] / [i915#3886]) +1 similar issue
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk4/igt@kms_ccs@pipe-a-bad-aux-stride-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-yf_tiled_ccs:
- shard-tglb: NOTRUN -> [SKIP][103] ([fdo#111615] / [i915#3689])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-tglb3/igt@kms_ccs@pipe-a-crc-primary-rotation-180-yf_tiled_ccs.html
* igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs:
- shard-skl: NOTRUN -> [SKIP][104] ([fdo#109271] / [i915#3886]) +11 similar issues
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-skl6/igt@kms_ccs@pipe-b-ccs-on-another-bo-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-apl: NOTRUN -> [SKIP][105] ([fdo#109271] / [i915#3886]) +1 similar issue
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-apl1/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc:
- shard-iclb: NOTRUN -> [SKIP][106] ([fdo#109278] / [i915#3886])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-iclb5/igt@kms_ccs@pipe-c-missing-ccs-buffer-y_tiled_gen12_rc_ccs_cc.html
* igt@kms_chamelium@dp-mode-timings:
- shard-glk: NOTRUN -> [SKIP][107] ([fdo#109271] / [fdo#111827]) +3 similar issues
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk4/igt@[email protected]
* igt@kms_chamelium@hdmi-hpd:
- shard-skl: NOTRUN -> [SKIP][108] ([fdo#109271] / [fdo#111827]) +12 similar issues
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-skl6/igt@[email protected]
* igt@kms_chamelium@vga-frame-dump:
- shard-apl: NOTRUN -> [SKIP][109] ([fdo#109271] / [fdo#111827]) +6 similar issues
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-apl1/igt@[email protected]
* igt@kms_chamelium@vga-hpd-enable-disable-mode:
- shard-iclb: NOTRUN -> [SKIP][110] ([fdo#109284] / [fdo#111827]) +1 similar issue
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-iclb5/igt@[email protected]
* igt@kms_color_chamelium@pipe-a-ctm-0-5:
- shard-kbl: NOTRUN -> [SKIP][111] ([fdo#109271] / [fdo#111827])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-kbl6/igt@[email protected]
* igt@kms_color_chamelium@pipe-c-ctm-red-to-blue:
- shard-tglb: NOTRUN -> [SKIP][112] ([fdo#109284] / [fdo#111827])
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-tglb3/igt@[email protected]
* igt@kms_color_chamelium@pipe-d-ctm-max:
- shard-iclb: NOTRUN -> [SKIP][113] ([fdo#109278] / [fdo#109284] / [fdo#111827])
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-iclb5/igt@[email protected]
* igt@kms_cursor_crc@pipe-a-cursor-512x512-offscreen:
- shard-iclb: NOTRUN -> [SKIP][114] ([fdo#109278] / [fdo#109279]) +2 similar issues
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-iclb3/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-32x10-random:
- shard-kbl: NOTRUN -> [SKIP][115] ([fdo#109271]) +32 similar issues
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-kbl6/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-512x512-rapid-movement:
- shard-tglb: NOTRUN -> [SKIP][116] ([fdo#109279] / [i915#3359]) +1 similar issue
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-tglb3/igt@[email protected]
* igt@kms_cursor_crc@pipe-b-cursor-suspend:
- shard-skl: [PASS][117] -> [INCOMPLETE][118] ([i915#300])
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-skl9/igt@[email protected]
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-skl7/igt@[email protected]
* igt@kms_cursor_crc@pipe-d-cursor-512x512-random:
- shard-iclb: NOTRUN -> [SKIP][119] ([fdo#109278]) +1 similar issue
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-iclb5/igt@[email protected]
* igt@kms_cursor_crc@pipe-d-cursor-max-size-offscreen:
- shard-tglb: NOTRUN -> [SKIP][120] ([i915#3359])
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-tglb7/igt@[email protected]
* igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
- shard-iclb: NOTRUN -> [SKIP][121] ([fdo#109274] / [fdo#109278]) +1 similar issue
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-iclb3/igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic.html
* igt@kms_flip@2x-flip-vs-absolute-wf_vblank:
- shard-tglb: NOTRUN -> [SKIP][122] ([fdo#109274] / [fdo#111825]) +3 similar issues
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-tglb3/igt@kms_flip@2x-flip-vs-absolute-wf_vblank.html
* igt@kms_flip@2x-nonexisting-fb:
- shard-iclb: NOTRUN -> [SKIP][123] ([fdo#109274]) +2 similar issues
[123]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-iclb5/igt@[email protected]
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2:
- shard-glk: [PASS][124] -> [FAIL][125] ([i915#79]) +1 similar issue
[124]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-glk6/igt@kms_flip@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk2/igt@kms_flip@[email protected]
* igt@kms_flip@flip-vs-fences-interruptible@b-vga1:
- shard-snb: [PASS][126] -> [INCOMPLETE][127] ([i915#5000] / [i915#5204])
[126]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-snb7/igt@kms_flip@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-snb5/igt@kms_flip@[email protected]
* igt@kms_flip@plain-flip-ts-check-interruptible@b-edp1:
- shard-skl: [PASS][128] -> [FAIL][129] ([i915#2122])
[128]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-skl1/igt@kms_flip@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-skl10/igt@kms_flip@[email protected]
* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling:
- shard-glk: [PASS][130] -> [FAIL][131] ([i915#4911])
[130]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-glk1/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling.html
[131]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk8/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-32bpp-ytileccs-upscaling.html
* igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling:
- shard-iclb: [PASS][132] -> [SKIP][133] ([i915#3701])
[132]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-iclb3/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling.html
[133]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-iclb2/igt@kms_flip_scaled_crc@flip-32bpp-ytileccs-to-64bpp-ytile-downscaling.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-render:
- shard-iclb: NOTRUN -> [SKIP][134] ([fdo#109280]) +6 similar issues
[134]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-iclb5/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-pri-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-render:
- shard-tglb: NOTRUN -> [SKIP][135] ([fdo#109280] / [fdo#111825]) +9 similar issues
[135]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-spr-indfb-draw-render.html
* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-skl: [PASS][136] -> [INCOMPLETE][137] ([i915#123])
[136]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-skl8/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-skl9/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-alpha-basic:
- shard-glk: NOTRUN -> [FAIL][138] ([fdo#108145] / [i915#265])
[138]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk4/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-alpha-transparent-fb:
- shard-skl: NOTRUN -> [FAIL][139] ([i915#265])
[139]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-skl6/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-apl: NOTRUN -> [FAIL][140] ([fdo#108145] / [i915#265])
[140]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-apl2/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][141] -> [FAIL][142] ([fdo#108145] / [i915#265])
[141]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-skl1/igt@[email protected]
[142]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-skl10/igt@[email protected]
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-skl: NOTRUN -> [FAIL][143] ([fdo#108145] / [i915#265]) +1 similar issue
[143]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-skl6/igt@[email protected]
* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-skl: NOTRUN -> [SKIP][144] ([fdo#109271] / [i915#658]) +1 similar issue
[144]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-skl6/igt@[email protected]
* igt@kms_psr@psr2_primary_mmap_gtt:
- shard-glk: NOTRUN -> [SKIP][145] ([fdo#109271]) +40 similar issues
[145]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk4/igt@kms_psr@psr2_primary_mmap_gtt.html
* igt@kms_psr@psr2_sprite_mmap_gtt:
- shard-iclb: [PASS][146] -> [SKIP][147] ([fdo#109441]) +2 similar issues
[146]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11346/shard-iclb2/igt@kms_psr@psr2_sprite_mmap_gtt.html
[147]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-iclb3/igt@kms_psr@psr2_sprite_mmap_gtt.html
* igt@kms_writeback@writeback-invalid-parameters:
- shard-skl: NOTRUN -> [SKIP][148] ([fdo#109271] / [i915#2437])
[148]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-skl8/igt@[email protected]
* igt@nouveau_crc@pipe-b-ctx-flip-detection:
- shard-tglb: NOTRUN -> [SKIP][149] ([i915#2530]) +1 similar issue
[149]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-tglb7/igt@[email protected]
* igt@prime_nv_api@nv_i915_import_twice_check_flink_name:
- shard-iclb: NOTRUN -> [SKIP][150] ([fdo#109291])
[150]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-iclb5/igt@prime_nv_api@nv_i915_import_twice_check_flink_name.html
* igt@syncobj_timeline@transfer-timeline-point:
- shard-glk: NOTRUN -> [DMESG-FAIL][151] ([i915#5098])
[151]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-glk4/igt@[email protected]
* igt@sysfs_clients@busy:
- shard-skl: NOTRUN -> [SKIP][152] ([fdo#109271] / [i915#2994]) +2 similar issues
[152]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-skl1/igt@[email protected]
* igt@sysfs_clients@fair-0:
- shard-apl: NOTRUN -> [SKIP][153] ([fdo#109271] / [i915#2994]) +1 similar issue
[153]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-apl1/igt@[email protected]
* igt@sysfs_clients@fair-7:
- shard-tglb: NOTRUN -> [SKIP][154] ([i915#2994])
[154]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-tglb3/igt@[email protected]
* igt@sysfs_clients@sema-50:
- shard-iclb: NOTRUN -> [SKIP][155] ([i915#2994]) +1 similar issue
[155]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/shard-iclb5/igt@[email protected]
#### Possible fixes #
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_22524/index.html