PCI: mediatek: Fix refcount leak in mtk_pcie_subsys_powerup
PATCH 1/1 PCI: mediatek: Fix refcount leak in mtk_pcie_subsys_powerup
The of_find_compatible_node() function returns a node pointer with refcount incremented, We should use of_node_put() on it when done Add the missing of_node_put() to release the refcount.
--- drivers/pci/controller/pcie-mediatek.c | 1 + 1 file changed, 1 insertion(+)
drivers/pci/controller/pcie-mediatek.c +1 -0
@@ -1008,6 +1008,7 @@ static int mtk_pcie_subsys_powerup(struct mtk_pcie *pcie) "mediatek,generic-pciecfg");if (cfg_node) { pcie->cfg =syscon_node_to_regmap (cfg_node); +of_node_put (cfg_node);if (IS_ERR (pcie->cfg))return PTR_ERR (pcie->cfg); }
Signature · 1 line
2.17.1
Hi Miaoqian,
Quoted 15 lines
The
of_find_compatible_node()function returns a node pointer with refcount incremented, We should useof_node_put()on it when done Add the missingof_node_put()to release the refcount.Fixes 87e8657ba99c ("PCI: mediatek: Add new method to get shared pcie-cfg base address")Signed-off-by Miaoqian Lin <[email protected]>--- drivers/pci/controller/pcie-mediatek.c | 1 + 1 file changed, 1 insertion(+)drivers/pci/controller/pcie-mediatek.c +0
-0
drivers/pci/controller/pcie-mediatek.c static int mtk_pcie_subsys_powerup(struct mtk_pcie *pcie) · line 1014
Quoted 7 lines
drivers/pci/controller/pcie-mediatek.c +1
-0@@ -1008,6 +1008,7 @@ static int mtk_pcie_subsys_powerup(struct mtk_pcie *pcie) "mediatek,generic-pciecfg");if (cfg_node) { pcie->cfg =syscon_node_to_regmap (cfg_node); +of_node_put (cfg_node);if (IS_ERR (pcie->cfg))return PTR_ERR (pcie->cfg); }
Thanks for this patch.
Thanks,
Miles
Il 09/03/22 10:19, Miaoqian Lin ha scritto:
Quoted 7 lines
The
of_find_compatible_node()function returns a node pointer with refcount incremented, We should useof_node_put()on it when done Add the missingof_node_put()to release the refcount.Fixes 87e8657ba99c ("PCI: mediatek: Add new method to get shared pcie-cfg base address")Signed-off-by Miaoqian Lin <[email protected]>Reviewed-by Miles Chen <[email protected]>
Quoted 10 lines
--- drivers/pci/controller/pcie-mediatek.c | 1 + 1 file changed, 1 insertion(+)drivers/pci/controller/pcie-mediatek.c +0
-0
drivers/pci/controller/pcie-mediatek.c static int mtk_pcie_subsys_powerup(struct mtk_pcie *pcie) · line 1014
Quoted 7 lines
drivers/pci/controller/pcie-mediatek.c +1
-0@@ -1008,6 +1008,7 @@ static int mtk_pcie_subsys_powerup(struct mtk_pcie *pcie) "mediatek,generic-pciecfg");if (cfg_node) { pcie->cfg =syscon_node_to_regmap (cfg_node); +of_node_put (cfg_node);if (IS_ERR (pcie->cfg))return PTR_ERR (pcie->cfg); }
_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek
Quoted 9 lines · Miaoqian Lin
The
of_find_compatible_node()function returns a node pointer with refcount incremented, We should useof_node_put()on it when done Add the missingof_node_put()to release the refcount.Fixes 87e8657ba99c ("PCI: mediatek: Add new method to get shared pcie-cfg base address")Signed-off-by Miaoqian Lin <[email protected]>--- drivers/pci/controller/pcie-mediatek.c | 1 + 1 file changed, 1 insertion(+)
Lorenzo Pieralisi
AppliedQuoted 5 lines · Miaoqian Lin
The
of_find_compatible_node()function returns a node pointer with refcount incremented, We should useof_node_put()on it when done Add the missingof_node_put()to release the refcount.
Applied to pci/mediatek, thanks!
[1/1] PCI: mediatek: Fix refcount leak in mtk_pcie_subsys_powerup
https://git.kernel.org/lpieralisi/pci/c/214e0d8fe4
Thanks,
Lorenzo