imx8m{m,n}_venice: update env memory layout
PATCH 1/1 imx8m{m,n}_venice: update env memory layout
Update distro config env memory layout:
- loadaddr=0x48200000 allows for 130MB area for uncompressing (ie FIT images, kernel_comp_addr_r)
- fdt_addr_r = loadaddr + 128MB - allows for 128MB kernel
- scriptaddr = fdt_addr_r + 512KB - allows for 512KB fdt
- ramdisk_addr_r = scriptaddr + 512KB - allows for 512KB script
--- configs/imx8mm_venice_defconfig | 2 +- configs/imx8mn_venice_defconfig | 2 +- include/configs/imx8mm_venice.h | 9 +++++---- include/configs/imx8mn_venice.h | 9 +++++---- 4 files changed, 12 insertions(+), 10 deletions(-)
configs/imx8mm_venice_defconfig +1 -1
@@ -21,7 +21,7 @@ CONFIG_SPL=y CONFIG_ENV_OFFSET_REDUND=0xff8000 CONFIG_LTO=y CONFIG_DISTRO_DEFAULTS=y -CONFIG_SYS_LOAD_ADDR=0x40480000 +CONFIG_SYS_LOAD_ADDR=0x48200000 CONFIG_FIT=y CONFIG_FIT_EXTERNAL_OFFSET=0x3000 CONFIG_SPL_LOAD_FIT=y
configs/imx8mn_venice_defconfig +1 -1
@@ -21,7 +21,7 @@ CONFIG_ENV_OFFSET_REDUND=0xff8000 CONFIG_SPL_IMX_ROMAPI_LOADADDR=0x48000000 CONFIG_LTO=y CONFIG_DISTRO_DEFAULTS=y -CONFIG_SYS_LOAD_ADDR=0x40480000 +CONFIG_SYS_LOAD_ADDR=0x48200000 CONFIG_FIT=y CONFIG_FIT_EXTERNAL_OFFSET=0x3000 CONFIG_SPL_LOAD_FIT=y
include/configs/imx8mm_venice.h +5 -4
@@ -29,10 +29,11 @@#endif #define MEM_LAYOUT_ENV_SETTINGS \ - "fdt_addr_r=0x44000000\0" \ - "kernel_addr_r=0x42000000\0" \ - "ramdisk_addr_r=0x46400000\0" \ - "scriptaddr=0x46000000\0" + "kernel_addr_r=" __stringify(CONFIG_SYS_LOAD_ADDR) "\0" \ + "fdt_addr_r=0x50200000\0" \ + "scriptaddr=0x50280000\0" \ + "ramdisk_addr_r=0x50300000\0" \ + "kernel_comp_addr_r=0x40200000\0"/* Enable Distro Boot */ #ifndef CONFIG_SPL_BUILD
include/configs/imx8mn_venice.h +5 -4
@@ -26,10 +26,11 @@#endif #define MEM_LAYOUT_ENV_SETTINGS \ - "fdt_addr_r=0x44000000\0" \ - "kernel_addr_r=0x42000000\0" \ - "ramdisk_addr_r=0x46400000\0" \ - "scriptaddr=0x46000000\0" + "kernel_addr_r=" __stringify(CONFIG_SYS_LOAD_ADDR) "\0" \ + "fdt_addr_r=0x50200000\0" \ + "scriptaddr=0x50280000\0" \ + "ramdisk_addr_r=0x50300000\0" \ + "kernel_comp_addr_r=0x40200000\0"/* Enable Distro Boot */ #ifndef CONFIG_SPL_BUILD
Signature · 1 line
2.17.1
Fabio Estevam
reviewerHi Tim,
Quoted 9 lines · Tim Harvey
Update distro config env memory layout:
- loadaddr=0x48200000 allows for 130MB area for uncompressing (ie FIT images,kernel_comp_addr_r)
-fdt_addr_r= loadaddr + 128MB - allows for 128MB kernel
- scriptaddr =fdt_addr_r+ 512KB - allows for 512KB fdt
-ramdisk_addr_r= scriptaddr + 512KB - allows for 512KB scriptSigned-off-by Tim Harvey <[email protected]>
What about following the suggestion from Heiko at:
https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/
Quoted 12 lines · Fabio Estevam
Hi Tim,
Quoted 8 lines · Tim Harvey
Update distro config env memory layout:
- loadaddr=0x48200000 allows for 130MB area for uncompressing (ie FIT images,kernel_comp_addr_r)
-fdt_addr_r= loadaddr + 128MB - allows for 128MB kernel
- scriptaddr =fdt_addr_r+ 512KB - allows for 512KB fdt
-ramdisk_addr_r= scriptaddr + 512KB - allows for 512KB script
Quoted 4 lines
Quoted 1 line
Signed-off-by Tim Harvey <[email protected]>What about following the suggestion from Heiko at:
https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/
Fabio,
I don't understand why include/configs/ti_armv7_common.h is always recommended when it comes to address maps. The comment there doesn't read that well and there are several addresses that I believe are outdated or uncommon (fdtaddr,rdaddr are outdated and it seems loadaddr could be used for dtboaddr)
In my opinion what is relevant when choosing an addressing scheme is how much space you want to allow for kernel, fdt, scripts, ramdisk.
ti_armv7_common.h allows for
kernel/loadaddr:96M (too small in my opinion on modern boards) fdt:512M (makes sense)
script:32M (excessive, and I don't understand why this is below loadaddr vs stacked on top of loadaddr like fdt)
ramdisk: depends on mem size as its the highest addr (makes sense)
For my more modern boards with typically 1-4GiB of dram, I wanted to allow for more than 96M for a kernel (kernel+ramdisk, fit image etc) as I commonly exceed 96M when using a buildroot kernel+rootfs that has something like gstreamer support for imx6/imx8 which is why I came up with a different scheme which I document well in the commit log as
- loadaddr=0x48200000 allows for 130MB area for uncompressing (ie FIT images, kernel_comp_addr_r)
- fdt_addr_r = loadaddr + 128MB - allows for 128MB kernel
- scriptaddr = fdt_addr_r + 512KB - allows for 512KB fdt
- ramdisk_addr_r = scriptaddr + 512KB - allows for 512KB script
I must admit I'm not clear what the best choice of CONFIG_SYS_LOAD_ADDR is for IMX8MM which is what all these addresses should stack on top of.
I also will admit that defining them as hard coded addresses makes it difficult to see the sizes of each. It would be better if we had a way to define them referencing a size and what they stack on top of but I'm not clear how to do this with the C pre-processor.
Best Regards,
Tim
Hi Tim,
[Adding Tom on Cc]
Quoted 37 lines · Tim Harvey
Quoted 12 lines · Fabio Estevam
Hi Tim,
Quoted 8 lines · Tim Harvey
Update distro config env memory layout:
- loadaddr=0x48200000 allows for 130MB area for uncompressing (ie FIT images,kernel_comp_addr_r)
-fdt_addr_r= loadaddr + 128MB - allows for 128MB kernel
- scriptaddr =fdt_addr_r+ 512KB - allows for 512KB fdt
-ramdisk_addr_r= scriptaddr + 512KB - allows for 512KB scriptQuoted 4 lines
Quoted 1 line
Signed-off-by Tim Harvey <[email protected]>What about following the suggestion from Heiko at:
https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/Fabio,
I don't understand why
include/configs/ti_armv7_common.his always recommended when it comes to address maps. The comment there doesn't read that well and there are several addresses that I believe are outdated or uncommon (fdtaddr,rdaddr are outdated and it seems loadaddr could be used for dtboaddr)In my opinion what is relevant when choosing an addressing scheme is how much space you want to allow for kernel, fdt, scripts, ramdisk.
ti_armv7_common.hallows for
kernel/loadaddr:96M (too small in my opinion on modern boards) fdt:512M (makes sense)
script:32M (excessive, and I don't understand why this is below loadaddr vs stacked on top of loadaddr like fdt)
ramdisk: depends on mem size as its the highest addr (makes sense)
Quoted 10 lines
For my more modern boards with typically 1-4GiB of dram, I wanted to allow for more than 96M for a kernel (kernel+ramdisk, fit image etc) as I commonly exceed 96M when using a buildroot kernel+rootfs that has something like gstreamer support for imx6/imx8 which is why I came up with a different scheme which I document well in the commit log as
- loadaddr=0x48200000 allows for 130MB area for uncompressing (ie FIT images,kernel_comp_addr_r)
-fdt_addr_r= loadaddr + 128MB - allows for 128MB kernel
- scriptaddr =fdt_addr_r+ 512KB - allows for 512KB fdt
-ramdisk_addr_r= scriptaddr + 512KB - allows for 512KB script
You bring good points and maybe we could use include/configs/imx8mm_venice.h as a good standard to follow :-)
Quoted 54 lines · Fabio Estevam
Hi Tim,
[Adding Tom on Cc]
Quoted 37 lines · Tim Harvey
Quoted 12 lines · Fabio Estevam
Hi Tim,
Quoted 8 lines · Tim Harvey
Update distro config env memory layout:
- loadaddr=0x48200000 allows for 130MB area for uncompressing (ie FIT images,kernel_comp_addr_r)
-fdt_addr_r= loadaddr + 128MB - allows for 128MB kernel
- scriptaddr =fdt_addr_r+ 512KB - allows for 512KB fdt
-ramdisk_addr_r= scriptaddr + 512KB - allows for 512KB scriptQuoted 4 lines
Quoted 1 line
Signed-off-by Tim Harvey <[email protected]>What about following the suggestion from Heiko at:
https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/Fabio,
I don't understand why
include/configs/ti_armv7_common.his always recommended when it comes to address maps. The comment there doesn't read that well and there are several addresses that I believe are outdated or uncommon (fdtaddr,rdaddr are outdated and it seems loadaddr could be used for dtboaddr)In my opinion what is relevant when choosing an addressing scheme is how much space you want to allow for kernel, fdt, scripts, ramdisk.
ti_armv7_common.hallows for
kernel/loadaddr:96M (too small in my opinion on modern boards) fdt:512M (makes sense)
script:32M (excessive, and I don't understand why this is below loadaddr vs stacked on top of loadaddr like fdt)
ramdisk: depends on mem size as its the highest addr (makes sense)Quoted 10 lines
For my more modern boards with typically 1-4GiB of dram, I wanted to allow for more than 96M for a kernel (kernel+ramdisk, fit image etc) as I commonly exceed 96M when using a buildroot kernel+rootfs that has something like gstreamer support for imx6/imx8 which is why I came up with a different scheme which I document well in the commit log as
- loadaddr=0x48200000 allows for 130MB area for uncompressing (ie FIT images,kernel_comp_addr_r)
-fdt_addr_r= loadaddr + 128MB - allows for 128MB kernel
- scriptaddr =fdt_addr_r+ 512KB - allows for 512KB fdt
-ramdisk_addr_r= scriptaddr + 512KB - allows for 512KB script
Quoted 4 lines
You bring good points and maybe we could use
include/configs/imx8mm_venice.has a good standard to follow :-)Reviewed-by Fabio Estevam <[email protected]>
Tom,
DId you have any feedback on this conversation about memory addresses? I'm also wondering if anyone knows how we can define them to make it a bit clearer about their sizes (some sort of macro foo that allows us to defined them as sizes on top of a previous address).
Best regards,
Tim
Quoted 58 lines · Tim Harvey
Quoted 57 lines · Fabio Estevam
Hi Tim,
[Adding Tom on Cc]
Quoted 37 lines · Tim Harvey
Quoted 12 lines · Fabio Estevam
Hi Tim,
Quoted 8 lines · Tim Harvey
Update distro config env memory layout:
- loadaddr=0x48200000 allows for 130MB area for uncompressing (ie FIT images,kernel_comp_addr_r)
-fdt_addr_r= loadaddr + 128MB - allows for 128MB kernel
- scriptaddr =fdt_addr_r+ 512KB - allows for 512KB fdt
-ramdisk_addr_r= scriptaddr + 512KB - allows for 512KB scriptQuoted 4 lines
Quoted 1 line
Signed-off-by Tim Harvey <[email protected]>What about following the suggestion from Heiko at:
https://patchwork.ozlabs.org/project/uboot/patch/[email protected]/Fabio,
I don't understand why
include/configs/ti_armv7_common.his always recommended when it comes to address maps. The comment there doesn't read that well and there are several addresses that I believe are outdated or uncommon (fdtaddr,rdaddr are outdated and it seems loadaddr could be used for dtboaddr)In my opinion what is relevant when choosing an addressing scheme is how much space you want to allow for kernel, fdt, scripts, ramdisk.
ti_armv7_common.hallows for
kernel/loadaddr:96M (too small in my opinion on modern boards) fdt:512M (makes sense)
script:32M (excessive, and I don't understand why this is below loadaddr vs stacked on top of loadaddr like fdt)
ramdisk: depends on mem size as its the highest addr (makes sense)Quoted 10 lines
For my more modern boards with typically 1-4GiB of dram, I wanted to allow for more than 96M for a kernel (kernel+ramdisk, fit image etc) as I commonly exceed 96M when using a buildroot kernel+rootfs that has something like gstreamer support for imx6/imx8 which is why I came up with a different scheme which I document well in the commit log as
- loadaddr=0x48200000 allows for 130MB area for uncompressing (ie FIT images,kernel_comp_addr_r)
-fdt_addr_r= loadaddr + 128MB - allows for 128MB kernel
- scriptaddr =fdt_addr_r+ 512KB - allows for 512KB fdt
-ramdisk_addr_r= scriptaddr + 512KB - allows for 512KB scriptYou bring good points and maybe we could use
include/configs/imx8mm_venice.has a good standard to follow :-)
Quoted 8 lines
Quoted 1 line
Reviewed-by Fabio Estevam <[email protected]>Tom,
DId you have any feedback on this conversation about memory addresses? I'm also wondering if anyone knows how we can define them to make it a bit clearer about their sizes (some sort of macro foo that allows us to defined them as sizes on top of a previous address).
Alright, so, yeah, at this point it's true that ti_armv7_common.h could use some re-evaluation since it's been a while. What's probably the best path forward is something under doc/develop/ that explains what the important environment variables are, general max sizes and links to where those constraints come from and then an example or two. Especially since 32 and 64bit ARM have some different constraints (I want to say that the 96MB kernel size was a practical limitation, but would need to re-read the kernel docs and maybe check some notes again).
Signature · 1 line
Tom