arm64: dts: rockchip: add basic dts for the radxa rock3 model a
Subsystems (2)
v2 cover arm64: dts: rockchip: add basic dts for the radxa rock3 model a
Hi all,
This series introduces basic support for the Radxa ROCK3 Model A featuring the Rockchip RK3568 SoC. The basic support includes Ethernet, USB2 and the headphone connector.
Patch 3 adds support for the Video Output Processor (VOP) 2 and the HDMI output. It requires the VOP2/HDMI TX patches (which are discussed on the list) and can be considered as RFC.
v2 adds the missing entry in the Makefile and Rob's Acked-by: on the dt-bindings patch.
Looking forward to your comments!
Best regards,
Michael
Michael Riesch (3):
dt-bindings: arm: rockchip: add radxa rock3 model a
arm64: dts: rockchip: add basic dts for the radxa rock3 model a
arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a
.../devicetree/bindings/arm/rockchip.yaml | 5 + arch/arm64/boot/dts/rockchip/Makefile | 1 + .../boot/dts/rockchip/rk3568-rock-3a.dts | 548 ++++++++++++++++++ 3 files changed, 554 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
Signature · 1 line
2.30.2
PATCH v2 1/3 dt-bindings: arm: rockchip: add radxa rock3 model a
Add entry for the Radxa ROCK3 Model A board (with the Rockchip RK3568 SoC).
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +5 -0
@@ -537,6 +537,11 @@ properties: - const: radxa,rock2-square - const: rockchip,rk3288 + - description: Radxa ROCK3 Model A + items: + - const: radxa,rock3a + - const: rockchip,rk3568 + - description: Rikomagic MK808 v1 items: - const: rikomagic,mk808
Signature · 1 line
2.30.2
PATCH v2 2/3 arm64: dts: rockchip: add basic dts for the radxa rock3 model a
In reply to Michael RieschAdd basic device tree for the Radxa ROCK3 Model A board (with the Rockchip RK3568 SoC) including Ethernet, USB2 and headphone connector.
--- arch/arm64/boot/dts/rockchip/Makefile | 1 + .../boot/dts/rockchip/rk3568-rock-3a.dts | 501 ++++++++++++++++++ 2 files changed, 502 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
arch/arm64/boot/dts/rockchip/Makefile +1 -0
@@ -58,3 +58,4 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-sapphire-excavator.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399pro-rock-pi-n10.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-quartz64-a.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-rock-3a.dtb
arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts new file +501 -0
501 lines not on this page · raw message
Signature · 1 line
2.30.2
kernel test robot
build botThank you for the patch! Yet something to improve:
Hi Michael,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on robh/for-next]
[also build test ERROR on arm/for-next xilinx-xlnx/master arm64/for-next/core shawnguo/for-next clk/clk-next kvmarm/next keystone/next v5.17-rc7] [cannot apply to rockchip/for-next soc/for-next next-20220310]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Michael-Riesch/arm64-dts-rockchip-add-basic-dts-for-the-radxa-rock3-model-a/20220311-050612 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: arm64-buildonly-randconfig-r002-20220310 (https://download.01.org/0day-ci/archive/20220312/[email protected]/config) compiler: aarch64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/8d0dad8b66056847b8a2e95272ee74ca4b12fd29
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Michael-Riesch/arm64-dts-rockchip-add-basic-dts-for-the-radxa-rock3-model-a/20220311-050612 git checkout 8d0dad8b66056847b8a2e95272ee74ca4b12fd29
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Note: the linux-review/Michael-Riesch/arm64-dts-rockchip-add-basic-dts-for-the-radxa-rock3-model-a/20220311-050612 HEAD c217f194b7a9cbdb7cbb8149ae1f6e8c2faf6e3f builds fine.
It only hurts bisectability.
All errors (new ones prefixed by >>):
>> Error: arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts:132.1-5 Label or path gpu not found >> Error: arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts:473.1-16 Label or path usb_host0_ehci not found >> Error: arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts:477.1-16 Label or path usb_host0_ohci not found >> Error: arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts:481.1-16 Label or path usb_host1_ehci not found >> Error: arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts:485.1-16 Label or path usb_host1_ohci not found >> Error: arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts:489.1-10 Label or path usb2phy1 not found >> Error: arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts:493.1-15 Label or path usb2phy1_host not found >> Error: arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts:498.1-14 Label or path usb2phy1_otg not found >> FATAL ERROR: Syntax error parsing input tree
---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/[email protected]
_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
PATCH v2 3/3 arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a
In reply to Michael RieschEnable the RK356x Video Output Processor (VOP) 2 on the Radxa ROCK3 Model A.
--- .../boot/dts/rockchip/rk3568-rock-3a.dts | 47 +++++++++++++++++++ 1 file changed, 47 insertions(+)
arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts +47 -0
@@ -4,6 +4,7 @@ #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/leds/common.h> #include <dt-bindings/pinctrl/rockchip.h> +#include <dt-bindings/soc/rockchip,vop2.h> #include "rk3568.dtsi" / {
@@ -20,6 +21,17 @@ chosen: chosen { stdout-path = "serial2:1500000n8"; }; + hdmi-con { + compatible = "hdmi-connector"; + type = "a"; + + port { + hdmi_con_in: endpoint { + remote-endpoint = <&hdmi_out_con>; + }; + }; + }; + leds { compatible = "gpio-leds";
@@ -134,6 +146,24 @@ &gpu { status = "okay"; }; +&hdmi { + avdd-0v9-supply = <&vdda0v9_image>; + avdd-1v8-supply = <&vcca1v8_image>; + status = "okay"; +}; + +&hdmi_in { + hdmi_in_vp0: endpoint { + remote-endpoint = <&vp0_out_hdmi>; + }; +}; + +&hdmi_out { + hdmi_out_con: endpoint { + remote-endpoint = <&hdmi_con_in>; + }; +}; + &i2c0 { status = "okay";
@@ -499,3 +529,20 @@ &usb2phy1_otg { phy-supply = <&vcc5v0_usb_host>; status = "okay"; }; + +&vop { + assigned-clocks = <&cru DCLK_VOP0>, <&cru DCLK_VOP1>; + assigned-clock-parents = <&pmucru PLL_HPLL>, <&cru PLL_VPLL>; + status = "okay"; +}; + +&vop_mmu { + status = "okay"; +}; + +&vp0 { + vp0_out_hdmi: endpoint@ROCKCHIP_VOP2_EP_HDMI0 { + reg = <ROCKCHIP_VOP2_EP_HDMI0>; + remote-endpoint = <&hdmi_in_vp0>; + }; +};
Signature · 1 line
2.30.2
kernel test robot
build botRe: [PATCH v2 3/3] arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a
Thank you for the patch! Yet something to improve:
Hi Michael,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on robh/for-next]
[also build test ERROR on arm/for-next xilinx-xlnx/master arm64/for-next/core shawnguo/for-next clk/clk-next kvmarm/next v5.17-rc7] [cannot apply to rockchip/for-next soc/for-next next-20220310]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Michael-Riesch/arm64-dts-rockchip-add-basic-dts-for-the-radxa-rock3-model-a/20220311-050612 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: arm64-buildonly-randconfig-r002-20220310 (https://download.01.org/0day-ci/archive/20220311/[email protected]/config) compiler: aarch64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/c217f194b7a9cbdb7cbb8149ae1f6e8c2faf6e3f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Michael-Riesch/arm64-dts-rockchip-add-basic-dts-for-the-radxa-rock3-model-a/20220311-050612 git checkout c217f194b7a9cbdb7cbb8149ae1f6e8c2faf6e3f
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
All errors (new ones prefixed by >>):
>> arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts:7:10: fatal error: dt-bindings/soc/rockchip,vop2.h: No such file or directory
7 | #include <dt-bindings/soc/rockchip,vop2.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
vim +7 arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
2
3 /dts-v1/;
4 #include <dt-bindings/gpio/gpio.h>
5 #include <dt-bindings/leds/common.h>
6 #include <dt-bindings/pinctrl/rockchip.h>
> 7 #include <dt-bindings/soc/rockchip,vop2.h>
8 #include "rk3568.dtsi"
9 ---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/[email protected]
kernel test robot
build botRe: [PATCH v2 3/3] arm64: dts: rockchip: enable vop2 and hdmi tx on rock-3a
In reply to Michael RieschThank you for the patch! Yet something to improve:
Hi Michael,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on robh/for-next]
[also build test ERROR on arm/for-next xilinx-xlnx/master arm64/for-next/core shawnguo/for-next clk/clk-next kvmarm/next keystone/next v5.17-rc7] [cannot apply to rockchip/for-next soc/for-next next-20220310]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Michael-Riesch/arm64-dts-rockchip-add-basic-dts-for-the-radxa-rock3-model-a/20220311-050612 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: arm64-randconfig-r014-20220310 (https://download.01.org/0day-ci/archive/20220312/[email protected]/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 276ca87382b8f16a65bddac700202924228982f6)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/c217f194b7a9cbdb7cbb8149ae1f6e8c2faf6e3f
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Michael-Riesch/arm64-dts-rockchip-add-basic-dts-for-the-radxa-rock3-model-a/20220311-050612 git checkout c217f194b7a9cbdb7cbb8149ae1f6e8c2faf6e3f
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
All errors (new ones prefixed by >>):
>> arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts:7:10: fatal error: 'dt-bindings/soc/rockchip,vop2.h' file not found
#include <dt-bindings/soc/rockchip,vop2.h>
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~1 error generated.
vim +7 arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dts
2
3 /dts-v1/;
4 #include <dt-bindings/gpio/gpio.h>
5 #include <dt-bindings/leds/common.h>
6 #include <dt-bindings/pinctrl/rockchip.h>
> 7 #include <dt-bindings/soc/rockchip,vop2.h>
8 #include "rk3568.dtsi"
9 ---
0-DAY CI Kernel Test Service
https://lists.01.org/hyperkitty/list/[email protected]
Heiko Stuebner
maintainerRe: [PATCH v2 0/3] (partial) arm64: dts: rockchip: add basic dts for the radxa rock3 model a
In reply to Michael RieschQuoted 9 lines · Michael Riesch
This series introduces basic support for the Radxa ROCK3 Model A featuring the Rockchip RK3568 SoC. The basic support includes Ethernet, USB2 and the headphone connector.
Patch 3 adds support for the Video Output Processor (VOP) 2 and the HDMI output. It requires the VOP2/HDMI TX patches (which are discussed on the list) and can be considered as RFC.
[...]
(partial) Applied, thanks!
[1/3] dt-bindings: arm: rockchip: add radxa rock3 model a
commit: 65a31b5abb7f4c373ce0de52eca75348156c87d2
[2/3] arm64: dts: rockchip: add basic dts for the radxa rock3 model a
commit: 056ef970c434a572f81eae199846bf3f521a8303Best regards,
Signature · 1 line
Heiko Stuebner <[email protected]>