Skip to contentSkip to conversation

x86/cpu: Add a third Alderlake CPU model number

PATCH In review Tony Luck 4 participants 7 messages Mar 10, 2022 – Apr 19, 2022

Subsystems (2)
lore
Share & tools
lore

Tony Luck

author maintainer
#0 lore raw

PATCH 1/1 x86/cpu: Add a third Alderlake CPU model number

Existing suffix conventions only cover mobile/desktop/server options. But this isn't any of those. Use "_N" as it matches the Intel naming convention for this part.

---

Peter: What do you think about suffix proliferation? I tried to get an answer about the target market segment for this CPU, but didn't get an answer that is at all useful.

 arch/x86/include/asm/intel-family.h | 1 +
 1 file changed, 1 insertion(+)
arch/x86/include/asm/intel-family.h +1 -0
index 048b6d5aff50..2f7b608f3e55 100644
@@ -107,6 +107,7 @@
 
 #define INTEL_FAM6_ALDERLAKE		0x97	/* Golden Cove / Gracemont */
 #define INTEL_FAM6_ALDERLAKE_L		0x9A	/* Golden Cove / Gracemont */
+#define INTEL_FAM6_ALDERLAKE_N		0xBE
 
 #define INTEL_FAM6_RAPTORLAKE		0xB7
 
Signature · 1 line
2.35.1
#1 lore raw
Quoted 10 lines · Tony Luck

Existing suffix conventions only cover mobile/desktop/server options. But this isn't any of those. Use "_N" as it matches the Intel naming convention for this part.

---

Peter: What do you think about suffix proliferation? I tried to get an answer about the target market segment for this CPU, but didn't get an answer that is at all useful.

I'm not loving it, but seeing how they keep making these things into model numbers (instead of using a different differentiator), there's little we can do about it :-(

arch/x86/include/asm/intel-family.h line 110

Quoted 12 lines
 arch/x86/include/asm/intel-family.h | 1 +
 1 file changed, 1 insertion(+)
arch/x86/include/asm/intel-family.h +1 -0
index 048b6d5aff50..2f7b608f3e55 100644
@@ -107,6 +107,7 @@
 
 #define INTEL_FAM6_ALDERLAKE		0x97	/* Golden Cove / Gracemont */
 #define INTEL_FAM6_ALDERLAKE_L		0x9A	/* Golden Cove / Gracemont */
+#define INTEL_FAM6_ALDERLAKE_N		0xBE

This is missing the /* Gracemont */ comment. That is, according to Google, Alder Lake N is an E core only SKU. So alternatively, we can call it: INTEL_FAM6_ATOM_GRACEMONT ....

/me runs like heck :-)

arch/x86/include/asm/intel-family.h line 112

Quoted 1 line
arch/x86/include/asm/intel-family.h +0 -0
 #define INTEL_FAM6_RAPTORLAKE		0xB7

That too is missing the comment, but I can't actually find what it should be on wikichip so I suppose that's still sekrit or something.

author maintainer
#2 lore raw
Quoted 4 lines
Quoted 1 line

+#define INTEL_FAM6_ALDERLAKE_N 0xBE

This is missing the /* Gracemont */ comment. That is, according to Google, Alder Lake N is an E core only SKU.

I can neither confirm nor deny that information.

Quoted 4 lines

So alternatively, we can
call it: INTEL_FAM6_ATOM_GRACEMONT ....

/me runs like heck :-)

And so you should :-) I think that will just cause a different level of confusion.

-Tony

author maintainer
#3 lore raw

PATCH 1/1 x86/cpu: Add new Alderlake and Raptorlake CPU model numbers

Intel is subdividing the mobile segment with additional models with the same codename. Using the Intel "N" and "P" suffices for these will be less confusing than trying to map to some different naming convention.

---

I think the earlier patch for Alderlake "N" got stuck in limbo trying to resolve whether we should add the "_N" suffix to our list of acceptable CPU model #define names. Now we have another one "_P".

Can we just take these, and move on?

 arch/x86/include/asm/intel-family.h | 3 +++
 1 file changed, 3 insertions(+)
arch/x86/include/asm/intel-family.h +3 -0
index 048b6d5aff50..def6ca121111 100644
@@ -26,6 +26,7 @@
  *		_G	- parts with extra graphics on
  *		_X	- regular server parts
  *		_D	- micro server parts
+ *		_N,_P	- other mobile parts
  *
  *		Historical OPTDIFFs:
  *
@@ -107,8 +108,10 @@
 
 #define INTEL_FAM6_ALDERLAKE		0x97	/* Golden Cove / Gracemont */
 #define INTEL_FAM6_ALDERLAKE_L		0x9A	/* Golden Cove / Gracemont */
+#define INTEL_FAM6_ALDERLAKE_N		0xBE
 
 #define INTEL_FAM6_RAPTORLAKE		0xB7
+#define INTEL_FAM6_RAPTORLAKE_P		0xBA
 
 /* "Small Core" Processors (Atom) */
 
Signature · 1 line
2.35.1
Acked-by on v1 1/1
#4 lore raw

Re: [PATCH] x86/cpu: Add new Alderlake and Raptorlake CPU model numbers

Quoted 5 lines · Tony

Intel is subdividing the mobile segment with additional models with the same codename. Using the Intel "N" and "P" suffices for these will be less confusing than trying to map to some different naming convention.

Quoted 8 lines

---

I think the earlier patch for Alderlake "N" got stuck in limbo trying to resolve whether we should add the "_N" suffix to our list of acceptable CPU model #define names. Now we have another one "_P".

Can we just take these, and move on?

Yeah, I suppose so.

Let's hope our marketing team will stick with these names for a little while atleast :/

maintainer
#5 lore raw

Re: [PATCH] x86/cpu: Add new Alderlake and Raptorlake CPU model numbers

Quoted 2 lines · Peter Zijlstra

Let's hope our marketing team will stick with these names for a little while atleast :/

I'm waiting for the day when they run out of lakes and we and up doing

#define INTEL_FAM6_LAKELAKE 0xff

:-P

Signature · 4 lines
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette
merge bot Applied
#6 lore raw

[tip: x86/urgent] x86/cpu: Add new Alderlake and Raptorlake CPU model numbers

In reply to Luck, Tony
The following commit has been merged into the x86/urgent branch of tip:

The following commit has been merged into the x86/urgent branch of tip:

Commit-ID:     3ccce9340326df40ba4462d4d2a1692b6387a68e
Gitweb:        https://git.kernel.org/tip/3ccce9340326df40ba4462d4d2a1692b6387a68e
Author:        Tony Luck <[email protected]>
AuthorDate:    Mon, 11 Apr 2022 16:37:03 -07:00
Committer:     Borislav Petkov <[email protected]>
CommitterDate: Tue, 19 Apr 2022 12:04:51 +02:00

x86/cpu: Add new Alderlake and Raptorlake CPU model numbers

Intel is subdividing the mobile segment with additional models with the same codename. Using the Intel "N" and "P" suffices for these will be less confusing than trying to map to some different naming convention.

---
 arch/x86/include/asm/intel-family.h | 3 +++
 1 file changed, 3 insertions(+)
arch/x86/include/asm/intel-family.h +3 -0
index 048b6d5..def6ca1 100644
@@ -26,6 +26,7 @@
  *		_G	- parts with extra graphics on
  *		_X	- regular server parts
  *		_D	- micro server parts
+ *		_N,_P	- other mobile parts
  *
  *		Historical OPTDIFFs:
  *
@@ -107,8 +108,10 @@
 
 #define INTEL_FAM6_ALDERLAKE		0x97	/* Golden Cove / Gracemont */
 #define INTEL_FAM6_ALDERLAKE_L		0x9A	/* Golden Cove / Gracemont */
+#define INTEL_FAM6_ALDERLAKE_N		0xBE
 
 #define INTEL_FAM6_RAPTORLAKE		0xB7
+#define INTEL_FAM6_RAPTORLAKE_P		0xBA
 
 /* "Small Core" Processors (Atom) */