serial: 8250_fintek.c: Clean up set_termios() message
PATCH 3/3 serial: 8250_fintek.c: Clean up set_termios() message
Clean up the status message that is given in the case where a custom termios() is not installed.
--- drivers/tty/serial/8250/8250_fintek.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/tty/serial/8250/8250_fintek.c +1 -1
@@ -333,7 +333,7 @@ static void fintek_8250_set_termios(struct uart_port *port,default :/* Don't change clocksource with unknown PID */ dev_warn (port->dev, -"%s: pid: %x Not support. use default set_termios.\n" , +"%s: chipID: %x not supported; using default set_termios.\n" , __func__, pdata->pid); goto exit; }
Signature · 1 line
2.34.1.75.gabe6bb3905
Jiri Slaby
maintainerQuoted 13 lines · Trevor Woerner
Clean up the status message that is given in the case where a custom
termios()is not installed.Signed-off-by Trevor Woerner <[email protected]>--- drivers/tty/serial/8250/8250_fintek.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/tty/serial/8250/8250_fintek.c +0
-0
drivers/tty/serial/8250/8250_fintek.c static void fintek_8250_set_termios(struct uart_port *port, · line 337
Quoted 6 lines
drivers/tty/serial/8250/8250_fintek.c +1
-1@@ -333,7 +333,7 @@ static void fintek_8250_set_termios(struct uart_port *port,default :/* Don't change clocksource with unknown PID */ dev_warn (port->dev, -"%s: pid: %x Not support. use default set_termios.\n" , +"%s: chipID: %x not supported; using default set_termios.\n" , __func__, pdata->pid);
So the variable calls it PID, the comment calls it PID and you change the report to chipID. Why?
thanks,
Signature · 2 lines
js suse labs
Quoted 9 lines · Jiri Slaby
Quoted 8 lines · Trevor Woerner
Clean up the status message that is given in the case where a custom
termios()is not installed.Signed-off-by Trevor Woerner <[email protected]>--- drivers/tty/serial/8250/8250_fintek.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 14 lines
drivers/tty/serial/8250/8250_fintek.c static void fintek_8250_set_termios(struct uart_port *port, · line 337
Quoted 11 lines
drivers/tty/serial/8250/8250_fintek.c +1
-1@@ -333,7 +333,7 @@ static void fintek_8250_set_termios(struct uart_port *port,default :/* Don't change clocksource with unknown PID */ dev_warn (port->dev, -"%s: pid: %x Not support. use default set_termios.\n" , +"%s: chipID: %x not supported; using default set_termios.\n" , __func__, pdata->pid);So the variable calls it PID, the comment calls it PID and you change the report to chipID. Why?
The datasheet doesn't contain the string/identifier PID anywhere. The hex value stored in pdata->pid is the contents of what the datasheet refers to as the Chip ID Register in the Global Control Registers. Identifying this value as the chipID would probably make more sense to a person who is trying to understand what this value is, provided they're also reading through the datasheet at the same time.
I was considering a patch that would change "pid" to "chipID" in 8250_fintek.c, would that be a better way to go? I guess pid stands for "part ID" or "product ID", but neither of those appear in the datasheet either.
Quoted 4 lines
thanks,
Signature · 2 lines
js suse labs