Skip to contentSkip to conversation

fs: remove reference to the removed config NFSD_V3

PATCH In review Lukas Bulwahn 2 participants 3 messages Mar 11, 2022

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fs: remove reference to the removed config NFSD_V3

Commit 6a687e69a54e ("NFSD: Remove CONFIG_NFSD_V3") removes the config NFSD_V3, but misses one reference in fs/Kconfig.

Remove this remaining reference to the removed config symbol.

This issue was discovered with ./scripts/checkkconfigsymbols.py.

---
Chuck, please pick this quick fix to your commit in linux-next.

 fs/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/Kconfig +1 -1
index 7f2455e8e18a..ec2cf8ccd170 100644
@@ -344,7 +344,7 @@ config LOCKD
 
 config LOCKD_V4
 	bool
-	depends on NFSD_V3 || NFS_V3
+	depends on NFS_V3
 	depends on FILE_LOCKING
 	default y
 
Signature · 1 line
2.17.1
#1 lore raw

Re: [PATCH] remove reference to the removed config NFSD_V3

Quoted 26 lines · Lukas Bulwahn

Commit 6a687e69a54e ("NFSD: Remove CONFIG_NFSD_V3") removes the config NFSD_V3, but misses one reference in fs/Kconfig.

Remove this remaining reference to the removed config symbol.

This issue was discovered with ./scripts/checkkconfigsymbols.py.

---
Chuck, please pick this quick fix to your commit in linux-next.

fs/Kconfig | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
fs/Kconfig +0 -0
index 7f2455e8e18a..ec2cf8ccd170 100644
@@ -344,7 +344,7 @@ config LOCKD
 

config LOCKD_V4
bool

fs/Kconfig config LOCKD · line 347

Quoted 2 lines
fs/Kconfig +1 -1
-	depends on NFSD_V3 || NFS_V3
+	depends on NFS_V3

Actually, I think:

	depends on NFSD || NFS_V3

is more correct. LOCKD_V4 now needs to be enabled whenever the server is enabled, since NFSv3 support in the server is now always enabled.

Quoted 6 lines

depends on FILE_LOCKING
default y

Signature · 1 line
2.17.1

--
Chuck Lever

#2 lore raw

Re: [PATCH] remove reference to the removed config NFSD_V3

Quoted 35 lines · Chuck Lever III
Quoted 27 lines · Lukas Bulwahn

Commit 6a687e69a54e ("NFSD: Remove CONFIG_NFSD_V3") removes the config NFSD_V3, but misses one reference in fs/Kconfig.

Remove this remaining reference to the removed config symbol.

This issue was discovered with ./scripts/checkkconfigsymbols.py.

---
Chuck, please pick this quick fix to your commit in linux-next.

fs/Kconfig | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
fs/Kconfig +0 -0
index 7f2455e8e18a..ec2cf8ccd170 100644
@@ -344,7 +344,7 @@ config LOCKD
 

config LOCKD_V4
bool

fs/Kconfig config LOCKD · line 347

Quoted 2 lines
fs/Kconfig +1 -1
-	depends on NFSD_V3 || NFS_V3
+	depends on NFS_V3

Actually, I think:

Quoted 5 lines
	depends on NFSD || NFS_V3

is more correct. LOCKD_V4 now needs to be enabled whenever the server is enabled, since NFSv3 support in the server is now always enabled.

I've squashed this change into "NFSD: Remove CONFIG_NFSD_V3". Thanks for reporting it, Lukas!

Quoted 9 lines
Quoted 6 lines

depends on FILE_LOCKING
default y

Signature · 1 line
2.17.1

--
Chuck Lever

--
Chuck Lever