Skip to contentSkip to conversation

gpio: ts4900: Fix comment formatting and grammar

PATCH In review Kris Bahnsen 3 participants 3 messages Mar 11, 2022 – Mar 14, 2022 GPIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gpio: ts4900: Fix comment formatting and grammar

The issues were pointed out after the prior commit was applied

---
 drivers/gpio/gpio-ts4900.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
drivers/gpio/gpio-ts4900.c +7 -5
index d918d2df4de2..ede605b8e098 100644
@@ -55,8 +55,9 @@ static int ts4900_gpio_direction_input(struct gpio_chip *chip,
 {
 	struct ts4900_gpio_priv *priv = gpiochip_get_data(chip);
 
-	/* Only clear the OE bit here, requires a RMW. Prevents potential issue
-	 * with OE and data getting to the physical pin at different times.
+	/*
+	 * Only clear the OE bit here, requires a RMW. Prevents a potential issue
+	 * with OE and DAT getting to the physical pin at different times.
 	 */
 	return regmap_update_bits(priv->regmap, offset, TS4900_GPIO_OE, 0);
 }
@@ -68,9 +69,10 @@ static int ts4900_gpio_direction_output(struct gpio_chip *chip,
 	unsigned int reg;
 	int ret;
 
-	/* If changing from an input to an output, we need to first set the
-	 * proper data bit to what is requested and then set OE bit. This
-	 * prevents a glitch that can occur on the IO line
+	/*
+	 * If changing from an input to an output, we need to first set the
+	 * GPIO's DAT bit to what is requested and then set the OE bit. This
+	 * prevents a glitch that can occur on the IO line.
 	 */
 	regmap_read(priv->regmap, offset, &reg);
 	if (!(reg & TS4900_GPIO_OE)) {
Signature · 1 line
2.11.0
Reviewed-by on v1 1/1
#1 lore raw
Quoted 2 lines · Kris Bahnsen

The issues were pointed out after the prior commit was applied

Missed period in the above sentence.

Otherwise LGTM,

Quoted 38 lines
---
 drivers/gpio/gpio-ts4900.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
drivers/gpio/gpio-ts4900.c +7 -6
index d918d2df4de2..ede605b8e098 100644
@@ -55,8 +55,9 @@ static int ts4900_gpio_direction_input(struct gpio_chip *chip,
 {
        struct ts4900_gpio_priv *priv = gpiochip_get_data(chip);
 
-       /* Only clear the OE bit here, requires a RMW. Prevents potential issue
-        * with OE and data getting to the physical pin at different times.
+       /*
+        * Only clear the OE bit here, requires a RMW. Prevents a potential issue
+        * with OE and DAT getting to the physical pin at different times.
         */
        return regmap_update_bits(priv->regmap, offset, TS4900_GPIO_OE, 0);
 }
@@ -68,9 +69,10 @@ static int ts4900_gpio_direction_output(struct gpio_chip *chip,
        unsigned int reg;
        int ret;
 
-       /* If changing from an input to an output, we need to first set the
-        * proper data bit to what is requested and then set OE bit. This
-        * prevents a glitch that can occur on the IO line
+       /*
+        * If changing from an input to an output, we need to first set the
+        * GPIO's DAT bit to what is requested and then set the OE bit. This
+        * prevents a glitch that can occur on the IO line.
         */
        regmap_read(priv->regmap, offset, &reg);
        if (!(reg & TS4900_GPIO_OE)) {
--

2.11.0

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw
Quoted 45 lines · Andy Shevchenko
Quoted 2 lines · Kris Bahnsen

The issues were pointed out after the prior commit was applied

Missed period in the above sentence.

Otherwise LGTM,

Quoted 35 lines
---
 drivers/gpio/gpio-ts4900.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)
drivers/gpio/gpio-ts4900.c +7 -5
index d918d2df4de2..ede605b8e098 100644
@@ -55,8 +55,9 @@ static int ts4900_gpio_direction_input(struct gpio_chip *chip,
 {
        struct ts4900_gpio_priv *priv = gpiochip_get_data(chip);
 
-       /* Only clear the OE bit here, requires a RMW. Prevents potential issue
-        * with OE and data getting to the physical pin at different times.
+       /*
+        * Only clear the OE bit here, requires a RMW. Prevents a potential issue
+        * with OE and DAT getting to the physical pin at different times.
         */
        return regmap_update_bits(priv->regmap, offset, TS4900_GPIO_OE, 0);
 }
@@ -68,9 +69,10 @@ static int ts4900_gpio_direction_output(struct gpio_chip *chip,
        unsigned int reg;
        int ret;
 
-       /* If changing from an input to an output, we need to first set the
-        * proper data bit to what is requested and then set OE bit. This
-        * prevents a glitch that can occur on the IO line
+       /*
+        * If changing from an input to an output, we need to first set the
+        * GPIO's DAT bit to what is requested and then set the OE bit. This
+        * prevents a glitch that can occur on the IO line.
         */
        regmap_read(priv->regmap, offset, &reg);
        if (!(reg & TS4900_GPIO_OE)) {
Quoted 8 lines
Quoted 3 lines

--
2.11.0

--
With Best Regards,
Andy Shevchenko

Added the missing period and applied.

Bart