vhost: handle error while adding split ranges to iotlb
Subsystems (5)
PATCH 1/1 vhost: handle error while adding split ranges to iotlb
vhost_iotlb_add_range_ctx() handles the range [0, ULONG_MAX] by splitting it into two ranges and adding them separately. The return value of adding the first range to the iotlb is currently ignored. Check the return value and bail out in case of an error.
--- drivers/vhost/iotlb.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/vhost/iotlb.c +5 -1
@@ -62,8 +62,12 @@ int vhost_iotlb_add_range_ctx(struct vhost_iotlb *iotlb,*/ if (start ==0 && last ==ULONG_MAX ) {u64 mid = last /2 ; +int err =vhost_iotlb_add_range_ctx (iotlb, start, mid, addr, + perm, opaque); + +if (err) +return err; -vhost_iotlb_add_range_ctx (iotlb, start, mid, addr, perm, opaque); addr += mid +1 ; start = mid +1 ; }
Signature · 1 line
2.35.1
Quoted 5 lines · Anirudh Rayabharam
vhost_iotlb_add_range_ctx()handles the range [0,ULONG_MAX] by splitting it into two ranges and adding them separately. The return value of adding the first range to the iotlb is currently ignored. Check the return value and bail out in case of an error.
We could add:
Quoted 26 lines
Signed-off-by Anirudh Rayabharam <[email protected]>---
drivers/vhost/iotlb.c| 6 +++++-1 file changed, 5 insertions(+), 1 deletion(-)drivers/vhost/iotlb.c +5
-1@@ -62,8 +62,12 @@ int vhost_iotlb_add_range_ctx(struct vhost_iotlb *iotlb,*/ if (start ==0 && last ==ULONG_MAX ) {u64 mid = last /2 ; +int err =vhost_iotlb_add_range_ctx (iotlb, start, mid, addr, + perm, opaque); + +if (err) +return err; -vhost_iotlb_add_range_ctx (iotlb, start, mid, addr, perm, opaque); addr += mid +1 ; start = mid +1 ; }Signature · 1 line
2.35.1
_______________________________________________
Virtualization mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/virtualization