staging: android: ashmem: Declared file operation with const keyword Warning found by checkpatch.pl script.
PATCH 1/1 staging: android: ashmem: Declared file operation with const keyword Warning found by checkpatch.pl script.
--- drivers/staging/android/ashmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/android/ashmem.c +1 -1
@@ -377,7 +377,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,static int ashmem_mmap (struct file *file,struct vm_area_struct *vma) { -static struct file_operations vmfile_fops; +static const struct file_operations vmfile_fops;struct ashmem_area *asma = file->private_data;int ret =0 ;
Signature · 1 line
2.17.1
On Sun, 2022-03-13 at 03:11 +0530, shaikh kamal wrote:
[]
drivers/staging/android/ashmem.c
Quoted 1 line
drivers/staging/android/ashmem.c +0
-0
[]
drivers/staging/android/ashmem.c ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr, · line 380
Quoted 6 lines
drivers/staging/android/ashmem.c +1
-1@@ -377,7 +377,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,static int ashmem_mmap (struct file *file,struct vm_area_struct *vma) { -static struct file_operations vmfile_fops; +static const struct file_operations vmfile_fops;
Make sure to compile any files modified by your suggested patches _before_ sending the patches.
Quoted 6 lines · Joe Perches
On Sun, 2022-03-13 at 03:11 +0530, shaikh kamal wrote:
[]drivers/staging/android/ashmem.c
Quoted 1 line
drivers/staging/android/ashmem.c +0
-0[]
Quoted 2 lines
drivers/staging/android/ashmem.c +0
-0@@ -377,7 +377,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,
Quoted 9 lines
drivers/staging/android/ashmem.c ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr, · line 380
Quoted 4 lines
drivers/staging/android/ashmem.c +1
-1static int ashmem_mmap (struct file *file,struct vm_area_struct *vma) { -static struct file_operations vmfile_fops; +static const struct file_operations vmfile_fops;Make sure to compile any files modified by your suggested patches _before_ sending the patches.
Thanks for your suggestion, Kernel build is failing.
Hi Shaikh,
Quoted 10 lines · shaikh kamal
Signed-off-by shaikh kamal <[email protected]>--- drivers/staging/android/ashmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/android/ashmem.c +0
-0
drivers/staging/android/ashmem.c ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr, · line 383
Quoted 8 lines
drivers/staging/android/ashmem.c +1
-1@@ -377,7 +377,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,static int ashmem_mmap (struct file *file,struct vm_area_struct *vma) { -static struct file_operations vmfile_fops; +static const struct file_operations vmfile_fops;struct ashmem_area *asma = file->private_data;int ret =0 ;
Are you sure this patch compiles? vmfile_fops is overrided few lines below
odd checkpatch.pl warning...
With regards,
Pavel Skripkin
Quoted 23 lines · Pavel Skripkin
Hi Shaikh,
Quoted 10 lines · shaikh kamal
Signed-off-by shaikh kamal <[email protected]>---
drivers/staging/android/ashmem.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/android/ashmem.c +0
-0drivers/staging/android/ashmem.c ashmem_vmfile_get_unmapped_area(struct file *file, · line 382
Quoted 7 lines
drivers/staging/android/ashmem.c +1
-1@@ -377,7 +377,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file,unsigned long addr, static int ashmem_mmap(struct file *file, struct vm_area_struct *vma) { - static struct file_operations vmfile_fops; + static const struct file_operations vmfile_fops; struct ashmem_area *asma = file->private_data; int ret = 0;Are you sure this patch compiles?
vmfile_fopsis overrided few lines below
Quoted 7 lines
odd checkpatch.pl warning...
With regards,
Pavel Skripkin
Thank you,yes vmfile_fops is overrided in below code.
Building the kernel - make -j4,drivers/staging/android/ashmem.c: In function ‘ashmem_mmap’:drivers/staging/android/ashmem.c:431:16: error: assignment of read-only variable ‘vmfile_fops’
vmfile_fops = *vmfile->f_op;
^
drivers/staging/android/ashmem.c:432:21: error: assignment of member ‘mmap’ in read-only object
vmfile_fops.mmap = ashmem_vmfile_mmap;
^
drivers/staging/android/ashmem.c:433:34: error: assignment of member ‘get_unmapped_area’ in read-only object
vmfile_fops.get_unmapped_area =
^scripts/Makefile.build:288: recipe for target 'drivers/staging/android/ashmem.o' failed make[3]: *** [drivers/staging/android/ashmem.o] Error 1 scripts/Makefile.build:550: recipe for target 'drivers/staging/android' failed make[2]: *** [drivers/staging/android] Error 2 scripts/Makefile.build:550: recipe for target 'drivers/staging' failed make[1]: *** [drivers/staging] Error 2
Makefile:1831: recipe for target 'drivers' failed
Thanks & Regards,
Shaikh Kamaluddin
Greg Kroah-Hartman
maintainerQuoted 48 lines · shaikh kamaluddin
Quoted 24 lines · Pavel Skripkin
Hi Shaikh,
Quoted 11 lines · shaikh kamal
Signed-off-by shaikh kamal <[email protected]>---
drivers/staging/android/ashmem.c| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/android/ashmem.c +0
-0drivers/staging/android/ashmem.c ashmem_vmfile_get_unmapped_area(struct file · line 382
Quoted 7 lines
drivers/staging/android/ashmem.c +1
-1@@ -377,7 +377,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr, static int ashmem_mmap(struct file *file, struct vm_area_struct *vma) { - static struct file_operations vmfile_fops; + static const struct file_operations vmfile_fops; struct ashmem_area *asma = file->private_data; int ret = 0;Are you sure this patch compiles?
vmfile_fopsis overrided few lines belowQuoted 7 lines
odd checkpatch.pl warning...
With regards,
Pavel SkripkinThank you,yes
vmfile_fopsis overrided in below code. Building the kernel - make -j4,drivers/staging/android/ashmem.c: In function ‘ashmem_mmap’:drivers/staging/android/ashmem.c:431:16: error: assignment of read-only variable ‘vmfile_fops’vmfile_fops = *vmfile->f_op; ^ drivers/staging/android/ashmem.c:432:21: error: assignment of member ‘mmap’ in read-only object vmfile_fops.mmap = ashmem_vmfile_mmap; ^ drivers/staging/android/ashmem.c:433:34: error: assignment of member ‘get_unmapped_area’ in read-only object vmfile_fops.get_unmapped_area = ^
Quoted 9 lines
scripts/Makefile.build:288: recipe for target 'drivers/staging/android/ashmem.o' failed
make[3]: *** [drivers/staging/android/ashmem.o] Error 1scripts/Makefile.build:550: recipe for target 'drivers/staging/android' failed
make[2]: *** [drivers/staging/android] Error 2scripts/Makefile.build:550: recipe for target 'drivers/staging' failed make[1]: *** [drivers/staging] Error 2
Makefile:1831: recipe for target 'drivers' failed
As always, it is expected that when you submit a change to the kernel, at the very least you have test-built it to ensure that it does not break the build. Please remember to do this next time.
thanks,
greg k-h
Quoted 59 lines · Greg Kroah-Hartman
Quoted 48 lines · shaikh kamaluddin
Quoted 24 lines · Pavel Skripkin
Hi Shaikh,
Quoted 11 lines · shaikh kamal
Signed-off-by shaikh kamal <[email protected]>--- drivers/staging/android/ashmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/android/ashmem.c +0
-0drivers/staging/android/ashmem.c ashmem_vmfile_get_unmapped_area(struct file · line 382
Quoted 7 lines
drivers/staging/android/ashmem.c +1
-1@@ -377,7 +377,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr, static int ashmem_mmap(struct file *file, struct vm_area_struct *vma) { - static struct file_operations vmfile_fops; + static const struct file_operations vmfile_fops; struct ashmem_area *asma = file->private_data; int ret = 0;Are you sure this patch compiles?
vmfile_fopsis overrided few lines belowQuoted 7 lines
odd checkpatch.pl warning...
With regards,
Pavel SkripkinThank you,yes
vmfile_fopsis overrided in below code. Building the kernel - make -j4,drivers/staging/android/ashmem.c: In function ‘ashmem_mmap’:drivers/staging/android/ashmem.c:431:16: error: assignment of read-only variable ‘vmfile_fops’vmfile_fops = *vmfile->f_op; ^ drivers/staging/android/ashmem.c:432:21: error: assignment of member ‘mmap’ in read-only object vmfile_fops.mmap = ashmem_vmfile_mmap; ^ drivers/staging/android/ashmem.c:433:34: error: assignment of member ‘get_unmapped_area’ in read-only object vmfile_fops.get_unmapped_area = ^Quoted 9 lines
scripts/Makefile.build:288: recipe for target 'drivers/staging/android/ashmem.o' failed
make[3]: *** [drivers/staging/android/ashmem.o] Error 1scripts/Makefile.build:550: recipe for target 'drivers/staging/android' failed
make[2]: *** [drivers/staging/android] Error 2scripts/Makefile.build:550: recipe for target 'drivers/staging' failed make[1]: *** [drivers/staging] Error 2
Makefile:1831: recipe for target 'drivers' failed
Quoted 7 lines
As always, it is expected that when you submit a change to the kernel, at the very least you have test-built it to ensure that it does not break the build. Please remember to do this next time.
thanks,
greg k-h
Thank you, I will do that.
Regards,
Shaikh Kamaluddin
Greg Kroah-Hartman
maintainerQuoted 22 lines · shaikh kamal
Signed-off-by shaikh kamal <[email protected]>--- drivers/staging/android/ashmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/staging/android/ashmem.c +1
-1@@ -377,7 +377,7 @@ ashmem_vmfile_get_unmapped_area(struct file *file, unsigned long addr,static int ashmem_mmap (struct file *file,struct vm_area_struct *vma) { -static struct file_operations vmfile_fops; +static const struct file_operations vmfile_fops;struct ashmem_area *asma = file->private_data;int ret =0 ;Signature · 1 line
2.17.1
Hi,
This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree.
You are receiving this message because of the following common error(s) as indicated below:
- Your patch breaks the build.
- You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change.
- You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like.
If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers.
thanks,
greg k-h's patch email bot