kconfig: detect LD implementation
PATCH 1/1 kconfig: detect LD implementation
Detect GNU and LLVM ld implementations. This is required for further patches that will introduce diverging behaviour depending on the linker implementation in use.
Note that LLVM ld returns "compatible with GNU linkers" as part of the version string, so be on the safe side and use '^' to only match at the start of the line in case LLVM ever decides to change the text to use "compatible with GNU ld" instead.
--- xen/Kconfig | 6 ++++++ 1 file changed, 6 insertions(+)
xen/Kconfig +6 -0
@@ -23,6 +23,12 @@ config CLANG_VERSION int default $(shell,$(BASEDIR)/scripts/clang-version.sh $(CC)) +config LD_IS_GNU + def_bool $(success,$(LD) --version | head -n 1 | grep -q "^GNU ld") + +config LD_IS_LLVM + def_bool $(success,$(LD) --version | head -n 1 | grep -q "^LLD") + # -fvisibility=hidden reduces -fpic cost, if it's available config CC_HAS_VISIBILITY_ATTRIBUTE def_bool $(cc-option,-fvisibility=hidden)
Signature · 1 line
2.34.1
Hi Roger,
Quoted 20 lines · Roger Pau Monne
Detect GNU and LLVM ld implementations. This is required for further patches that will introduce diverging behaviour depending on the linker implementation in use.
Note that LLVM ld returns "compatible with GNU linkers" as part of the version string, so be on the safe side and use '^' to only match at the start of the line in case LLVM ever decides to change the text to use "compatible with GNU ld" instead.
Signed-off-by Roger Pau Monné <[email protected]>--- xen/Kconfig | 6 ++++++ 1 file changed, 6 insertions(+)xen/Kconfig +0
-0@@ -23,6 +23,12 @@ config CLANG_VERSION int
xen/Kconfig config CLANG_VERSION · line 33
Quoted 10 lines
xen/Kconfig +5
-0default $(shell,$(BASEDIR)/scripts/clang-version.sh $(CC)) +config LD_IS_GNU + def_bool $(success,$(LD) --version | head -n 1 | grep -q "^GNU ld") +> +config LD_IS_LLVM + def_bool $(success,$(LD) --version | head -n 1 | grep -q "^LLD") + # -fvisibility=hidden reduces -fpic cost, if it's available config CC_HAS_VISIBILITY_ATTRIBUTE def_bool $(cc-option,-fvisibility=hidden)
NIT: You do not really need to use head especiialy if grep for the beginning of a line. With or without this:
Cheers,
Michal
Quoted 25 lines · Michal Orzel
Hi Roger,
Quoted 22 lines · Roger Pau Monne
Detect GNU and LLVM ld implementations. This is required for further patches that will introduce diverging behaviour depending on the linker implementation in use.
Note that LLVM ld returns "compatible with GNU linkers" as part of the version string, so be on the safe side and use '^' to only match at the start of the line in case LLVM ever decides to change the text to use "compatible with GNU ld" instead.
Signed-off-by Roger Pau Monné <[email protected]>--- xen/Kconfig | 6 ++++++ 1 file changed, 6 insertions(+)xen/Kconfig +0
-0@@ -23,6 +23,12 @@ config CLANG_VERSION int default $(shell,$(BASEDIR)/scripts/clang-version.sh $(CC))
Quoted 10 lines
xen/Kconfig config CLANG_VERSION · line 34
Quoted 8 lines
xen/Kconfig +5
-0+config LD_IS_GNU + def_bool $(success,$(LD) --version | head -n 1 | grep -q "^GNU ld") +> +config LD_IS_LLVM + def_bool $(success,$(LD) --version | head -n 1 | grep -q "^LLD") + # -fvisibility=hidden reduces -fpic cost, if it's available config CC_HAS_VISIBILITY_ATTRIBUTE def_bool $(cc-option,-fvisibility=hidden)NIT: You do not really need to use head especiialy if grep for the beginning of a line.
I'm afraid I don't agree. We use head because we only want to match against the first line of the output, and then we use '^' to match at the beginning of such line. Without using head we would end up matching at the beginning of any line present in the output.
Thanks, Roger.