Skip to contentSkip to conversation

net/bnxt: fix ulp parser to ignore segment offset

PATCH In review Ajit Khaparde 1 participant 2 messages Mar 14, 2022 – Mar 29, 2022 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net/bnxt: fix ulp parser to ignore segment offset

From: Shuanglin Wang <[email protected]>

Fix ulp parser to ignore segment_offset of IPV4 header. Currently the IPV4 handler is assuming default setting, which causes the flow table to be updated incorrectly.

Fixes 741172be52de ("net/bnxt: refactor flow parser in ULP")
---
 drivers/net/bnxt/tf_ulp/ulp_rte_parser.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/bnxt/tf_ulp/ulp_rte_parser.c +1 -1
index f4274dd634..9edf3e8799 100644
@@ -1096,7 +1096,7 @@ ulp_rte_ipv4_hdr_handler(const struct rte_flow_item *item,
 						   hdr.fragment_offset),
 			      ulp_deference_struct(ipv4_mask,
 						   hdr.fragment_offset),
-			      ULP_PRSR_ACT_DEFAULT);
+			      ULP_PRSR_ACT_MASK_IGNORE);
 
 	size = sizeof(((struct rte_flow_item_ipv4 *)NULL)->hdr.time_to_live);
 	ulp_rte_prsr_fld_mask(params, &idx, size,
Signature · 1 line
2.32.0 (Apple Git-132)
#1 lore raw
Quoted 7 lines · Ajit Khaparde

From: Shuanglin Wang <[email protected]>

Fix ulp parser to ignore segment_offset of IPV4 header. Currently the IPV4 handler is assuming default setting, which causes the flow table to be updated incorrectly.

Quoted 6 lines
Fixes 741172be52de ("net/bnxt: refactor flow parser in ULP")

Patch applied dpdk-next-net-brcm.

Quoted 20 lines
---
 drivers/net/bnxt/tf_ulp/ulp_rte_parser.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/bnxt/tf_ulp/ulp_rte_parser.c +1 -2
index f4274dd634..9edf3e8799 100644
@@ -1096,7 +1096,7 @@ ulp_rte_ipv4_hdr_handler(const struct rte_flow_item *item,
                                                   hdr.fragment_offset),
                              ulp_deference_struct(ipv4_mask,
                                                   hdr.fragment_offset),
-                             ULP_PRSR_ACT_DEFAULT);
+                             ULP_PRSR_ACT_MASK_IGNORE);
 
        size = sizeof(((struct rte_flow_item_ipv4 *)NULL)->hdr.time_to_live);
        ulp_rte_prsr_fld_mask(params, &idx, size,
--

2.32.0 (Apple Git-132)