Skip to contentSkip to conversation

clk: imx: Select MXC_CLK for i.MX93 clock driver

PATCH Applied Abel Vesa 3 participants 4 messages Mar 15, 2022

Subsystems (3)
lore
Share & tools
lore

Abel Vesa

author
#0 lore raw

PATCH 1/1 clk: imx: Select MXC_CLK for i.MX93 clock driver

Most of the i.MX clock generic API is built by selecting MXC_CLK. Without it, the i.MX93 clock driver will fail to build:

aarch64-linux-gnu-ld: drivers/clk/imx/clk-imx93.o:
in function `imx93_clocks_probe': clk-imx93.c:(.text+0xa8):
undefined reference to `imx_obtain_fixed_clk_hw'

So fix this by selecting MXC_CLK for the CLK_IMX93.

Fixes 24defbe194b6 ("clk: imx: add i.MX93 clk")
---
 drivers/clk/imx/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/imx/Kconfig +1 -0
index cc464a42d646..25785ec9c276 100644
@@ -109,6 +109,7 @@ config CLK_IMX8ULP
 config CLK_IMX93
 	tristate "IMX93 CCM Clock Driver"
 	depends on ARCH_MXC || COMPILE_TEST
+	select MXC_CLK
 	help
 	    Build the driver for i.MX93 CCM Clock Driver
 
Signature · 1 line
2.34.1
reviewer Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines

Subject: [PATCH] clk: imx: Select MXC_CLK for i.MX93 clock driver

Most of the i.MX clock generic API is built by selecting MXC_CLK. Without it, the i.MX93 clock driver will fail to build:

aarch64-linux-gnu-ld: drivers/clk/imx/clk-imx93.o:
in function `imx93_clocks_probe': clk-imx93.c:(.text+0xa8):
undefined reference to `imx_obtain_fixed_clk_hw'

Quoted 5 lines

So fix this by selecting MXC_CLK for the CLK_IMX93.

Fixes 24defbe194b6 ("clk: imx: add i.MX93 clk")
Quoted 18 lines
---
 drivers/clk/imx/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/imx/Kconfig index renamed from drivers/clk/imx/Kconfig +0 -0

cc464a42d646..25785ec9c276 100644

drivers/clk/imx/Kconfig +1 -1
@@ -109,6 +109,7 @@ config CLK_IMX8ULP
 config CLK_IMX93
 	tristate "IMX93 CCM Clock Driver"
 	depends on ARCH_MXC || COMPILE_TEST
+	select MXC_CLK
 	help
 	    Build the driver for i.MX93 CCM Clock Driver
 
--

2.34.1

author
#2 lore raw
Quoted 9 lines · Peng Fan
Quoted 9 lines

Subject: [PATCH] clk: imx: Select MXC_CLK for i.MX93 clock driver

Most of the i.MX clock generic API is built by selecting MXC_CLK. Without it, the i.MX93 clock driver will fail to build:

aarch64-linux-gnu-ld: drivers/clk/imx/clk-imx93.o:
in function `imx93_clocks_probe': clk-imx93.c:(.text+0xa8):
undefined reference to `imx_obtain_fixed_clk_hw'

Quoted 7 lines
Quoted 5 lines

So fix this by selecting MXC_CLK for the CLK_IMX93.

Fixes 24defbe194b6 ("clk: imx: add i.MX93 clk")

Thanks, Peng.

Stephen, can you please pick this up?

Quoted 20 lines
Quoted 19 lines
---
 drivers/clk/imx/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/clk/imx/Kconfig index renamed from drivers/clk/imx/Kconfig +0 -0

cc464a42d646..25785ec9c276 100644

drivers/clk/imx/Kconfig +1 -1
@@ -109,6 +109,7 @@ config CLK_IMX8ULP
 config CLK_IMX93
 	tristate "IMX93 CCM Clock Driver"
 	depends on ARCH_MXC || COMPILE_TEST
+	select MXC_CLK
 	help
 	    Build the driver for i.MX93 CCM Clock Driver
 
--

2.34.1

maintainer Applied
#3 lore raw
In reply to Abel Vesa

Quoting Abel Vesa (2022-03-15 01:24:46)

Quoted 7 lines

Most of the i.MX clock generic API is built by selecting MXC_CLK. Without it, the i.MX93 clock driver will fail to build:

aarch64-linux-gnu-ld: drivers/clk/imx/clk-imx93.o:
in function `imx93_clocks_probe': clk-imx93.c:(.text+0xa8):
undefined reference to `imx_obtain_fixed_clk_hw'

Quoted 6 lines

So fix this by selecting MXC_CLK for the CLK_IMX93.

Fixes 24defbe194b6 ("clk: imx: add i.MX93 clk")

---

Applied to clk-next