NFSD: prevent underflow in nfssvc_decode_writeargs()
Subsystems (3)
PATCH v2 1/1 NFSD: prevent underflow in nfssvc_decode_writeargs()
Smatch complains:
fs/nfsd/nfsxdr.c:341 nfssvc_decode_writeargs() warn: no lower bound on 'args->len'
Change the type to unsigned to prevent this issue.
Signed-off-by Dan Carpenter <[email protected]>
---
v2: change the type to unsigned instead of adding a check for negatives
fs/nfsd/nfsproc.c | 2 +- fs/nfsd/xdr.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
fs/nfsd/nfsproc.c +1 -1
@@ -230,7 +230,7 @@ nfsd_proc_write(struct svc_rqst *rqstp)unsigned long cnt = argp->len;unsigned int nvecs; -dprintk ("nfsd: WRITE %s %d bytes at %d\n" , +dprintk ("nfsd: WRITE %s %u bytes at %d\n" ,SVCFH_fmt (&argp->fh), argp->len, argp->offset);
fs/nfsd/xdr.h +1 -1
@@ -32,7 +32,7 @@ struct nfsd_readargs {struct nfsd_writeargs {svc_fh fh;__u32 offset; -int len; +__u32 len;struct xdr_buf payload; };
Signature · 1 line
2.20.1