Skip to contentSkip to conversation

media: platform: Remove unnecessary print function dev_err()

PATCH In review Yang Li 2 participants 2 messages Mar 16, 2022

Subsystems (3)
lore
Share & tools
lore

Yang Li

author
#0 lore raw

PATCH 1/1 media: platform: Remove unnecessary print function dev_err()

The print function dev_err() is redundant because platform_get_irq() already prints an error.

Eliminate the follow coccicheck warnings:
./drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c:119:2-9:
line 119 is redundant because platform_get_irq() already prints an error ./drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_hw.c:103:2-9:
line 103 is redundant because platform_get_irq() already prints an error

---
 drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c | 4 +---
 drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_hw.c  | 4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)
drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c +1 -3
index 48dad9bb13d2..df7b25e9cbc8 100644
@@ -115,10 +115,8 @@ static int mtk_vcodec_init_dec_resources(struct mtk_vcodec_dev *dev)
 		return 0;
 
 	dev->dec_irq = platform_get_irq(pdev, 0);
-	if (dev->dec_irq < 0) {
-		dev_err(&pdev->dev, "failed to get irq number");
+	if (dev->dec_irq < 0)
 		return dev->dec_irq;
-	}
 
 	irq_set_status_flags(dev->dec_irq, IRQ_NOAUTOEN);
 	ret = devm_request_irq(&pdev->dev, dev->dec_irq,
drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_hw.c +1 -3
index 8d2a641d92f1..5f07313676bb 100644
@@ -99,10 +99,8 @@ static int mtk_vdec_hw_init_irq(struct mtk_vdec_hw_dev *dev)
 	int ret;
 
 	dev->dec_irq = platform_get_irq(pdev, 0);
-	if (dev->dec_irq < 0) {
-		dev_err(&pdev->dev, "Failed to get irq resource");
+	if (dev->dec_irq < 0)
 		return dev->dec_irq;
-	}
 
 	irq_set_status_flags(dev->dec_irq, IRQ_NOAUTOEN);
 	ret = devm_request_irq(&pdev->dev, dev->dec_irq,
Signature · 1 line
2.20.1.7.g153144c
#1 lore raw

Hi Yang,

Quoted 21 lines

The print function dev_err() is redundant because platform_get_irq() already prints an error.

Eliminate the follow coccicheck warnings:
./drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c:119:2-9:
line 119 is redundant because platform_get_irq() already prints an error ./drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_hw.c:103:2-9:
line 103 is redundant because platform_get_irq() already prints an error

---
drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c | 4 +--- drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_hw.c | 4 +---

2 files changed, 2 insertions(+), 6 deletions(-)
drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c +0 -0
index 48dad9bb13d2..df7b25e9cbc8 100644

drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c static int mtk_vcodec_init_dec_resources(struct mtk_vcodec_dev *dev) · line 120

Quoted 9 lines
drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c +1 -3
@@ -115,10 +115,8 @@ static int mtk_vcodec_init_dec_resources(struct mtk_vcodec_dev *dev)
 		return 0;
 
 	dev->dec_irq = platform_get_irq(pdev, 0);
-	if (dev->dec_irq < 0) {
-		dev_err(&pdev->dev, "failed to get irq number");
+	if (dev->dec_irq < 0)
 		return dev->dec_irq;
-	}
 

Thanks for the patch,
Yihao has submitted a patch to fix mtk_vcodec_init_dec_resources() [1]
[1] https://lore.kernel.org/lkml/[email protected]/

Quoted 8 lines
drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c +0 -0
 	irq_set_status_flags(dev->dec_irq, IRQ_NOAUTOEN);
 	ret = devm_request_irq(&pdev->dev, dev->dec_irq,
drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_hw.c +0 -0
index 8d2a641d92f1..5f07313676bb 100644
@@ -99,10 +99,8 @@ static int mtk_vdec_hw_init_irq(struct mtk_vdec_hw_dev *dev)
 	int ret;

drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_hw.c static int mtk_vdec_hw_init_irq(struct mtk_vdec_hw_dev *dev) · line 106

Quoted 10 lines
drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_hw.c +1 -3
 
 	dev->dec_irq = platform_get_irq(pdev, 0);
-	if (dev->dec_irq < 0) {
-		dev_err(&pdev->dev, "Failed to get irq resource");
+	if (dev->dec_irq < 0)
 		return dev->dec_irq;
-	}
 
 	irq_set_status_flags(dev->dec_irq, IRQ_NOAUTOEN);
 	ret = devm_request_irq(&pdev->dev, dev->dec_irq,

Would you mind submitting mtk_vdec_hw_init_irq() part by another patch?

Thanks,
Miles