Skip to contentSkip to conversation

Bluetooth: call hci_le_conn_failed with hdev lock in hci_le_conn_failed

PATCH In review Niels Dossche 2 participants 3 messages Mar 16, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Bluetooth: call hci_le_conn_failed with hdev lock in hci_le_conn_failed

hci_le_conn_failed function's documentation says that the caller must hold hdev->lock. The only callsite that does not hold that lock is hci_le_conn_failed. The other 3 callsites hold the hdev->lock very locally. The solution is to hold the lock during the call to hci_le_conn_failed.

Fixes 3c857757ef6e ("Bluetooth: Add directed advertising support through connect()")
---
 net/bluetooth/hci_conn.c | 2 ++
 1 file changed, 2 insertions(+)
net/bluetooth/hci_conn.c +2 -0
index 04ebe901e86f..3bb2b3b6a1c9 100644
@@ -669,7 +669,9 @@ static void le_conn_timeout(struct work_struct *work)
 	if (conn->role == HCI_ROLE_SLAVE) {
 		/* Disable LE Advertising */
 		le_disable_advertising(hdev);
+		hci_dev_lock(hdev);
 		hci_le_conn_failed(conn, HCI_ERROR_ADVERTISING_TIMEOUT);
+		hci_dev_unlock(hdev);
 		return;
 	}
 
Signature · 1 line
2.35.1
maintainer
#1 lore raw

Hi Niels,

Quoted 11 lines

hci_le_conn_failed function's documentation says that the caller must hold hdev->lock. The only callsite that does not hold that lock is hci_le_conn_failed. The other 3 callsites hold the hdev->lock very locally. The solution is to hold the lock during the call to hci_le_conn_failed.

Fixes 3c857757ef6e ("Bluetooth: Add directed advertising support through connect()")

---
net/bluetooth/hci_conn.c | 2 ++

1 file changed, 2 insertions(+)

please send net/bluetooth/ to linux-bluetooth mailing list.

Regards

Marcel

#2 lore raw
Quoted 14 lines · Marcel Holtmann

Hi Niels,

Quoted 11 lines

hci_le_conn_failed function's documentation says that the caller must hold hdev->lock. The only callsite that does not hold that lock is hci_le_conn_failed. The other 3 callsites hold the hdev->lock very locally. The solution is to hold the lock during the call to hci_le_conn_failed.

Fixes 3c857757ef6e ("Bluetooth: Add directed advertising support through connect()")

---
net/bluetooth/hci_conn.c | 2 ++

1 file changed, 2 insertions(+)
Quoted 6 lines

please send net/bluetooth/ to linux-bluetooth mailing list.

Regards

Marcel

Hi Marcel
My bad, I'll resend it to there, I have copied the wrong mail address. Regards
Niels