staging: fbtft: Constify buf parameter in fbtft_dbg_hex()
Subsystems (3)
PATCH v2 1/2 staging: fbtft: Constify buf parameter in fbtft_dbg_hex()
It's obvious that we don't and shouldn't modify buffer that is about to be dumped. Constify parameter in fbtft_dbg_hex() to make it clear.
Fixes c296d5f9957c ("staging: fbtft: core support")
Signed-off-by Andy Shevchenko <[email protected]>
---
v2: new patch to fix a warning (Greg)
drivers/staging/fbtft/fbtft-core.c | 2 +- drivers/staging/fbtft/fbtft.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/staging/fbtft/fbtft-core.c +1 -1
@@ -49,7 +49,7 @@ int fbtft_write_buf_dc(struct fbtft_par *par, void *buf, size_t len, int dc)EXPORT_SYMBOL (fbtft_write_buf_dc);void fbtft_dbg_hex (const struct device *dev,int groupsize, -void *buf,size_t len,const char *fmt, ...) +const void *buf,size_t len,const char *fmt, ...) {va_list args;static char textbuf[512 ];
drivers/staging/fbtft/fbtft.h +1 -1
@@ -240,7 +240,7 @@ struct fbtft_par {int fbtft_write_buf_dc (struct fbtft_par *par,void *buf,size_t len,int dc); __printf(5, 6)void fbtft_dbg_hex (const struct device *dev,int groupsize, -void *buf,size_t len,const char *fmt, ...); +const void *buf,size_t len,const char *fmt, ...);struct fb_info *fbtft_framebuffer_alloc (struct fbtft_display *display,struct device *dev,struct fbtft_platform_data *pdata);
Signature · 1 line
2.35.1
PATCH v2 2/2 staging: fbtft: Consider type of init sequence values in fbtft_init_display()
In the fbtft_init_display() the init sequence is printed for the debug purposes. Unfortunately the current code doesn't take into account that values in the buffer are of the s16 type.
Consider that and replace the printing code with fbtft_par_dbg_hex() call.
Fixes b888897014a9 ("staging/fbtft: Remove all strcpy() uses")
Signed-off-by Andy Shevchenko <[email protected]>
---
v2: no changes, just based on prerequisite
drivers/staging/fbtft/fbtft-core.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
drivers/staging/fbtft/fbtft-core.c +3 -4
@@ -1034,10 +1034,9 @@ int fbtft_init_display(struct fbtft_par *par)for (j =0 ; par->init_sequence[i +1 + j] >=0 ; j++) ; -fbtft_par_dbg (DEBUG_INIT_DISPLAY , par, -"init: write(0x%02X) %*ph\n" , - par->init_sequence[i], j, - &par->init_sequence[i +1 ]); +fbtft_par_dbg_hex (DEBUG_INIT_DISPLAY , par, par->info->device, + s16, &par->init_sequence[i +1 ], j, +"init: write(0x%02X)" , par->init_sequence[i]);/* Write */ j =0 ;
Signature · 1 line
2.35.1