iwlwifi: mei: fix building iwlmei
Subsystems (3)
PATCH 1/1 iwlwifi: mei: fix building iwlmei
From: Arnd Bergmann <[email protected]>
Building iwlmei without CONFIG_CFG80211 causes a link-time warning:
ld.lld: error: undefined symbol: ieee80211_hdrlen
Quoted 2 lines
Quoted 2 lines
Quoted 2 lines
referenced by
net.c
net/wireless/intel/iwlwifi/mei/net.o:(iwl_mei_tx_copy_to_csme) in archivedrivers/built-in.a
Add an explicit dependency to avoid this. In theory it should not be needed here, but it also seems pointless to allow IWLMEI for configurations without CFG80211.
--- drivers/net/wireless/intel/iwlwifi/Kconfig | 1 + 1 file changed, 1 insertion(+)
I see this warning on 5.17-rc8, but did not test it on linux-next, which may already have a fix.
drivers/net/wireless/intel/iwlwifi/Kconfig +1 -0
@@ -139,6 +139,7 @@ config IWLMEI tristate "Intel Management Engine communication over WLAN" depends on INTEL_MEI depends on PM + depends on CFG80211 help Enables the iwlmei kernel module.
Signature · 1 line
2.29.2
Quoted 13 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Building iwlmei without
CONFIG_CFG80211causes a link-time warning:ld.lld: error: undefined symbol:
ieee80211_hdrlenQuoted 3 lines
Quoted 3 lines
Quoted 3 lines
referenced by
net.c
net/wireless/intel/iwlwifi/mei/net.o:(iwl_mei_tx_copy_to_csme)
in archivedrivers/built-in.aAdd an explicit dependency to avoid this. In theory it should not be needed here, but it also seems pointless to allow IWLMEI for configurations without CFG80211.
Quoted 7 lines
Signed-off-by Arnd Bergmann <[email protected]>--- drivers/net/wireless/intel/iwlwifi/Kconfig | 1 + 1 file changed, 1 insertion(+)I see this warning on 5.17-rc8, but did not test it on linux-next, which may already have a fix.
I just sent the last pull request to v5.17. Luca, should I take this to wireless-next? Ack?
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Quoted 29 lines
From: Arnd Bergmann <[email protected]>
Building iwlmei without
CONFIG_CFG80211causes a link-time warning:ld.lld: error: undefined symbol:
ieee80211_hdrlenQuoted 4 lines
Quoted 4 lines
Quoted 4 lines
referenced by
net.cnet/wireless/intel/iwlwifi/mei/net.o:(iwl_mei_tx_copy_to_csme) in archive
drivers/built-in.aAdd an explicit dependency to avoid this. In theory it should not be needed here, but it also seems pointless to allow IWLMEI for configurations without CFG80211.
Signed-off-by Arnd Bergmann <[email protected]>--- drivers/net/wireless/intel/iwlwifi/Kconfig | 1 + 1 file changed, 1 insertion(+)I see this warning on 5.17-rc8, but did not test it on linux-next, which may already have a fix.
drivers/net/wireless/intel/iwlwifi/Kconfig +0
-0
drivers/net/wireless/intel/iwlwifi/Kconfig config IWLMEI · line 145
Quoted 7 lines
drivers/net/wireless/intel/iwlwifi/Kconfig +1
-0@@ -139,6 +139,7 @@ config IWLMEI tristate "Intel Management Engine communication over WLAN" depends on INTEL_MEI depends on PM + depends on CFG80211 help Enables the iwlmei kernel module.
FWIW: Luca just merged the exact same patch internally. So
Coelho, Luciano
Acked-byQuoted 42 lines · Emmanuel
Quoted 37 lines
From: Arnd Bergmann <[email protected]>
Building iwlmei without
CONFIG_CFG80211causes a link-time warning:ld.lld: error: undefined symbol:
ieee80211_hdrlenQuoted 5 lines
Quoted 5 lines
Quoted 5 lines
referenced by
net.cnet/wireless/intel/iwlwifi/mei/net.o:(iwl_mei_tx_copy_to_csme ) in
archivedrivers/built-in.aAdd an explicit dependency to avoid this. In theory it should not be needed
here, but it also seems pointless to allow IWLMEI for configurations without
CFG80211.Signed-off-by Arnd Bergmann <[email protected]>---
drivers/net/wireless/intel/iwlwifi/Kconfig | 1 +1 file changed, 1 insertion(+)I see this warning on 5.17-rc8, but did not test it on linux-next, which may
already have a fix.drivers/net/wireless/intel/iwlwifi/Kconfig +0
-0@@ -139,6 +139,7 @@ config IWLMEItristate "Intel Management Engine communication over WLAN" depends on
INTEL_MEI
depends on PMdrivers/net/wireless/intel/iwlwifi/Kconfig +1
-0+ depends on CFG80211Quoted 3 lines
help
Enables the iwlmei kernel module.FWIW: Luca just merged the exact same patch internally. So
Quoted 1 line
Yeah, please take this.
--
Cheers,
Luca.
Quoted 8 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
Building iwlmei without
CONFIG_CFG80211causes a link-time warning:ld.lld: error: undefined symbol:
ieee80211_hdrlenQuoted 2 lines
Quoted 2 lines
Quoted 2 lines
referenced by
net.c
net/wireless/intel/iwlwifi/mei/net.o:(iwl_mei_tx_copy_to_csme) in archivedrivers/built-in.a
Quoted 7 lines
Add an explicit dependency to avoid this. In theory it should not be needed here, but it also seems pointless to allow IWLMEI for configurations without CFG80211.
Signed-off-by Arnd Bergmann <[email protected]>Acked-by Luca Coelho <[email protected]>
Patch applied to wireless-next.git, thanks.
066291bec0c5 iwlwifi: mei: fix building iwlmei
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches