Skip to contentSkip to conversation

sched/fair: fix boolreturn.cocci warning

PATCH New Jiapeng Chong 1 participant 1 message Mar 17, 2022 Scheduler

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sched/fair: fix boolreturn.cocci warning

Return statements in functions returning bool should use true/false instead of 1/0.

./kernel/sched/fair.c:9846:9-10: WARNING: return of 0/1 in function 'imbalanced_active_balance' with return type bool.

---
 kernel/sched/fair.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
kernel/sched/fair.c +2 -2
index 8bcc1dbc544c..bba2f9d94e53 100644
@@ -9843,9 +9843,9 @@ imbalanced_active_balance(struct lb_env *env)
 	 */
 	if ((env->migration_type == migrate_task) &&
 	    (sd->nr_balance_failed > sd->cache_nice_tries+2))
-		return 1;
+		return true;
 
-	return 0;
+	return false;
 }
 
 static int need_active_balance(struct lb_env *env)
Signature · 1 line
2.20.1.7.g153144c