Skip to contentSkip to conversation

scsi: hisi_sas: remove stray fallthrough annotation

PATCH Applied Dan Carpenter 3 participants 4 messages Mar 17, 2022 – Apr 7, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: hisi_sas: remove stray fallthrough annotation

This case statement doesn't fall through any more so remove the fallthrough annotation.

---
 drivers/scsi/hisi_sas/hisi_sas_main.c | 1 -
 1 file changed, 1 deletion(-)
drivers/scsi/hisi_sas/hisi_sas_main.c +0 -1
index 461ef8a76c4c..4bda2f6cb352 100644
@@ -442,7 +442,6 @@ void hisi_sas_task_deliver(struct hisi_hba *hisi_hba,
 	case SAS_PROTOCOL_INTERNAL_ABORT:
 		hisi_sas_task_prep_abort(hisi_hba, slot);
 		break;
-	fallthrough;
 	default:
 		return;
 	}
Signature · 1 line
2.20.1
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Dan Carpenter

This case statement doesn't fall through any more so remove the fallthrough annotation.

Thanks

Quoted 16 lines
---
  drivers/scsi/hisi_sas/hisi_sas_main.c | 1 -
  1 file changed, 1 deletion(-)
drivers/scsi/hisi_sas/hisi_sas_main.c +0 -1
index 461ef8a76c4c..4bda2f6cb352 100644
@@ -442,7 +442,6 @@ void hisi_sas_task_deliver(struct hisi_hba *hisi_hba,
  	case SAS_PROTOCOL_INTERNAL_ABORT:
  		hisi_sas_task_prep_abort(hisi_hba, slot);
  		break;
-	fallthrough;
  	default:
  		return;
  	}
#2 lore raw
In reply to Dan Carpenter

Dan,

Quoted 2 lines

This case statement doesn't fall through any more so remove the fallthrough annotation.

Applied to 5.18/scsi-staging, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering