Skip to contentSkip to conversation

amd64-agp: remove redundant assignment to variable i

PATCH In review Colin Ian King 2 participants 2 messages Mar 18, 2022 – Apr 4, 2022

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 amd64-agp: remove redundant assignment to variable i

Variable i is being assigned a value that is never read, it is being re-assigned later in a for-loop. The assignment is redundant and can be removed.

Cleans up clang scan build warning:
drivers/char/agp/amd64-agp.c:336:2: warning: Value stored to 'i' is never read [deadcode.DeadStores]

---
 drivers/char/agp/amd64-agp.c | 1 -
 1 file changed, 1 deletion(-)
drivers/char/agp/amd64-agp.c +0 -1
index dc78a4fb879e..5f64991c73bf 100644
@@ -333,7 +333,6 @@ static int cache_nbs(struct pci_dev *pdev, u32 cap_ptr)
 	if (!amd_nb_has_feature(AMD_NB_GART))
 		return -ENODEV;
 
-	i = 0;
 	for (i = 0; i < amd_nb_num(); i++) {
 		struct pci_dev *dev = node_to_amd_nb(i)->misc;
 		if (fix_northbridge(dev, pdev, cap_ptr) < 0) {
Signature · 1 line
2.35.1
Reviewed-by on v1 1/1
#1 lore raw
Quoted 10 lines · Colin Ian King

Variable i is being assigned a value that is never read, it is being re-assigned later in a for-loop. The assignment is redundant and can be removed.

Cleans up clang scan build warning:
drivers/char/agp/amd64-agp.c:336:2: warning: Value stored to 'i' is never read [deadcode.DeadStores]

Thanks for the patch!

Quoted 20 lines
---
 drivers/char/agp/amd64-agp.c | 1 -
 1 file changed, 1 deletion(-)
drivers/char/agp/amd64-agp.c +0 -2
index dc78a4fb879e..5f64991c73bf 100644
@@ -333,7 +333,6 @@ static int cache_nbs(struct pci_dev *pdev, u32 cap_ptr)
        if (!amd_nb_has_feature(AMD_NB_GART))
                return -ENODEV;
 
-       i = 0;
        for (i = 0; i < amd_nb_num(); i++) {
                struct pci_dev *dev = node_to_amd_nb(i)->misc;
                if (fix_northbridge(dev, pdev, cap_ptr) < 0) {
--

2.35.1

Signature · 2 lines
Thanks,
~Nick Desaulniers