fabrics: keep the backward compatibility
PATCH 1/1 fabrics: keep the backward compatibility
Don't print the message while disconnecting it is breaking blktests, see below without this patch :-
nvme/005 (reset local loopback target) [failed]
runtime 6.799s ... 6.814s
--- tests/nvme/005.out 2021-08-29 01:09:20.287901783 -0700
+++ /mnt/data/blktests/results/nodev/nvme/005.out.bad 2022-03-17 18:11:16.198191553 -0700
@@ -1,2 +1,3 @@
Running nvme/005
+Disconnected nvme1
Test completeWith this patch :-
blktests (master) # ./check nvme/005
nvme/005 (reset local loopback target) [passed]
runtime 6.807s ... 6.801s
Signed-off-by Chaitanya Kulkarni <[email protected]>
--- fabrics.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
fabrics.c +1 -3
@@ -791,9 +791,7 @@ int nvmf_disconnect(const char *desc, int argc, char **argv)return errno; } ret =nvme_disconnect_ctrl (c); -if (!ret) -printf ("Disconnected %s\n" , p); -else +if (ret)fprintf (stderr,"Failed to disconnect %s: %s\n" , p,nvme_strerror (errno));
Signature · 1 line
2.29.0
Daniel Wagner
AppliedQuoted 12 lines · Chaitanya Kulkarni
Don't print the message while disconnecting it is breaking blktests, see below without this patch :-
nvme/005 (reset local loopback target) [failed]
runtime 6.799s ... 6.814s --- tests/nvme/005.out 2021-08-29 01:09:20.287901783 -0700 +++ /mnt/data/blktests/results/nodev/nvme/005.out.bad 2022-03-17 18:11:16.198191553 -0700 @@ -1,2 +1,3 @@ Running nvme/005 +Disconnected nvme1 Test complete
Quoted 1 line
[...]
Applied, thanks!
[1/1] fabrics: keep the backward compatibility
commit: aeca69dcb807071545cee31d195c16fc6da23168
Best regards,
Signature · 1 line
Daniel Wagner <[email protected]>