nvmet: remove redundant assignment after left shift
Subsystems (3)
PATCH 1/1 nvmet: remove redundant assignment after left shift
The left shift is followed by a re-assignment back to cc_css, the assignment is redundant. Fix this by replacing the <<= operator with << instead.
Cleans up clang scan build warning:drivers/nvme/target/core.c:1124:10: warning: Although the value stored to 'cc_css' is used in the enclosing expression, the value is never actually read from 'cc_css' [deadcode.DeadStores]
--- drivers/nvme/target/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/target/core.c +1 -1
@@ -1121,7 +1121,7 @@ static inline u8 nvmet_cc_iocqes(u32 cc)static inline bool nvmet_css_supported (u8 cc_css) { -switch (cc_css <<=NVME_CC_CSS_SHIFT ) { +switch (cc_css <<NVME_CC_CSS_SHIFT ) {case NVME_CC_CSS_NVM :case NVME_CC_CSS_CSI :return true;
Signature · 1 line
2.35.1
Quoted 8 lines · Colin Ian King
The left shift is followed by a re-assignment back to
cc_css, the assignment is redundant. Fix this by replacing the <<= operator with << instead.Cleans up clang scan build warning:
drivers/nvme/target/core.c:1124:10: warning: Although the value stored to 'cc_css' is used in the enclosing expression, the value is never actually read from 'cc_css' [deadcode.DeadStores]
Looks good.
Quoted 11 lines · Colin Ian King
The left shift is followed by a re-assignment back to
cc_css, the assignment is redundant. Fix this by replacing the <<= operator with << instead.Cleans up clang scan build warning:
drivers/nvme/target/core.c:1124:10: warning: Although the value stored to 'cc_css' is used in the enclosing expression, the value is never actually read from 'cc_css' [deadcode.DeadStores]Signed-off-by Colin Ian King <[email protected]>
Thanks, looks good.
-ck
Thanks,
applied to nvme-5.18.