rtw89: handle potential uninitialized variable
Ping-Ke Shih
maintainerPATCH 1/1 rtw89: handle potential uninitialized variable
The smatch reports:
rtw8852a.c:1857 rtw8852a_btc_set_wl_txpwr_ctrl() error: uninitialized symbol '_cur'. rtw8852a.c:1858 rtw8852a_btc_set_wl_txpwr_ctrl() error: uninitialized symbol '_cur'.
This is because rtw89_mac_txpwr_read32() can possibly return before setting argument _cur, and the caller will use the uninitialized value. To fix this problem, check the return value of rtw89_mac_txpwr_read32().
--- drivers/net/wireless/realtek/rtw89/rtw8852a.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/net/wireless/realtek/rtw89/rtw8852a.c +2 -1
@@ -1841,7 +1841,8 @@ rtw8852a_btc_set_wl_txpwr_ctrl(struct rtw89_dev *rtwdev, u32 txpwr_val)u32 _cur, _wrt; \rtw89_debug (rtwdev,RTW89_DBG_TXPWR , \ "btc ctrl %s: 0x%x\n", #_case, _val); \ -rtw89_mac_txpwr_read32 (rtwdev,RTW89_PHY_0 , _reg, &_cur);\ +if (rtw89_mac_txpwr_read32 (rtwdev,RTW89_PHY_0 , _reg, &_cur))\ +break ; \rtw89_debug (rtwdev,RTW89_DBG_TXPWR , \"btc ctrl ori 0x%x: 0x%x\n" , _reg, _cur); \ _wrt = __do_clr(_val) ? \
Signature · 1 line
2.25.1
Quoted 9 lines · Ping-Ke Shih
The smatch reports:
rtw8852a.c:1857rtw8852a_btc_set_wl_txpwr_ctrl()error: uninitialized symbol '_cur'. rtw8852a.c:1858rtw8852a_btc_set_wl_txpwr_ctrl()error: uninitialized symbol '_cur'.This is because
rtw89_mac_txpwr_read32()can possibly return before setting argument_cur, and the caller will use the uninitialized value. To fix this problem, check the return value ofrtw89_mac_txpwr_read32().Signed-off-by Ping-Ke Shih <[email protected]>
Patch applied to wireless-next.git, thanks.
26bb93407c74 rtw89: handle potential uninitialized variable
Signature · 3 lines
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches