Skip to contentSkip to conversation

media: platform: Fix build error

PATCH In review Wang Hai 2 participants 2 messages Mar 18, 2022 Media (V4L/DVB)

lore
Share & tools
lore

Wang Hai

author
#0 lore raw

PATCH 1/1 media: platform: Fix build error

If VIDEO_IMX_MIPI_CSIS is y but VIDEO_DEV is n, building failed:

drivers/media/platform/nxp/imx-mipi-csis.o: in function `mipi_csis_remove':
imx-mipi-csis.c:(.text+0x1f0): undefined reference to `v4l2_async_nf_unregister'
ld: imx-mipi-csis.c:(.text+0x1f8): undefined reference to `v4l2_async_nf_cleanup'
ld: imx-mipi-csis.c:(.text+0x200): undefined reference to `v4l2_async_unregister_subdev'

Set VIDEO_IMX_MIPI_CSIS to depend on VIDEO_DEV to fix it

Fixes 4a598f62a03b ("media: platform/*/Kconfig: make manufacturer menus more uniform")
---
 drivers/media/platform/nxp/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/media/platform/nxp/Kconfig +1 -0
index 838abc9766b4..704fcf55697b 100644
@@ -6,6 +6,7 @@ comment "NXP drivers"
 
 config VIDEO_IMX_MIPI_CSIS
 	tristate "NXP MIPI CSI-2 CSIS receiver found on i.MX7 and i.MX8 models"
+	depends on VIDEO_DEV
 	select MEDIA_CONTROLLER
 	select V4L2_FWNODE
 	select VIDEO_V4L2_SUBDEV_API
Signature · 1 line
2.25.1
#1 lore raw

Hello Wang Hai

Quoted 7 lines · Wang Hai

If VIDEO_IMX_MIPI_CSIS is y but VIDEO_DEV is n, building failed:

drivers/media/platform/nxp/imx-mipi-csis.o: in function `mipi_csis_remove':
imx-mipi-csis.c:(.text+0x1f0): undefined reference to `v4l2_async_nf_unregister'
ld: imx-mipi-csis.c:(.text+0x1f8): undefined reference to `v4l2_async_nf_cleanup'
ld: imx-mipi-csis.c:(.text+0x200): undefined reference to `v4l2_async_unregister_subdev'

Quoted 5 lines

Set VIDEO_IMX_MIPI_CSIS to depend on VIDEO_DEV to fix it

Fixes 4a598f62a03b ("media: platform/*/Kconfig: make manufacturer menus more uniform")

Thanks, my understanding is that is fixed in Mauro's VIDEO_DEV rework. [PATCH v2 00/67] media: Kconfig/Makefile reorg

Quoted 19 lines
---
 drivers/media/platform/nxp/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/media/platform/nxp/Kconfig +1 -1
index 838abc9766b4..704fcf55697b 100644
@@ -6,6 +6,7 @@ comment "NXP drivers"
 
 config VIDEO_IMX_MIPI_CSIS
 	tristate "NXP MIPI CSI-2 CSIS receiver found on i.MX7 and i.MX8 models"
+	depends on VIDEO_DEV
 	select MEDIA_CONTROLLER
 	select V4L2_FWNODE
 	select VIDEO_V4L2_SUBDEV_API
--

2.25.1