Skip to contentSkip to conversation

package/spidev_test: fix spidev_test.c version in Config.in help text

PATCH In review Peter Seiderer 3 participants 4 messages Mar 18, 2022 – Mar 30, 2022

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 package/spidev_test: fix spidev_test.c version in Config.in help text

- fix spidev_test.c version in Config.in help text, version update to 4.10 (missing from commit 'spidev_test: bump to version in Linux 4.10' [1])

[1] https://git.buildroot.net/buildroot/commit/?id=a497a9fd6cdb518572282b1478279f476f870fb7

---
 package/spidev_test/Config.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
package/spidev_test/Config.in +1 -1
index 44990c66b6..2f3fcf4090 100644
@@ -9,7 +9,7 @@ config BR2_PACKAGE_SPIDEV_TEST
 	  proper operation of 'spidev_test'.
 
 	  The version used is based on your toolchain headers version,
-	  if it's older than 3.15 then 3.0 is used, otherwise 3.15
+	  if it's older than 3.15 then 3.0 is used, otherwise 4.10 
 	  is used.
 	  This means you won't have quad-pumped SPI support if your
 	  toolchain is too old.
Signature · 6 lines
2.35.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

PATCH 2/2 package/spidev_test: bump to version in Linux 5.8

- bump to version in Linux 5.8 (depends on SPI_TX_OCTAL/SPI_RX_OCTAL available since Linux 5.0)

Changelog (since 4.10):

9006a7b3220e spi: spidev_test: add option to continuously transfer data 35386dfd13b7 spi: spidev_test: Improve decoded text part of hex dump 84a14ae8c44f treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 178 020bd6c48ebd spi: spidev_test: Remove break after exit statement 1f3c36328a48 spi: spidev_test: Check input_tx and input_file first after parse options 470a072e1220 spi: spidev_test: Use perror() only if errno is not 0 896fa735084e spi: spidev_test: Add support for Octal mode data transfers 9ec8ade81224 spi: spidev_test: Use %u to format unsigned numbers bd2077915bfe spi: tools: Make default_tx/rx and input_tx static

- update Config.in help text

- indent hashes by 2 spaces

---
 package/spidev_test/Config.in        | 4 ++--
 package/spidev_test/spidev_test.hash | 5 +++--
 package/spidev_test/spidev_test.mk   | 5 ++++-
 3 files changed, 9 insertions(+), 5 deletions(-)
package/spidev_test/Config.in +2 -2
index 2f3fcf4090..81386adf7a 100644
@@ -9,8 +9,8 @@ config BR2_PACKAGE_SPIDEV_TEST
 	  proper operation of 'spidev_test'.
 
 	  The version used is based on your toolchain headers version,
-	  if it's older than 3.15 then 3.0 is used, otherwise 4.10 
-	  is used.
+	  if it's older than 3.15 then 3.0 is used, up to headers 4.20
+	  version 4.10 is used and otherwise version 5.8.
 	  This means you won't have quad-pumped SPI support if your
 	  toolchain is too old.
 
package/spidev_test/spidev_test.hash +3 -2
index 7bc4a27e45..867920fc78 100644
@@ -1,3 +1,4 @@
 # Locally calculated
-sha256 80471c330d8c0bf5ba6479c434a54a54bdd2dc59a703b9c76c2541ec04cfb8c3  spidev_test.c?id=v3.0
-sha256 3cf76b15d9a8644f3f5cbc0387cc02a7d4a392ade39788cbc6367cce98552e2f  spidev_test.c?id=v4.10
+sha256  80471c330d8c0bf5ba6479c434a54a54bdd2dc59a703b9c76c2541ec04cfb8c3  spidev_test.c?id=v3.0
+sha256  3cf76b15d9a8644f3f5cbc0387cc02a7d4a392ade39788cbc6367cce98552e2f  spidev_test.c?id=v4.10
+sha256  87329094ea3010eae9e65ad7ea2d2309e044845942414aa0ca8f1a7095b80178  spidev_test.c?id=v5.8
package/spidev_test/spidev_test.mk +4 -1
index bd2fcf6db3..6c5a9495a4 100644
@@ -10,7 +10,10 @@
 # If you need quad-pumped spi support you need to upgrade your toolchain.
 # Note that the location of spidev_test.c changes from v4.5 onwards.
 
-ifeq ($(BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_15),y)
+ifeq ($(BR2_TOOLCHAIN_HEADERS_AT_LEAST_5_0),y)
+SPIDEV_TEST_VERSION = 5.8
+SPIDEV_TEST_PATH = tools/spi
+else ifeq ($(BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_15),y)
 SPIDEV_TEST_VERSION = 4.10
 SPIDEV_TEST_PATH = tools/spi
 else
Signature · 6 lines
2.35.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw
In reply to Peter Seiderer
Quoted 15 lines · Peter Seiderer

- fix spidev_test.c version in Config.in help text, version update to 4.10 (missing from commit 'spidev_test: bump to version in Linux 4.10' [1])

[1] https://git.buildroot.net/buildroot/commit/?id=a497a9fd6cdb518572282b1478279f476f870fb7

---
  package/spidev_test/Config.in | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
package/spidev_test/Config.in +0 -0
index 44990c66b6..2f3fcf4090 100644

package/spidev_test/Config.in config BR2_PACKAGE_SPIDEV_TEST · line 12

Quoted 5 lines
package/spidev_test/Config.in +1 -1
@@ -9,7 +9,7 @@ config BR2_PACKAGE_SPIDEV_TEST
  	  proper operation of 'spidev_test'.
 
  	  The version used is based on your toolchain headers version,
-	  if it's older than 3.15 then 3.0 is used, otherwise 3.15
+	  if it's older than 3.15 then 3.0 is used, otherwise 4.10

There was an EOL whitespace here (which gets removed again in the next
commit). Not a big deal, but annoying for me because I automatically run check-package on each individual commit.

Anyway, both applied to master, thanks.

Regards,
Arnout

package/spidev_test/Config.in config BR2_PACKAGE_SPIDEV_TEST · line 15

Quoted 3 lines
package/spidev_test/Config.in +0 -0
  	  is used.
  	  This means you won't have quad-pumped SPI support if your
  	  toolchain is too old.

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot

#3 lore raw
In reply to Peter Seiderer
Quoted 8 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Peter" == Peter Seiderer <[email protected]> writes:

- fix spidev_test.c version in Config.in help text, version update to 4.10 (missing from commit 'spidev_test: bump to version in Linux 4.10' [1])

[1] https://git.buildroot.net/buildroot/commit/?id=a497a9fd6cdb518572282b1478279f476f870fb7

Committed to 2021.02.x and 2022.02.x, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot