Skip to contentSkip to conversation

memcontrol04: Copy from kselftest

PATCH In review Richard Palethorpe via ltp 3 participants 3 messages Mar 21, 2022 – Mar 22, 2022

lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 memcontrol04: Copy from kselftest

At first glance this test looks the same as memcontrol03. However there are some significant changes which complicate combining the two.

At least up to kernel (5.17) there appears to be a bug causing low memory events in F. There is presently no solution, so a known-bug tag with a link to Michal's investigation has been included.

---

We'd like to get this test merged to cut down on WIP. So I'm resubmitting it with the failure.

v4:
* Treat the events in F as a bug and add a known issue tag

V3:
* The cgroup -> cg API shortening and other changes were already merged
* Change the expected events in F depending on memory_recursiveprot. This should fix the issue reported by Li Wang

V2:
* Add more debugging info to the test output

 runtest/controllers                           |   1 +
 testcases/kernel/controllers/memcg/.gitignore |   1 +
 .../kernel/controllers/memcg/memcontrol04.c   | 253 ++++++++++++++++++
 3 files changed, 255 insertions(+)
 create mode 100644 testcases/kernel/controllers/memcg/memcontrol04.c
runtest/controllers +1 -0
index 4a6f919af..3108a2561 100644
@@ -20,6 +20,7 @@ memcg_control		memcg_control_test.sh
 memcontrol01 memcontrol01
 memcontrol02 memcontrol02
 memcontrol03 memcontrol03
+memcontrol04 memcontrol04
 
 cgroup_fj_function_debug cgroup_fj_function.sh debug
 cgroup_fj_function_cpuset cgroup_fj_function.sh cpuset
testcases/kernel/controllers/memcg/.gitignore +1 -0
index 49df1582c..3883cede6 100644
@@ -8,3 +8,4 @@
 memcontrol01
 memcontrol02
 memcontrol03
+memcontrol04
testcases/kernel/controllers/memcg/memcontrol04.c new file +253 -0

253 lines not on this page · raw message

Signature · 5 lines
2.35.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
Reviewed-by on v4 1/1
#1 lore raw

Richard Palethorpe <[email protected]> wrote:

At first glance this test looks the same as memcontrol03. However

Quoted 10 lines

there are some significant changes which complicate combining the two.

At least up to kernel (5.17) there appears to be a bug causing low memory events in F. There is presently no solution, so a known-bug tag with a link to Michal's investigation has been included.

Signature · 2 lines
Regards,
Li Wang
Signature · 2 lines
-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
#2 lore raw

Hi Li,

Quoted 9 lines · Li Wang

Richard Palethorpe <[email protected]> wrote:

At first glance this test looks the same as memcontrol03. However there are some significant changes which complicate combining the two.

At least up to kernel (5.17) there appears to be a bug causing low memory events in F. There is presently no solution, so a known-bug tag with a link to Michal's investigation has been included.

Quoted 5 lines

Pushed! thanks.

Signature · 5 lines
Thank you,
Richard.

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp