Skip to contentSkip to conversation

Adding support for am62xx

PATCH Superseded Ryan Eatmon 5 participants 16 messages Mar 22, 2022 – Aug 13, 2025

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover Adding support for am62xx

These patches add initial recipe support for am62xx.

Krunal Bhargav (1):
packagegroup-*-graphics: add virtual provider for AM62x GPU driver v2

Nishanth Menon (2):
ti-tisdk-makefile: adding uboot r5 config variable for am62xx
busybox: Enable rtcwake

 .../conf/distro/include/arago-prefs.inc              | 12 ++++++------
 .../recipes-core/busybox/busybox/defconfig           |  2 +-
 .../ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb       |  1 +
 3 files changed, 8 insertions(+), 7 deletions(-)
Signature · 1 line
2.17.1
#1 lore raw

PATCH 1/3 ti-tisdk-makefile: adding uboot r5 config variable for am62xx

From: Nishanth Menon <[email protected]>

lets add support for the latest of TI SoC.

---
 .../recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb     | 1 +
 1 file changed, 1 insertion(+)
meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb +1 -0
index 7bda8eed..7fb47bbb 100644
@@ -363,6 +363,7 @@ K3_UBOOT_MACHINE_R5_j7-evm = "j721e_evm_r5_config"
 K3_UBOOT_MACHINE_R5_j7-hs-evm = "j721e_hs_evm_r5_config"
 K3_UBOOT_MACHINE_R5_j7200-evm = "j7200_evm_r5_config"
 K3_UBOOT_MACHINE_R5_j721s2-evm = "j721s2_evm_r5_config"
+K3_UBOOT_MACHINE_R5_am62xx-evm = "am62xx_evm_r5_config"
 
 do_install_append_k3() {
     cat >> ${D}/Rules.make << __EOF__
Signature · 1 line
2.17.1
#2 lore raw

Re: [meta-arago][dunfell][PATCH 1/3] ti-tisdk-makefile: adding uboot r5 config variable for am62xx

Quoted 24 lines · Ryan Eatmon via lists.yoctoproject.org

From: Nishanth Menon <[email protected]>

lets add support for the latest of TI SoC.

---
 .../recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb     | 1 +
 1 file changed, 1 insertion(+)
meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb +1 -0
index 7bda8eed..7fb47bbb 100644
@@ -363,6 +363,7 @@ K3_UBOOT_MACHINE_R5_j7-evm = "j721e_evm_r5_config"
 K3_UBOOT_MACHINE_R5_j7-hs-evm = "j721e_hs_evm_r5_config"
 K3_UBOOT_MACHINE_R5_j7200-evm = "j7200_evm_r5_config"
 K3_UBOOT_MACHINE_R5_j721s2-evm = "j721s2_evm_r5_config"
+K3_UBOOT_MACHINE_R5_am62xx-evm = "am62xx_evm_r5_config"
 
 do_install_append_k3() {
     cat >> ${D}/Rules.make << __EOF__
Signature · 1 line
2.17.1

We probably also will need update to recipes-core/packagegroups/packagegroup-arago-tisdk-addons-sdk-host.bb and recipes-core/packagegroups/packagegroup-arago-tisdk-addons.bb

same update is needed in ti-tisdk-makefile
PRU_ICSS_INSTALL_TARGET_am64xx ..

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
#3 lore raw

PATCH 2/3 packagegroup-*-graphics: add virtual provider for AM62x GPU driver v2

In reply to Ryan Eatmon

From: Krunal Bhargav <[email protected]>

---
 .../conf/distro/include/arago-prefs.inc              | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
meta-arago-distro/conf/distro/include/arago-prefs.inc +6 -6
index a356c76c..7bc2ba52 100644
@@ -14,12 +14,12 @@ PREFERRED_PROVIDER_virtual/libgles2 = "ti-sgx-ddk-um"
 PREFERRED_PROVIDER_virtual/libgbm = "ti-sgx-ddk-um"
 PREFERRED_PROVIDER_virtual/gpudriver = "ti-sgx-ddk-km"
 
-# J7 has a Rogue GPU core
-PREFERRED_PROVIDER_virtual/egl_j7 = "ti-img-rogue-umlibs"
-PREFERRED_PROVIDER_virtual/libgles1_j7 = "ti-img-rogue-umlibs"
-PREFERRED_PROVIDER_virtual/libgles2_j7 = "ti-img-rogue-umlibs"
-PREFERRED_PROVIDER_virtual/libgbm_j7 = "ti-img-rogue-umlibs"
-PREFERRED_PROVIDER_virtual/gpudriver_j7 = "ti-img-rogue-driver"
+# K3 TI Platforms has a Rogue GPU core
+PREFERRED_PROVIDER_virtual/egl = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgles1 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgles2 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgbm = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/gpudriver = "ti-img-rogue-driver"
 
 # This is required when using keystone devices with graphical support
 # such as Qt5
Signature · 1 line
2.17.1
#4 lore raw

Re: [meta-arago][dunfell][PATCH 2/3] packagegroup-*-graphics: add virtual provider for AM62x GPU driver v2

Quoted 18 lines · Ryan Eatmon via lists.yoctoproject.org

From: Krunal Bhargav <[email protected]>

---
 .../conf/distro/include/arago-prefs.inc              | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
meta-arago-distro/conf/distro/include/arago-prefs.inc +0 -2
index a356c76c..7bc2ba52 100644
@@ -14,12 +14,12 @@ PREFERRED_PROVIDER_virtual/libgles2 = "ti-sgx-ddk-um"
 PREFERRED_PROVIDER_virtual/libgbm = "ti-sgx-ddk-um"
 PREFERRED_PROVIDER_virtual/gpudriver = "ti-sgx-ddk-km"
 
-# J7 has a Rogue GPU core
-PREFERRED_PROVIDER_virtual/egl_j7 = "ti-img-rogue-umlibs"

meta-arago-distro/conf/distro/include/arago-prefs.inc PREFERRED_PROVIDER_virtual/libgles2 = "ti-sgx-ddk-um" · line 22

Quoted 10 lines
meta-arago-distro/conf/distro/include/arago-prefs.inc +6 -4
-PREFERRED_PROVIDER_virtual/libgles1_j7 = "ti-img-rogue-umlibs"
-PREFERRED_PROVIDER_virtual/libgles2_j7 = "ti-img-rogue-umlibs"
-PREFERRED_PROVIDER_virtual/libgbm_j7 = "ti-img-rogue-umlibs"
-PREFERRED_PROVIDER_virtual/gpudriver_j7 = "ti-img-rogue-driver"
+# K3 TI Platforms has a Rogue GPU core
+PREFERRED_PROVIDER_virtual/egl = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgles1 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgles2 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgbm = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/gpudriver = "ti-img-rogue-driver"

How does this apply to k3 and leave non-k3 alone? Also, am65x for example is sgx.

Quoted 17 lines
meta-arago-distro/conf/distro/include/arago-prefs.inc +0 -0
 # This is required when using keystone devices with graphical support
 # such as Qt5
Signature · 11 lines
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#13711): https://lists.yoctoproject.org/g/meta-arago/message/13711
Mute This Topic: https://lists.yoctoproject.org/mt/89960456/5513541
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-arago/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
#5 lore raw

Re: [meta-arago][dunfell][PATCH 2/3] packagegroup-*-graphics: add virtual provider for AM62x GPU driver v2

Quoted 17 lines · Nishanth Menon via lists.yoctoproject.org
Quoted 16 lines · Ryan Eatmon via lists.yoctoproject.org

From: Krunal Bhargav <[email protected]>

---
  .../conf/distro/include/arago-prefs.inc              | 12 ++++++------
  1 file changed, 6 insertions(+), 6 deletions(-)
meta-arago-distro/conf/distro/include/arago-prefs.inc +0 -0
index a356c76c..7bc2ba52 100644
@@ -14,12 +14,12 @@ PREFERRED_PROVIDER_virtual/libgles2 = "ti-sgx-ddk-um"
  PREFERRED_PROVIDER_virtual/libgbm = "ti-sgx-ddk-um"
  PREFERRED_PROVIDER_virtual/gpudriver = "ti-sgx-ddk-km"
 
Quoted 16 lines

meta-arago-distro/conf/distro/include/arago-prefs.inc PREFERRED_PROVIDER_virtual/libgles2 = "ti-sgx-ddk-um" · line 22

Quoted 12 lines
meta-arago-distro/conf/distro/include/arago-prefs.inc +6 -6
-# J7 has a Rogue GPU core
-PREFERRED_PROVIDER_virtual/egl_j7 = "ti-img-rogue-umlibs"
-PREFERRED_PROVIDER_virtual/libgles1_j7 = "ti-img-rogue-umlibs"
-PREFERRED_PROVIDER_virtual/libgles2_j7 = "ti-img-rogue-umlibs"
-PREFERRED_PROVIDER_virtual/libgbm_j7 = "ti-img-rogue-umlibs"
-PREFERRED_PROVIDER_virtual/gpudriver_j7 = "ti-img-rogue-driver"
+# K3 TI Platforms has a Rogue GPU core
+PREFERRED_PROVIDER_virtual/egl = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgles1 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgles2 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgbm = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/gpudriver = "ti-img-rogue-driver"

How does this apply to k3 and leave non-k3 alone? Also, am65x for example is sgx.

That is a very good point. This will mess up SGX platforms. I wish we had k3_ as the prefix for the name here for all the k3 platforms.

So I guess the only solution is leave all the _j7 as they were

and add:
+PREFERRED_PROVIDER_virtual/egl_am62 = "ti-img-rogue-umlibs" +PREFERRED_PROVIDER_virtual/libgles1_am62 = "ti-img-rogue-umlibs" +PREFERRED_PROVIDER_virtual/libgles2_am62 = "ti-img-rogue-umlibs" +PREFERRED_PROVIDER_virtual/libgbm_am62 = "ti-img-rogue-umlibs" +PREFERRED_PROVIDER_virtual/gpudriver_am62 = "ti-img-rogue-driver"

Is there anything cleverer?

Quoted 12 lines
Quoted 11 lines
meta-arago-distro/conf/distro/include/arago-prefs.inc +0 -0
  # This is required when using keystone devices with graphical support
  # such as Qt5
Signature · 1 line
2.17.1
#6 lore raw

Re: [meta-arago][dunfell][PATCH 2/3] packagegroup-*-graphics: add virtual provider for AM62x GPU driver v2

Quoted 36 lines · Darren via lists.yoctoproject.org
Quoted 23 lines · Nishanth Menon via lists.yoctoproject.org
Quoted 22 lines · Ryan Eatmon via lists.yoctoproject.org

From: Krunal Bhargav <[email protected]>

---
 .../conf/distro/include/arago-prefs.inc              | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
meta-arago-distro/conf/distro/include/arago-prefs.inc +1 -6
index a356c76c..7bc2ba52 100644
@@ -14,12 +14,12 @@ PREFERRED_PROVIDER_virtual/libgles2 = "ti-sgx-ddk-um"
 PREFERRED_PROVIDER_virtual/libgbm = "ti-sgx-ddk-um"
 PREFERRED_PROVIDER_virtual/gpudriver = "ti-sgx-ddk-km"
-# J7 has a Rogue GPU core
-PREFERRED_PROVIDER_virtual/egl_j7 = "ti-img-rogue-umlibs"
-PREFERRED_PROVIDER_virtual/libgles1_j7 = "ti-img-rogue-umlibs"
-PREFERRED_PROVIDER_virtual/libgles2_j7 = "ti-img-rogue-umlibs"
-PREFERRED_PROVIDER_virtual/libgbm_j7 = "ti-img-rogue-umlibs"
-PREFERRED_PROVIDER_virtual/gpudriver_j7 = "ti-img-rogue-driver"
+# K3 TI Platforms has a Rogue GPU core
Quoted 9 lines

meta-arago-distro/conf/distro/include/arago-prefs.inc PREFERRED_PROVIDER_virtual/libgles2 = "ti-sgx-ddk-um" · line 22

Quoted 5 lines
meta-arago-distro/conf/distro/include/arago-prefs.inc +5 -0
+PREFERRED_PROVIDER_virtual/egl = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgles1 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgles2 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgbm = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/gpudriver = "ti-img-rogue-driver"

How does this apply to k3 and leave non-k3 alone? Also, am65x for example is sgx.

Quoted 3 lines

That is a very good point. This will mess up SGX platforms. I
wish we had k3_ as the prefix for the name here for all the k3 platforms.

There is "k3" defined and you can do _k3 override to address all K3 platforms, but again, some are SGX and some are RGX...

Review

Quoted 8 lines

So I guess the only solution is leave all the _j7 as they were

and add:

(quoted diff) +5 -0
+PREFERRED_PROVIDER_virtual/egl_am62 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgles1_am62 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgles2_am62 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgbm_am62 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/gpudriver_am62 = "ti-img-rogue-driver"

And there's no "am62" defined, but "am62xx" :)

Quoted 6 lines

Is there anything cleverer?

Quoted 4 lines
Quoted 4 lines
meta-arago-distro/conf/distro/include/arago-prefs.inc +0 -0
 # This is required when using keystone devices with graphical support
 # such as Qt5
Signature · 1 line
2.17.1
Signature · 4 lines
Regards,
Denys Dmytriyenko <[email protected]>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186  6D76 4209 0272 9A92 C964
#7 lore raw

Re: [meta-arago][dunfell][PATCH 2/3] packagegroup-*-graphics: add virtual provider for AM62x GPU driver v2

Quoted 47 lines · Denys Dmytriyenko
Quoted 36 lines · Darren via lists.yoctoproject.org
Quoted 23 lines · Nishanth Menon via lists.yoctoproject.org
Quoted 22 lines · Ryan Eatmon via lists.yoctoproject.org

From: Krunal Bhargav <[email protected]>

---
  .../conf/distro/include/arago-prefs.inc              | 12 ++++++------
  1 file changed, 6 insertions(+), 6 deletions(-)
meta-arago-distro/conf/distro/include/arago-prefs.inc +1 -6
index a356c76c..7bc2ba52 100644
@@ -14,12 +14,12 @@ PREFERRED_PROVIDER_virtual/libgles2 = "ti-sgx-ddk-um"
  PREFERRED_PROVIDER_virtual/libgbm = "ti-sgx-ddk-um"
  PREFERRED_PROVIDER_virtual/gpudriver = "ti-sgx-ddk-km"
-# J7 has a Rogue GPU core
-PREFERRED_PROVIDER_virtual/egl_j7 = "ti-img-rogue-umlibs"
-PREFERRED_PROVIDER_virtual/libgles1_j7 = "ti-img-rogue-umlibs"
-PREFERRED_PROVIDER_virtual/libgles2_j7 = "ti-img-rogue-umlibs"
-PREFERRED_PROVIDER_virtual/libgbm_j7 = "ti-img-rogue-umlibs"
-PREFERRED_PROVIDER_virtual/gpudriver_j7 = "ti-img-rogue-driver"
+# K3 TI Platforms has a Rogue GPU core
Quoted 9 lines

meta-arago-distro/conf/distro/include/arago-prefs.inc PREFERRED_PROVIDER_virtual/libgles2 = "ti-sgx-ddk-um" · line 22

Quoted 5 lines
meta-arago-distro/conf/distro/include/arago-prefs.inc +5 -0
+PREFERRED_PROVIDER_virtual/egl = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgles1 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgles2 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgbm = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/gpudriver = "ti-img-rogue-driver"

How does this apply to k3 and leave non-k3 alone? Also, am65x for example is sgx.

Quoted 3 lines

That is a very good point. This will mess up SGX platforms. I
wish we had k3_ as the prefix for the name here for all the k3 platforms.

There is "k3" defined and you can do _k3 override to address all K3 platforms, but again, some are SGX and some are RGX...

Quoted 2 lines

So I guess the only solution is leave all the _j7 as they were

Quoted 9 lines

Review

Quoted 6 lines

and add:

(quoted diff) +5 -0
+PREFERRED_PROVIDER_virtual/egl_am62 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgles1_am62 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgles2_am62 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgbm_am62 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/gpudriver_am62 = "ti-img-rogue-driver"

And there's no "am62" defined, but "am62xx" :)

Isn't it a partial pattern match? If it is not the _j7 won't work for j721s2 either.

Quoted 8 lines
Quoted 7 lines

Is there anything cleverer?

Quoted 4 lines
Quoted 4 lines
meta-arago-distro/conf/distro/include/arago-prefs.inc +0 -0
  # This is required when using keystone devices with graphical support
  # such as Qt5
Signature · 1 line
2.17.1
#8 lore raw

Re: [meta-arago][dunfell][PATCH 2/3] packagegroup-*-graphics: add virtual provider for AM62x GPU driver v2

Quoted 60 lines · Darren
Quoted 47 lines · Denys Dmytriyenko
Quoted 36 lines · Darren via lists.yoctoproject.org
Quoted 23 lines · Nishanth Menon via lists.yoctoproject.org
Quoted 22 lines · Ryan Eatmon via lists.yoctoproject.org

From: Krunal Bhargav <[email protected]>

---
 .../conf/distro/include/arago-prefs.inc              | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
meta-arago-distro/conf/distro/include/arago-prefs.inc +1 -6
index a356c76c..7bc2ba52 100644
@@ -14,12 +14,12 @@ PREFERRED_PROVIDER_virtual/libgles2 = "ti-sgx-ddk-um"
 PREFERRED_PROVIDER_virtual/libgbm = "ti-sgx-ddk-um"
 PREFERRED_PROVIDER_virtual/gpudriver = "ti-sgx-ddk-km"
-# J7 has a Rogue GPU core
-PREFERRED_PROVIDER_virtual/egl_j7 = "ti-img-rogue-umlibs"
-PREFERRED_PROVIDER_virtual/libgles1_j7 = "ti-img-rogue-umlibs"
-PREFERRED_PROVIDER_virtual/libgles2_j7 = "ti-img-rogue-umlibs"
-PREFERRED_PROVIDER_virtual/libgbm_j7 = "ti-img-rogue-umlibs"
-PREFERRED_PROVIDER_virtual/gpudriver_j7 = "ti-img-rogue-driver"
+# K3 TI Platforms has a Rogue GPU core
Quoted 9 lines

meta-arago-distro/conf/distro/include/arago-prefs.inc PREFERRED_PROVIDER_virtual/libgles2 = "ti-sgx-ddk-um" · line 22

Quoted 5 lines
meta-arago-distro/conf/distro/include/arago-prefs.inc +5 -0
+PREFERRED_PROVIDER_virtual/egl = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgles1 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgles2 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgbm = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/gpudriver = "ti-img-rogue-driver"

How does this apply to k3 and leave non-k3 alone? Also, am65x for example is sgx.

Quoted 3 lines

That is a very good point. This will mess up SGX platforms. I
wish we had k3_ as the prefix for the name here for all the k3 platforms.

There is "k3" defined and you can do _k3 override to address all K3 platforms, but again, some are SGX and some are RGX...

Quoted 2 lines

So I guess the only solution is leave all the _j7 as they were

Quoted 9 lines

Review

Quoted 6 lines

and add:

(quoted diff) +5 -0
+PREFERRED_PROVIDER_virtual/egl_am62 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgles1_am62 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgles2_am62 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgbm_am62 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/gpudriver_am62 = "ti-img-rogue-driver"

And there's no "am62" defined, but "am62xx" :)

Quoted 2 lines

Isn't it a partial pattern match? If it is not the _j7 won't work
for j721s2 either.

No, it's not a partial pattern match. Overrides use exact matches only, so those have to be defined. Specifically these overrides come from SOC_FAMILY variable and there are definitions for "k3", "j7", but there's no "j721s2" SOC_FAMILY defined, so you cannot use _j721s2, nor _j7 will match it.
https://git.yoctoproject.org/meta-ti/tree/conf/machine/include?h=dunfell

Signature · 4 lines
Regards,
Denys Dmytriyenko <[email protected]>
PGP: 0x420902729A92C964 - https://denix.org/0x420902729A92C964
Fingerprint: 25FC E4A5 8A72 2F69 1186  6D76 4209 0272 9A92 C964
#9 lore raw

Re: [meta-arago][dunfell][PATCH 2/3] packagegroup-*-graphics: add virtual provider for AM62x GPU driver v2

Quoted 61 lines · Denys Dmytriyenko
Quoted 60 lines · Darren
Quoted 56 lines · Denys Dmytriyenko
Quoted 36 lines · Darren via lists.yoctoproject.org
Quoted 23 lines · Nishanth Menon via lists.yoctoproject.org
Quoted 22 lines · Ryan Eatmon via lists.yoctoproject.org

From: Krunal Bhargav <[email protected]>

---
  .../conf/distro/include/arago-prefs.inc              | 12 ++++++------
  1 file changed, 6 insertions(+), 6 deletions(-)
meta-arago-distro/conf/distro/include/arago-prefs.inc +1 -6
index a356c76c..7bc2ba52 100644
@@ -14,12 +14,12 @@ PREFERRED_PROVIDER_virtual/libgles2 = "ti-sgx-ddk-um"
  PREFERRED_PROVIDER_virtual/libgbm = "ti-sgx-ddk-um"
  PREFERRED_PROVIDER_virtual/gpudriver = "ti-sgx-ddk-km"
-# J7 has a Rogue GPU core
-PREFERRED_PROVIDER_virtual/egl_j7 = "ti-img-rogue-umlibs"
-PREFERRED_PROVIDER_virtual/libgles1_j7 = "ti-img-rogue-umlibs"
-PREFERRED_PROVIDER_virtual/libgles2_j7 = "ti-img-rogue-umlibs"
-PREFERRED_PROVIDER_virtual/libgbm_j7 = "ti-img-rogue-umlibs"
-PREFERRED_PROVIDER_virtual/gpudriver_j7 = "ti-img-rogue-driver"
+# K3 TI Platforms has a Rogue GPU core
Quoted 9 lines

meta-arago-distro/conf/distro/include/arago-prefs.inc PREFERRED_PROVIDER_virtual/libgles2 = "ti-sgx-ddk-um" · line 22

Quoted 5 lines
meta-arago-distro/conf/distro/include/arago-prefs.inc +5 -0
+PREFERRED_PROVIDER_virtual/egl = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgles1 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgles2 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgbm = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/gpudriver = "ti-img-rogue-driver"

How does this apply to k3 and leave non-k3 alone? Also, am65x for example is sgx.

Quoted 3 lines

That is a very good point. This will mess up SGX platforms. I
wish we had k3_ as the prefix for the name here for all the k3 platforms.

There is "k3" defined and you can do _k3 override to address all K3 platforms, but again, some are SGX and some are RGX...

Review

Quoted 8 lines

So I guess the only solution is leave all the _j7 as they were

and add:

(quoted diff) +5 -0
+PREFERRED_PROVIDER_virtual/egl_am62 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgles1_am62 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgles2_am62 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgbm_am62 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/gpudriver_am62 = "ti-img-rogue-driver"

And there's no "am62" defined, but "am62xx" :)

Quoted 9 lines
Quoted 2 lines

Isn't it a partial pattern match? If it is not the _j7 won't work
for j721s2 either.

No, it's not a partial pattern match. Overrides use exact matches only, so those have to be defined. Specifically these overrides come from SOC_FAMILY variable and there are definitions for "k3", "j7", but there's no "j721s2" SOC_FAMILY defined, so you cannot use _j721s2, nor _j7 will match it.
https://git.yoctoproject.org/meta-ti/tree/conf/machine/include?h=dunfell

Thanks for the explanation Denys, I was making totally wrong assumption on how that was being derived.

So we could actually use _k3 and get am62xx-evm, j721s2-evm and j7-evm with a single override. All k3's use the IMG Rogue driver if they have a GPU.

#10 lore raw

Re: [meta-arago][dunfell][PATCH 2/3] packagegroup-*-graphics: add virtual provider for AM62x GPU driver v2

Quoted 74 lines · Darren
Quoted 61 lines · Denys Dmytriyenko
Quoted 60 lines · Darren
Quoted 56 lines · Denys Dmytriyenko
Quoted 36 lines · Darren via lists.yoctoproject.org
Quoted 23 lines · Nishanth Menon via lists.yoctoproject.org
Quoted 22 lines · Ryan Eatmon via lists.yoctoproject.org

From: Krunal Bhargav <[email protected]>

---
 .../conf/distro/include/arago-prefs.inc              | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
meta-arago-distro/conf/distro/include/arago-prefs.inc +1 -6
index a356c76c..7bc2ba52 100644
@@ -14,12 +14,12 @@ PREFERRED_PROVIDER_virtual/libgles2 = "ti-sgx-ddk-um"
 PREFERRED_PROVIDER_virtual/libgbm = "ti-sgx-ddk-um"
 PREFERRED_PROVIDER_virtual/gpudriver = "ti-sgx-ddk-km"
-# J7 has a Rogue GPU core
-PREFERRED_PROVIDER_virtual/egl_j7 = "ti-img-rogue-umlibs"
-PREFERRED_PROVIDER_virtual/libgles1_j7 = "ti-img-rogue-umlibs"
-PREFERRED_PROVIDER_virtual/libgles2_j7 = "ti-img-rogue-umlibs"
-PREFERRED_PROVIDER_virtual/libgbm_j7 = "ti-img-rogue-umlibs"
-PREFERRED_PROVIDER_virtual/gpudriver_j7 = "ti-img-rogue-driver"
+# K3 TI Platforms has a Rogue GPU core
Quoted 9 lines

meta-arago-distro/conf/distro/include/arago-prefs.inc PREFERRED_PROVIDER_virtual/libgles2 = "ti-sgx-ddk-um" · line 21

Quoted 5 lines
meta-arago-distro/conf/distro/include/arago-prefs.inc +5 -0
+PREFERRED_PROVIDER_virtual/egl = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgles1 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgles2 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgbm = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/gpudriver = "ti-img-rogue-driver"

How does this apply to k3 and leave non-k3 alone? Also, am65x for example is sgx.

Quoted 3 lines

That is a very good point. This will mess up SGX platforms. I
wish we had k3_ as the prefix for the name here for all the k3 platforms.

There is "k3" defined and you can do _k3 override to address all K3 platforms, but again, some are SGX and some are RGX...

Review

Quoted 8 lines

So I guess the only solution is leave all the _j7 as they were

and add:

(quoted diff) +5 -0
+PREFERRED_PROVIDER_virtual/egl_am62 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgles1_am62 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgles2_am62 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/libgbm_am62 = "ti-img-rogue-umlibs"
+PREFERRED_PROVIDER_virtual/gpudriver_am62 = "ti-img-rogue-driver"

And there's no "am62" defined, but "am62xx" :)

Quoted 9 lines
Quoted 2 lines

Isn't it a partial pattern match? If it is not the _j7 won't work
for j721s2 either.

No, it's not a partial pattern match. Overrides use exact matches only, so those have to be defined. Specifically these overrides come from SOC_FAMILY variable and there are definitions for "k3", "j7", but there's no "j721s2" SOC_FAMILY defined, so you cannot use _j721s2, nor _j7 will match it.
https://git.yoctoproject.org/meta-ti/tree/conf/machine/include?h=dunfell

Quoted 6 lines

Thanks for the explanation Denys, I was making totally wrong assumption on how that was being derived.

So we could actually use _k3 and get am62xx-evm, j721s2-evm and j7-evm with a single override. All k3's use the IMG Rogue driver if they have a GPU.

What about am65xx? It is SGX.
And I assume am64xx and j7200 have no GPU.
If am65xx is the only exception in K3 family, then we could flip the compatibility setting.

Signature · 1 line
Denys
#11 lore raw

PATCH 3/3 busybox: Enable rtcwake

In reply to Ryan Eatmon

From: Nishanth Menon <[email protected]>

This is esp useful for testing low power states with a minimal system.

---
 meta-arago-distro/recipes-core/busybox/busybox/defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-arago-distro/recipes-core/busybox/busybox/defconfig +1 -1
index 65470bc7..351b80d4 100644
@@ -583,7 +583,7 @@ CONFIG_PIVOT_ROOT=y
 CONFIG_RDATE=y
 # CONFIG_RDEV is not set
 # CONFIG_READPROFILE is not set
-# CONFIG_RTCWAKE is not set
+CONFIG_RTCWAKE=y
 # CONFIG_SCRIPT is not set
 # CONFIG_SCRIPTREPLAY is not set
 # CONFIG_SETARCH is not set
Signature · 1 line
2.17.1
#12 lore raw

Re: [meta-arago][dunfell][PATCH 3/3] busybox: Enable rtcwake

Quoted 15 lines · Ryan Eatmon via lists.yoctoproject.org

From: Nishanth Menon <[email protected]>

This is esp useful for testing low power states with a minimal system.

---
 meta-arago-distro/recipes-core/busybox/busybox/defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta-arago-distro/recipes-core/busybox/busybox/defconfig +0 -0
index 65470bc7..351b80d4 100644

meta-arago-distro/recipes-core/busybox/busybox/defconfig CONFIG_PIVOT_ROOT=y · line 589

Quoted 8 lines
meta-arago-distro/recipes-core/busybox/busybox/defconfig +1 -1
@@ -583,7 +583,7 @@ CONFIG_PIVOT_ROOT=y
 CONFIG_RDATE=y
 # CONFIG_RDEV is not set
 # CONFIG_READPROFILE is not set
-# CONFIG_RTCWAKE is not set
+CONFIG_RTCWAKE=y
 # CONFIG_SCRIPT is not set
 # CONFIG_SCRIPTREPLAY is not set
 # CONFIG_SETARCH is not set

OR we could use base-image cpio
..

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
#13 lore raw

Re: [meta-arago][dunfell][PATCH 3/3] busybox: Enable rtcwake

Quoted 11 lines · Nishanth Menon
Quoted 10 lines · Ryan Eatmon via lists.yoctoproject.org

From: Nishanth Menon <[email protected]>

This is esp useful for testing low power states with a minimal system.

---
  meta-arago-distro/recipes-core/busybox/busybox/defconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 17 lines

meta-arago-distro/recipes-core/busybox/busybox/defconfig CONFIG_PIVOT_ROOT=y · line 589

Quoted 13 lines
meta-arago-distro/recipes-core/busybox/busybox/defconfig +1 -1
index 65470bc7..351b80d4 100644
@@ -583,7 +583,7 @@ CONFIG_PIVOT_ROOT=y
  CONFIG_RDATE=y
  # CONFIG_RDEV is not set
  # CONFIG_READPROFILE is not set
-# CONFIG_RTCWAKE is not set
+CONFIG_RTCWAKE=y
  # CONFIG_SCRIPT is not set
  # CONFIG_SCRIPTREPLAY is not set
  # CONFIG_SETARCH is not set

OR we could use base-image cpio
..

Are you saying we don't need this patch and do it it a different way? I can drop this patch for now...

Signature · 2 lines
Ryan Eatmon
[email protected]
#14 lore raw

Re: [meta-arago][dunfell][PATCH 3/3] busybox: Enable rtcwake

Quoted 32 lines · Ryan Eatmon
Quoted 11 lines · Nishanth Menon
Quoted 10 lines · Ryan Eatmon via lists.yoctoproject.org

From: Nishanth Menon <[email protected]>

This is esp useful for testing low power states with a minimal system.

---
  meta-arago-distro/recipes-core/busybox/busybox/defconfig | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 17 lines

meta-arago-distro/recipes-core/busybox/busybox/defconfig CONFIG_PIVOT_ROOT=y · line 589

Quoted 13 lines
meta-arago-distro/recipes-core/busybox/busybox/defconfig +1 -1
index 65470bc7..351b80d4 100644
@@ -583,7 +583,7 @@ CONFIG_PIVOT_ROOT=y
  CONFIG_RDATE=y
  # CONFIG_RDEV is not set
  # CONFIG_READPROFILE is not set
-# CONFIG_RTCWAKE is not set
+CONFIG_RTCWAKE=y
  # CONFIG_SCRIPT is not set
  # CONFIG_SCRIPTREPLAY is not set
  # CONFIG_SETARCH is not set

OR we could use base-image cpio
..

Quoted 2 lines

Are you saying we don't need this patch and do it it a different way? I can drop this patch for now...

for lpm, we could use baseimage cpio itself instead of tiny-image.

Signature · 3 lines
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D
#15 lore raw
In reply to Ryan Eatmon

meta-arago / na / 20220322193554.24404-1-reatmon

PRC Results: FAIL

=========================================================
check-yocto-patches: PASS
=========================================================
Patches
----------------------------------------
All patches passed

=========================================================
apply-yocto-patch: FAIL
=========================================================
dunfell
=====================
Summary:
- Patch Series: [meta-arago][dunfell][PATCH 0/3] Adding support for am62xx
- Submitter: From: Ryan Eatmon <[email protected]>
- Date: Date: Tue, 22 Mar 2022 14:35:51 -0500
- Num Patches: 3
- Mailing List (public inbox) Commit SHA: 62c45955c11f5703f31475e6545e759b115eba62

Applied to:
- Repository: lcpd-prc-meta-arago
- Base Branch: dunfell
- Commit Author: Randolph Sapp <[email protected]>
- Commit Subject: meta-arago-distro: linux-firmware: remove cadence firmware
- Commit SHA: 86d19ced20934c8383c8a39f88d97c72e7e929ee

Patches
----------------------------------------
FAIL - [meta-arago][dunfell][PATCH 1/3] ti-tisdk-makefile: adding uboot r5 config variable for am62xx
error: patch failed: meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb:363
error: meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile_1.0.bb: patch does not apply
Applying: ti-tisdk-makefile: adding uboot r5 config variable for am62xx
Patch failed at 0001 ti-tisdk-makefile: adding uboot r5 config variable for am62xx