generic/066: attr1 is still there after log replay on f2fs
PATCH v3 1/1 generic/066: attr1 is still there after log replay on f2fs
The test fail on f2fs:
xattr names and values after second fsync log replay:
# file: SCRATCH_MNT/foobar
+user.attr1="val1"
user.attr3="val3"
attr1 is still there after log replay. f2fs doesn't support fs-op level transaction functionality. so it have no way to persist all metadata updates in one transaction. We can use "fastboot" mountoption for this case, so during last fsync on qwerty, f2fs can trigger a checkpoint which will persist all metadata updates before fsync().
---
v3: merge "fastboot" with original mount options
tests/generic/066 | 8 ++++++++ 1 file changed, 8 insertions(+)
tests/generic/066 +8 -0
@@ -56,6 +56,14 @@ sync $SETFATTR_PROG -x user.attr2 $SCRATCH_MNT/foobar $XFS_IO_PROG -c "fsync" $SCRATCH_MNT/foobar +# f2fs doesn't support fs-op level transaction functionality. so it have no way +# to persist all metadata updates in one transaction. We can use "fastboot" +# mountoption for this case, so during last fsync on qwerty, f2fs can trigger a +# checkpoint which will persist all metadata updates before fsync(). +if [ $FSTYP = "f2fs" ]; then + export MOUNT_OPTIONS="-o fastboot $MOUNT_OPTIONS" +fi + _flakey_drop_and_remount # After the fsync log is replayed, the file should have only 2 xattrs, the ones
Signature · 1 line
2.13.6
Quoted 6 lines · On 2022/3/23 16:37, Sun Ke via Linux-f2fs-devel wrote:
The test fail on f2fs:
xattr names and values after second fsync log replay:
# file: SCRATCH_MNT/foobar
+user.attr1="val1"
user.attr3="val3"
Quoted 8 lines
attr1 is still there after log replay. f2fs doesn't support fs-op level transaction functionality. so it have no way to persist all metadata updates in one transaction. We can use "fastboot" mountoption for this case, so during last fsync on qwerty, f2fs can trigger a checkpoint which will persist all metadata updates before
fsync().Suggested-by Chao Yu <[email protected]>Signed-off-by Sun Ke <[email protected]>
Thanks,