Skip to contentSkip to conversation

modify PBL values in snps,dwmac.yaml

PATCH New Biao Huang 3 participants 5 messages Mar 24, 2022 – Mar 25, 2022

Subsystems (4)
lore
Share & tools
lore

Biao Huang

author
#0 lore raw

cover modify PBL values in snps,dwmac.yaml

This patch should be applied befor the series:
"[PATCH net-next v13 0/7] MediaTek Ethernet Patches on MT8195"
to avoid dtbo build failings.

@Rob, please review it, thanks very much.

Biao Huang (1):
dt-bindings: net: snps,dwmac: modify available values of PBL

 Documentation/devicetree/bindings/net/snps,dwmac.yaml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Signature · 1 line
2.25.1
author
#1 lore raw

PATCH 1/1 dt-bindings: net: snps,dwmac: modify available values of PBL

PBL can be any of the following values: 1, 2, 4, 8, 16 or 32 according to the datasheet, so modify available values of PBL in snps,dwmac.yaml.

---
 Documentation/devicetree/bindings/net/snps,dwmac.yaml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
Documentation/devicetree/bindings/net/snps,dwmac.yaml +3 -3
index 42689b7d03a2..856cd0b7a5b0 100644
@@ -334,21 +334,21 @@ allOf:
           description:
             Programmable Burst Length (tx and rx)
           $ref: /schemas/types.yaml#/definitions/uint32
-          enum: [2, 4, 8]
+          enum: [1, 2, 4, 8, 16, 32]
 
         snps,txpbl:
           description:
             Tx Programmable Burst Length. If set, DMA tx will use this
             value rather than snps,pbl.
           $ref: /schemas/types.yaml#/definitions/uint32
-          enum: [2, 4, 8]
+          enum: [1, 2, 4, 8, 16, 32]
 
         snps,rxpbl:
           description:
             Rx Programmable Burst Length. If set, DMA rx will use this
             value rather than snps,pbl.
           $ref: /schemas/types.yaml#/definitions/uint32
-          enum: [2, 4, 8]
+          enum: [1, 2, 4, 8, 16, 32]
 
         snps,no-pbl-x8:
           $ref: /schemas/types.yaml#/definitions/flag
Signature · 1 line
2.25.1
maintainer
#2 lore raw

Re: [PATCH net-next] dt-bindings: net: snps,dwmac: modify available values of PBL

Hello,

Quoted 5 lines · Biao Huang

PBL can be any of the following values: 1, 2, 4, 8, 16 or 32 according to the datasheet, so modify available values of PBL in snps,dwmac.yaml.

@Rob: my understanding is that this patch will go through your tree, despite being marked as net-next. Please correct me if I'm wrong, thanks!

Paolo

maintainer
#3 lore raw

Re: [PATCH net-next] dt-bindings: net: snps,dwmac: modify available values of PBL

In reply to Biao Huang
Quoted 9 lines · Biao Huang

PBL can be any of the following values: 1, 2, 4, 8, 16 or 32 according to the datasheet, so modify available values of PBL in snps,dwmac.yaml.

---
 Documentation/devicetree/bindings/net/snps,dwmac.yaml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings.

Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future.

Full log is available here: https://patchwork.ozlabs.org/patch/1608860

dwmac@9630000: $nodename:0: 'dwmac@9630000' does not match '^ethernet(@.*)?$'

	arch/arm/boot/dts/stih407-b2120.dt.yaml
	arch/arm/boot/dts/stih410-b2120.dt.yaml
	arch/arm/boot/dts/stih410-b2260.dt.yaml
	arch/arm/boot/dts/stih418-b2199.dt.yaml
	arch/arm/boot/dts/stih418-b2264.dt.yaml

eth@5c400000: $nodename:0: 'eth@5c400000' does not match '^ethernet(@.*)?$'

	arch/arm/boot/dts/spear1310-evb.dt.yaml

eth@5c400000: compatible: ['st,spear600-gmac'] does not contain items matching the given schema

	arch/arm/boot/dts/spear1310-evb.dt.yaml

eth@5c500000: $nodename:0: 'eth@5c500000' does not match '^ethernet(@.*)?$'

	arch/arm/boot/dts/spear1310-evb.dt.yaml

eth@5c500000: compatible: ['st,spear600-gmac'] does not contain items matching the given schema

	arch/arm/boot/dts/spear1310-evb.dt.yaml

eth@5c600000: $nodename:0: 'eth@5c600000' does not match '^ethernet(@.*)?$'

	arch/arm/boot/dts/spear1310-evb.dt.yaml

eth@5c600000: compatible: ['st,spear600-gmac'] does not contain items matching the given schema

	arch/arm/boot/dts/spear1310-evb.dt.yaml

eth@5c700000: $nodename:0: 'eth@5c700000' does not match '^ethernet(@.*)?$'

	arch/arm/boot/dts/spear1310-evb.dt.yaml

eth@5c700000: compatible: ['st,spear600-gmac'] does not contain items matching the given schema

	arch/arm/boot/dts/spear1310-evb.dt.yaml

eth@e0800000: $nodename:0: 'eth@e0800000' does not match '^ethernet(@.*)?$'

	arch/arm/boot/dts/spear300-evb.dt.yaml
	arch/arm/boot/dts/spear310-evb.dt.yaml
	arch/arm/boot/dts/spear320-evb.dt.yaml
	arch/arm/boot/dts/spear320-hmi.dt.yaml

eth@e2000000: $nodename:0: 'eth@e2000000' does not match '^ethernet(@.*)?$'

	arch/arm/boot/dts/spear1310-evb.dt.yaml
	arch/arm/boot/dts/spear1340-evb.dt.yaml

eth@e2000000: compatible: ['st,spear600-gmac'] does not contain items matching the given schema

	arch/arm/boot/dts/spear1310-evb.dt.yaml
	arch/arm/boot/dts/spear1340-evb.dt.yaml

ethernet@c9410000: 'phy-mode' is a required property

	arch/arm/boot/dts/meson6-atv1200.dt.yaml
	arch/arm/boot/dts/meson8-minix-neo-x8.dt.yaml

ethernet@e0800000: compatible: ['st,spear600-gmac'] does not contain items matching the given schema

	arch/arm/boot/dts/spear600-evb.dt.yaml

ethernet@f8010000: interrupt-names:1: 'eth_wake_irq' was expected
arch/arm/boot/dts/artpec6-devboard.dt.yaml

ethernet@fe2a0000: clock-names: ['stmmaceth', 'mac_clk_rx', 'mac_clk_tx', 'clk_mac_refout', 'aclk_mac', 'pclk_mac', 'clk_mac_speed', 'ptp_ref', 'pclk_xpcs'] is too long

	arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dt.yaml

ethernet@fe2a0000: clocks: [[15, 386], [15, 389], [15, 389], [15, 184], [15, 180], [15, 181], [15, 389], [15, 185], [15, 172]] is too long

	arch/arm64/boot/dts/rockchip/rk3568-evb1-v10.dt.yaml

ethernet@ff800000: reset-names: ['stmmaceth', 'stmmaceth-ocp'] is too long
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dt.yaml arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dt.yaml arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dt.yaml arch/arm64/boot/dts/intel/socfpga_agilex_socdk_nand.dt.yaml arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dt.yaml arch/arm/boot/dts/socfpga_arria10_mercury_aa1.dt.yaml arch/arm/boot/dts/socfpga_arria10_socdk_nand.dt.yaml arch/arm/boot/dts/socfpga_arria10_socdk_qspi.dt.yaml arch/arm/boot/dts/socfpga_arria10_socdk_sdmmc.dt.yaml

ethernet@ff800000: resets: [[6, 32], [6, 40]] is too long
arch/arm/boot/dts/socfpga_arria10_mercury_aa1.dt.yaml arch/arm/boot/dts/socfpga_arria10_socdk_nand.dt.yaml arch/arm/boot/dts/socfpga_arria10_socdk_qspi.dt.yaml arch/arm/boot/dts/socfpga_arria10_socdk_sdmmc.dt.yaml

ethernet@ff800000: resets: [[7, 32], [7, 40]] is too long
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dt.yaml arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dt.yaml arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dt.yaml arch/arm64/boot/dts/intel/socfpga_agilex_socdk_nand.dt.yaml arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dt.yaml

ethernet@ff802000: reset-names: ['stmmaceth', 'stmmaceth-ocp'] is too long
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dt.yaml arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dt.yaml arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dt.yaml arch/arm64/boot/dts/intel/socfpga_agilex_socdk_nand.dt.yaml arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dt.yaml arch/arm/boot/dts/socfpga_arria10_mercury_aa1.dt.yaml arch/arm/boot/dts/socfpga_arria10_socdk_nand.dt.yaml arch/arm/boot/dts/socfpga_arria10_socdk_qspi.dt.yaml arch/arm/boot/dts/socfpga_arria10_socdk_sdmmc.dt.yaml

ethernet@ff802000: resets: [[6, 33], [6, 41]] is too long
arch/arm/boot/dts/socfpga_arria10_mercury_aa1.dt.yaml arch/arm/boot/dts/socfpga_arria10_socdk_nand.dt.yaml arch/arm/boot/dts/socfpga_arria10_socdk_qspi.dt.yaml arch/arm/boot/dts/socfpga_arria10_socdk_sdmmc.dt.yaml

ethernet@ff802000: resets: [[7, 33], [7, 41]] is too long
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dt.yaml arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dt.yaml arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dt.yaml arch/arm64/boot/dts/intel/socfpga_agilex_socdk_nand.dt.yaml arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dt.yaml

ethernet@ff804000: reset-names: ['stmmaceth', 'stmmaceth-ocp'] is too long
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dt.yaml arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dt.yaml arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dt.yaml arch/arm64/boot/dts/intel/socfpga_agilex_socdk_nand.dt.yaml arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dt.yaml arch/arm/boot/dts/socfpga_arria10_mercury_aa1.dt.yaml arch/arm/boot/dts/socfpga_arria10_socdk_nand.dt.yaml arch/arm/boot/dts/socfpga_arria10_socdk_qspi.dt.yaml arch/arm/boot/dts/socfpga_arria10_socdk_sdmmc.dt.yaml

ethernet@ff804000: resets: [[6, 34], [6, 42]] is too long
arch/arm/boot/dts/socfpga_arria10_mercury_aa1.dt.yaml arch/arm/boot/dts/socfpga_arria10_socdk_nand.dt.yaml arch/arm/boot/dts/socfpga_arria10_socdk_qspi.dt.yaml arch/arm/boot/dts/socfpga_arria10_socdk_sdmmc.dt.yaml

ethernet@ff804000: resets: [[7, 34], [7, 42]] is too long
arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dt.yaml arch/arm64/boot/dts/altera/socfpga_stratix10_socdk_nand.dt.yaml arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dt.yaml arch/arm64/boot/dts/intel/socfpga_agilex_socdk_nand.dt.yaml arch/arm64/boot/dts/intel/socfpga_n5x_socdk.dt.yaml

eth@f0802000: $nodename:0: 'eth@f0802000' does not match '^ethernet(@.*)?$'
arch/arm/boot/dts/nuvoton-npcm730-gbs.dt.yaml arch/arm/boot/dts/nuvoton-npcm730-gsj.dt.yaml arch/arm/boot/dts/nuvoton-npcm730-kudo.dt.yaml arch/arm/boot/dts/nuvoton-npcm750-evb.dt.yaml arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dt.yaml

eth@f0804000: $nodename:0: 'eth@f0804000' does not match '^ethernet(@.*)?$'
arch/arm/boot/dts/nuvoton-npcm750-evb.dt.yaml arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dt.yaml

maintainer Applied
#4 lore raw

Re: [PATCH net-next] dt-bindings: net: snps,dwmac: modify available values of PBL

In reply to Biao Huang
Quoted 9 lines · Biao Huang

PBL can be any of the following values: 1, 2, 4, 8, 16 or 32 according to the datasheet, so modify available values of PBL in snps,dwmac.yaml.

---
 Documentation/devicetree/bindings/net/snps,dwmac.yaml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Applied, thanks!

_______________________________________________
Linux-mediatek mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-mediatek