Skip to contentSkip to conversation

lib/test: use after free in register_test_dev_kmod()

PATCH In review Dan Carpenter 2 participants 2 messages Mar 24, 2022

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lib/test: use after free in register_test_dev_kmod()

The "test_dev" pointer is freed but then returned to the caller.

Fixes d9c6a72d6fa2 ("kmod: add test driver to stress test the module loader")
---
 lib/test_kmod.c | 1 +
 1 file changed, 1 insertion(+)
lib/test_kmod.c +1 -0
index ce1589391413..cb800b1d0d99 100644
@@ -1149,6 +1149,7 @@ static struct kmod_test_device *register_test_dev_kmod(void)
 	if (ret) {
 		pr_err("could not register misc device: %d\n", ret);
 		free_test_dev_kmod(test_dev);
+		test_dev = NULL;
 		goto out;
 	}
 
Signature · 1 line
2.20.1
maintainer
#1 lore raw
Quoted 4 lines · Dan Carpenter

The "test_dev" pointer is freed but then returned to the caller.

Fixes d9c6a72d6fa2 ("kmod: add test driver to stress test the module loader")

Thanks queued onto modules-testing!

Luis