opp: replace usage of found with dedicated list iterator variable
PATCH 1/1 opp: replace usage of found with dedicated list iterator variable
To move the list iterator variable into the list_for_each_entry_*() macro in the future it should be avoided to use the list iterator variable after the loop body.
To *never* use the list iterator variable after the loop it was concluded to use a separate iterator variable instead of a found boolean [1].
This removes the need to use a found variable and simply checking if the variable was set, can determine if the break/goto was hit.
--- drivers/opp/core.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)
drivers/opp/core.c +5 -6
@@ -1461,9 +1461,8 @@ EXPORT_SYMBOL_GPL(dev_pm_opp_put);*/ void dev_pm_opp_remove (struct device *dev,unsigned long freq) { -struct dev_pm_opp *opp; +struct dev_pm_opp *opp =NULL , *iter;struct opp_table *opp_table; -bool found = false; opp_table =_find_opp_table (dev);if (IS_ERR (opp_table))
@@ -1471,16 +1470,16 @@ void dev_pm_opp_remove(struct device *dev, unsigned long freq)mutex_lock (&opp_table->lock); -list_for_each_entry (opp, &opp_table->opp_list, node) { -if (opp->rate == freq) { - found = true; +list_for_each_entry (iter, &opp_table->opp_list, node) { +if (iter->rate == freq) { + opp = iter;break ; } }mutex_unlock (&opp_table->lock); -if (found) { +if (opp) {dev_pm_opp_put (opp);/* Drop the reference taken by dev_pm_opp_add() */
base-commit: f443e374ae131c168a065ea1748feac6b2e76613
Signature · 1 line
2.25.1
Viresh Kumar
AppliedQuoted 8 lines · Jakob Koschel
To move the list iterator variable into the list_for_each_entry_*() macro in the future it should be avoided to use the list iterator variable after the loop body.
To *never* use the list iterator variable after the loop it was concluded to use a separate iterator variable instead of a found boolean [1].
Quoted 8 lines
This removes the need to use a found variable and simply checking if the variable was set, can determine if the break/goto was hit.
Link https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ open hereSigned-off-by Jakob Koschel <[email protected]>--- drivers/opp/core.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)
Applied. Thanks.
Signature · 1 line
viresh