soc: qcom: pdr: replace usage of found with dedicated list iterator variable
Subsystems (2)
PATCH 1/1 soc: qcom: pdr: replace usage of found with dedicated list iterator variable
To move the list iterator variable into the list_for_each_entry_*() macro in the future it should be avoided to use the list iterator variable after the loop body.
To *never* use the list iterator variable after the loop it was concluded to use a separate iterator variable instead of a found boolean [1].
This removes the need to use a found variable and simply checking if the variable was set, can determine if the break/goto was hit.
Link https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ open here
Signed-off-by Jakob Koschel <[email protected]>
--- drivers/soc/qcom/pdr_interface.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)
drivers/soc/qcom/pdr_interface.c +5 -6
@@ -304,24 +304,23 @@ static void pdr_indication_cb(struct qmi_handle *qmi, notifier_hdl);const struct servreg_state_updated_ind *ind_msg = data;struct pdr_list_node *ind; -struct pdr_service *pds; -bool found = false; +struct pdr_service *pds =NULL , *iter;if (!ind_msg || !ind_msg->service_path[0 ] ||strlen (ind_msg->service_path) >SERVREG_NAME_LENGTH )return ;mutex_lock (&pdr->list_lock); -list_for_each_entry (pds, &pdr->lookups, node) { -if (strcmp (pds->service_path, ind_msg->service_path)) +list_for_each_entry (iter, &pdr->lookups, node) { +if (strcmp (iter->service_path, ind_msg->service_path))continue ; - found = true; + pds = iter;break ; }mutex_unlock (&pdr->list_lock); -if (!found) +if (!pds)return ; pr_info("PDR: Indication received from %s, state: 0x%x, trans-id: %d\n",
base-commit: f443e374ae131c168a065ea1748feac6b2e76613
Signature · 1 line
2.25.1