Skip to contentSkip to conversation

auxdisplay: lcd2s: use simple i2c probe function

PATCH In review Stephen Kitt 2 participants 3 messages Mar 24, 2022 Auxiliary display drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 auxdisplay: lcd2s: use simple i2c probe function

The i2c probe functions here don't use the id information provided in their second argument, so the single-parameter i2c probe function ("probe_new") can be used instead.

This avoids scanning the identifier tables during probes.

---
 drivers/auxdisplay/lcd2s.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
drivers/auxdisplay/lcd2s.c +2 -3
index 2578b2d45439..0c64b46dbb71 100644
@@ -286,8 +286,7 @@ static const struct charlcd_ops lcd2s_ops = {
 	.redefine_char	= lcd2s_redefine_char,
 };
 
-static int lcd2s_i2c_probe(struct i2c_client *i2c,
-				const struct i2c_device_id *id)
+static int lcd2s_i2c_probe(struct i2c_client *i2c)
 {
 	struct charlcd *lcd;
 	struct lcd2s_data *lcd2s;
@@ -370,7 +369,7 @@ static struct i2c_driver lcd2s_i2c_driver = {
 		.of_match_table = of_match_ptr(lcd2s_of_table),
 #endif
 	},
-	.probe = lcd2s_i2c_probe,
+	.probe_new = lcd2s_i2c_probe,
 	.remove = lcd2s_i2c_remove,
 	.id_table = lcd2s_i2c_id,
 };
Signature · 1 line
2.27.0
#1 lore raw

Hi Stephen,

Quoted 6 lines · Stephen Kitt

The i2c probe functions here don't use the id information provided in their second argument, so the single-parameter i2c probe function ("probe_new") can be used instead.

This avoids scanning the identifier tables during probes.

Thanks for the patch -- Andy submitted an equivalent one which I queued for -next some days ago.

Cheers,
Miguel

#2 lore raw

Hi Miguel,

Quoted 9 lines · Miguel Ojeda
Quoted 5 lines · Stephen Kitt

The i2c probe functions here don't use the id information provided in their second argument, so the single-parameter i2c probe function ("probe_new") can be used instead.

This avoids scanning the identifier tables during probes.

Thanks for the patch -- Andy submitted an equivalent one which I queued for -next some days ago.

Ah yes,
https://lkml.kernel.org/lkml/[email protected]/

Thanks,

Stephen