Skip to contentSkip to conversation

regulator: fixed: Remove print on allocation failure

PATCH In review Mark Brown 1 participant 2 messages Mar 24, 2022 – Apr 5, 2022 Voltage and current regulator framework

lore
Share & tools
lore

Mark Brown

author maintainer
#0 lore raw

PATCH 1/1 regulator: fixed: Remove print on allocation failure

OOMs are very verbose, we don't need to print an additional error message when we fail to allocate.

---
 drivers/regulator/fixed.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
drivers/regulator/fixed.c +1 -4
index 9159755cde73..57f656857580 100644
@@ -236,11 +236,8 @@ static int reg_fixed_voltage_probe(struct platform_device *pdev)
 		drvdata->desc.supply_name = devm_kstrdup(&pdev->dev,
 					    config->input_supply,
 					    GFP_KERNEL);
-		if (!drvdata->desc.supply_name) {
-			dev_err(&pdev->dev,
-				"Failed to allocate input supply\n");
+		if (!drvdata->desc.supply_name)
 			return -ENOMEM;
-		}
 	}
 
 	if (config->microvolts)
Signature · 1 line
2.30.2
author maintainer
#1 lore raw
Quoted 4 lines · Mark Brown

OOMs are very verbose, we don't need to print an additional error message when we fail to allocate.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: fixed: Remove print on allocation failure

      commit: 6c315afe65d05dc6eebf2d6b73a191990aada218

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark